From 074c1555c8c7f48495919d7d7365d7e7879eb2b1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Christoph=20St=C3=A4bler?= <cstabler@redhat.com>
Date: Fri, 18 Nov 2022 09:28:11 +0100
Subject: [PATCH] Remove strict-subscriber flag
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The strict-subscriber feature flag was removed in
https://github.com/knative/eventing/pull/6608 so the validation cannot
be disabled anymore. This commit adjusts the docs too.

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
---
 config/nav.yml                                |  1 -
 docs/eventing/experimental-features/README.md |  1 -
 .../strict-subscriber.md                      | 34 -------------------
 3 files changed, 36 deletions(-)
 delete mode 100644 docs/eventing/experimental-features/strict-subscriber.md

diff --git a/config/nav.yml b/config/nav.yml
index 6b784c7177e..1b88c043aa4 100644
--- a/config/nav.yml
+++ b/config/nav.yml
@@ -271,7 +271,6 @@ nav:
         - New Trigger Filters: eventing/experimental-features/new-trigger-filters.md
         - KReference.Group field: eventing/experimental-features/kreference-group.md
         - Knative reference mapping: eventing/experimental-features/kreference-mapping.md
-        - Strict Subscriber: eventing/experimental-features/strict-subscriber.md
     # Eventing reference docs
       - Reference:
         - Eventing API: eventing/reference/eventing-api.md
diff --git a/docs/eventing/experimental-features/README.md b/docs/eventing/experimental-features/README.md
index bc9ea427ebb..926e84ca5a2 100644
--- a/docs/eventing/experimental-features/README.md
+++ b/docs/eventing/experimental-features/README.md
@@ -74,4 +74,3 @@ Knative Eventing:
 | [KReference.Group field](kreference-group.md) | `kreference-group` | Specify the API `group` of `KReference` resources without the API version. | Alpha, disabled by default |
 | [Knative reference mapping](kreference-mapping.md) | `kreference-mapping` | Provide mappings from a [Knative reference](https://github.com/knative/specs/blob/main/specs/eventing/overview.md#destination) to a templated URI. | Alpha, disabled by default |
 | [New trigger filters](new-trigger-filters.md) | `new-trigger-filters` | Enables a new Trigger `filters` field that supports a set of powerful filter expressions. | Alpha, disabled by default |
-| [Strict Subscriber](strict-subscriber.md) | `strict-subscriber` | Invalidates Subscriptions if the field `spec.subscriber` is not defined. | Alpha, disabled by default |
diff --git a/docs/eventing/experimental-features/strict-subscriber.md b/docs/eventing/experimental-features/strict-subscriber.md
deleted file mode 100644
index bbdeff60c77..00000000000
--- a/docs/eventing/experimental-features/strict-subscriber.md
+++ /dev/null
@@ -1,34 +0,0 @@
-# Strict Subscriber
-
-**Flag name**: `strict-subscriber`
-
-**Stage**: Beta, enabled by default
-
-**Tracking issue**: [#5762](https://github.com/knative/eventing/pull/5762)
-
-When defining a Subscription, if the `strict-subscriber` flag is enabled,
-validation fails if the field `spec.subscriber` is not defined. This flag was
-implemented to follow the latest version of
-the [Knative Eventing spec](https://github.com/knative/specs/tree/main/specs/eventing)
-.
-
-For example, the following Subscription will fail validation if
-the `strict-subscriber` flag is enabled:
-
-```yaml
-apiVersion: messaging.knative.dev/v1
-kind: Subscription
-metadata:
-  name: example-subscription
-  namespace: example-namespace
-spec:
-  reply:
-    ref:
-      apiVersion: serving.knative.dev/v1
-      kind: Service
-      name: example-reply
-```
-
-With the flag disabled (default behavior) the Subscription can define either a
-subscriber or a reply field, and validation will succeed. This is the default
-behavior in Knative v0.26 and earlier.