From 578f3d7d7f156137bb12755e3474149ba228c545 Mon Sep 17 00:00:00 2001
From: Ville Aikas <vaikas@google.com>
Date: Thu, 25 Apr 2019 20:21:33 +0000
Subject: [PATCH] make sure NewController doesn't return nil

---
 pkg/reconciler/trigger/trigger_test.go | 39 ++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/pkg/reconciler/trigger/trigger_test.go b/pkg/reconciler/trigger/trigger_test.go
index 7fa47f42b08..7b4215fb184 100644
--- a/pkg/reconciler/trigger/trigger_test.go
+++ b/pkg/reconciler/trigger/trigger_test.go
@@ -22,6 +22,8 @@ import (
 	"testing"
 
 	"github.com/knative/eventing/pkg/apis/eventing/v1alpha1"
+	fakeclientset "github.com/knative/eventing/pkg/client/clientset/versioned/fake"
+	informers "github.com/knative/eventing/pkg/client/informers/externalversions"
 	"github.com/knative/eventing/pkg/reconciler"
 	reconciletesting "github.com/knative/eventing/pkg/reconciler/testing"
 	"github.com/knative/eventing/pkg/reconciler/trigger/resources"
@@ -36,6 +38,8 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
+	kubeinformers "k8s.io/client-go/informers"
+	fakekubeclientset "k8s.io/client-go/kubernetes/fake"
 	"k8s.io/client-go/kubernetes/scheme"
 	clientgotesting "k8s.io/client-go/testing"
 )
@@ -73,6 +77,41 @@ func init() {
 	_ = duckv1alpha1.AddToScheme(scheme.Scheme)
 }
 
+func TestNewController(t *testing.T) {
+	kubeClient := fakekubeclientset.NewSimpleClientset()
+	eventingClient := fakeclientset.NewSimpleClientset()
+
+	// Create informer factories with fake clients. The second parameter sets the
+	// resync period to zero, disabling it.
+	kubeInformerFactory := kubeinformers.NewSharedInformerFactory(kubeClient, 0)
+	eventingInformerFactory := informers.NewSharedInformerFactory(eventingClient, 0)
+
+	// Eventing
+	triggerInformer := eventingInformerFactory.Eventing().V1alpha1().Triggers()
+	channelInformer := eventingInformerFactory.Eventing().V1alpha1().Channels()
+	subscriptionInformer := eventingInformerFactory.Eventing().V1alpha1().Subscriptions()
+	brokerInformer := eventingInformerFactory.Eventing().V1alpha1().Brokers()
+
+	// Kube
+	serviceInformer := kubeInformerFactory.Core().V1().Services()
+
+	c := NewController(
+		reconciler.Options{
+			KubeClientSet:     kubeClient,
+			EventingClientSet: eventingClient,
+			Logger:            logtesting.TestLogger(t),
+		},
+		triggerInformer,
+		channelInformer,
+		subscriptionInformer,
+		brokerInformer,
+		serviceInformer)
+
+	if c == nil {
+		t.Fatalf("Failed to create with NewController")
+	}
+}
+
 func TestAllCases(t *testing.T) {
 	triggerKey := testNS + "/" + triggerName
 	table := TableTest{