From c7db55539dc51490327a7e0f3b89c5f860c12e3c Mon Sep 17 00:00:00 2001 From: Lukas Berk Date: Tue, 12 May 2020 10:28:22 -0400 Subject: [PATCH 1/5] Add note to channel spec regarding channel subscription spec The spec.subscription fields shouldn't be set directly, rather it should be set via the subscriptions themselves and then the status should be propogated via the channel. --- docs/spec/channel.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/docs/spec/channel.md b/docs/spec/channel.md index 6e9b425b3b6..55784f9aa87 100644 --- a/docs/spec/channel.md +++ b/docs/spec/channel.md @@ -182,6 +182,9 @@ Each channel CRD MUST contain an array of subscribers: Each channel CRD MUST contain an array of subscribers: [`spec.subscribers`](https://github.com/knative/eventing/blob/master/pkg/apis/duck/v1beta1/subscribable_types.go) +Note: the array of subscribers MUST NOT be set directly on the channel, but +rather appended by the subscription itself. + #### Status Requirements ##### v1alpha1 Status From 7bb56728dc8265e591b29af08926c9192e688eb1 Mon Sep 17 00:00:00 2001 From: Lukas Berk Date: Thu, 14 May 2020 09:22:17 -0400 Subject: [PATCH 2/5] Update wording based on feedback to clarify backing channel & channel --- docs/spec/channel.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/spec/channel.md b/docs/spec/channel.md index 55784f9aa87..8047228e0e1 100644 --- a/docs/spec/channel.md +++ b/docs/spec/channel.md @@ -182,8 +182,9 @@ Each channel CRD MUST contain an array of subscribers: Each channel CRD MUST contain an array of subscribers: [`spec.subscribers`](https://github.com/knative/eventing/blob/master/pkg/apis/duck/v1beta1/subscribable_types.go) -Note: the array of subscribers MUST NOT be set directly on the channel, but -rather appended by the subscription itself. +Note: The array of subscribers MUST NOT be set directly on the generic +Channel CR, but rather appended to the backing channel by the +subscription itself. #### Status Requirements From 7465c76f2eb05d25a11dd545fcc07e303fa4f327 Mon Sep 17 00:00:00 2001 From: Lukas Berk Date: Thu, 14 May 2020 09:27:04 -0400 Subject: [PATCH 3/5] linting suggestion change Co-authored-by: Matt Moore --- docs/spec/channel.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/docs/spec/channel.md b/docs/spec/channel.md index 8047228e0e1..65209dc3bcf 100644 --- a/docs/spec/channel.md +++ b/docs/spec/channel.md @@ -182,9 +182,8 @@ Each channel CRD MUST contain an array of subscribers: Each channel CRD MUST contain an array of subscribers: [`spec.subscribers`](https://github.com/knative/eventing/blob/master/pkg/apis/duck/v1beta1/subscribable_types.go) -Note: The array of subscribers MUST NOT be set directly on the generic -Channel CR, but rather appended to the backing channel by the -subscription itself. +Note: The array of subscribers MUST NOT be set directly on the generic Channel +CR, but rather appended to the backing channel by the subscription itself. #### Status Requirements From 2837ca2ce42d7c10d0cadf1256a29123d528f42a Mon Sep 17 00:00:00 2001 From: Lukas Berk Date: Thu, 14 May 2020 20:01:23 -0400 Subject: [PATCH 4/5] change CR to custom object Co-authored-by: Adam Harwayne --- docs/spec/channel.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/spec/channel.md b/docs/spec/channel.md index 65209dc3bcf..e3c1dca838d 100644 --- a/docs/spec/channel.md +++ b/docs/spec/channel.md @@ -183,7 +183,7 @@ Each channel CRD MUST contain an array of subscribers: [`spec.subscribers`](https://github.com/knative/eventing/blob/master/pkg/apis/duck/v1beta1/subscribable_types.go) Note: The array of subscribers MUST NOT be set directly on the generic Channel -CR, but rather appended to the backing channel by the subscription itself. +custom object, but rather appended to the backing channel by the subscription itself. #### Status Requirements From e53fb4d2188946af23f17246258fc96fe3766ea0 Mon Sep 17 00:00:00 2001 From: Lukas Berk Date: Thu, 14 May 2020 20:02:15 -0400 Subject: [PATCH 5/5] more linting Co-authored-by: Matt Moore --- docs/spec/channel.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/spec/channel.md b/docs/spec/channel.md index e3c1dca838d..56c44b6aa06 100644 --- a/docs/spec/channel.md +++ b/docs/spec/channel.md @@ -183,7 +183,8 @@ Each channel CRD MUST contain an array of subscribers: [`spec.subscribers`](https://github.com/knative/eventing/blob/master/pkg/apis/duck/v1beta1/subscribable_types.go) Note: The array of subscribers MUST NOT be set directly on the generic Channel -custom object, but rather appended to the backing channel by the subscription itself. +custom object, but rather appended to the backing channel by the subscription +itself. #### Status Requirements