From 9ae9eba732ad2fff5a2a3000723fc5e3e69bc877 Mon Sep 17 00:00:00 2001 From: Gregory Haynes Date: Thu, 16 Aug 2018 20:54:59 +0000 Subject: [PATCH] Fix env var len check in gh feedlet The logic is inverted when we are checking for existence of FEED_NAMESPACE and other env vars in the gihub source feedlet - we are asserting len != 0 rather than len == 0. --- pkg/sources/github/feedlet/feedlet.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/sources/github/feedlet/feedlet.go b/pkg/sources/github/feedlet/feedlet.go index 5f479d33f20..4a79db23942 100644 --- a/pkg/sources/github/feedlet/feedlet.go +++ b/pkg/sources/github/feedlet/feedlet.go @@ -368,13 +368,13 @@ func main() { } feedNamespace := os.Getenv(sources.FeedNamespaceKey) - if len(feedNamespace) != 0 { + if len(feedNamespace) == 0 { log.Printf("Fatal: feed namespace not provided, expected envvar %q to be set", sources.FeedNamespaceKey) os.Exit(1) } feedServiceAccountName := os.Getenv(sources.FeedServiceAccountKey) - if len(feedServiceAccountName) != 0 { + if len(feedServiceAccountName) == 0 { log.Printf("Fatal: feed service account not provided, expected envvar %q to be set", sources.FeedServiceAccountKey) os.Exit(1) }