From 07b7b4a597e50d73c6fe29e5afc75d5bbc29bf28 Mon Sep 17 00:00:00 2001 From: Tanzeeb Khalili Date: Fri, 24 Aug 2018 17:40:32 -0400 Subject: [PATCH] Change references to EventType pullrequest to dev.knative.github.pullrequest in github sample --- sample/github/README.md | 4 ++-- sample/github/flow.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sample/github/README.md b/sample/github/README.md index af796115b44..337da93a456 100644 --- a/sample/github/README.md +++ b/sample/github/README.md @@ -44,7 +44,7 @@ ko apply -f config/buses/stub ko apply -f pkg/sources/github/ ``` -5. Check that the GitHub is now showing up as an event source and there's an event type for *pullrequests* +5. Check that the GitHub is now showing up as an event source and there's an event type for *dev.knative.github.pullrequest* ```shell kubectl get eventsources @@ -78,7 +78,7 @@ In response to a pull request event, the _legit_ Service will add `(looks pretty Deploy the _legit_ service via: ```shell -ko apply sample/github/legit-service.yaml +ko apply -f sample/github/legit-service.yaml ``` Once deployed, you can inspect the created resources with `kubectl` commands: diff --git a/sample/github/flow.yaml b/sample/github/flow.yaml index 150bfcd693e..30515788804 100644 --- a/sample/github/flow.yaml +++ b/sample/github/flow.yaml @@ -20,7 +20,7 @@ metadata: spec: serviceAccountName: feed-sa trigger: - eventType: pullrequest + eventType: dev.knative.github.pullrequest resource: / # TODO: Fill this out service: github parameters: