diff --git a/metrics/exporter.go b/metrics/exporter.go index f8c778b482..528e7eb1d4 100644 --- a/metrics/exporter.go +++ b/metrics/exporter.go @@ -16,6 +16,7 @@ package metrics import ( "errors" "fmt" + "strings" "sync" "go.opencensus.io/stats/view" @@ -89,7 +90,7 @@ func ConfigMapWatcher(component string, secrets SecretFetcher, logger *zap.Sugar return func(configMap *corev1.ConfigMap) { UpdateExporter(ExporterOptions{ Domain: domain, - Component: component, + Component: strings.ReplaceAll(component, "-", "_"), ConfigMap: configMap.Data, Secrets: secrets, }, logger) diff --git a/metrics/exporter_test.go b/metrics/exporter_test.go index 7bd8bee531..e0829ce038 100644 --- a/metrics/exporter_test.go +++ b/metrics/exporter_test.go @@ -84,6 +84,17 @@ func TestMetricsExporter(t *testing.T) { }, }, expectSuccess: true, + }, { + name: "validConfigWithDashInName", + config: &metricsConfig{ + domain: servingDomain, + component: "test-component", + backendDestination: Stackdriver, + stackdriverClientConfig: StackdriverClientConfig{ + ProjectID: "testProj", + }, + }, + expectSuccess: true, }, { name: "stackdriverConfigOnly", config: &metricsConfig{