From 38ca94e797fc1662ee4c891aaa93c95d80e7c89c Mon Sep 17 00:00:00 2001 From: Matthias Wessendorf Date: Thu, 18 Jun 2020 15:17:07 +0200 Subject: [PATCH 1/3] :lipstick: adding constant for label Signed-off-by: Matthias Wessendorf --- apis/duck/register.go | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/apis/duck/register.go b/apis/duck/register.go index d10adc21ce..833b6d248f 100644 --- a/apis/duck/register.go +++ b/apis/duck/register.go @@ -18,4 +18,12 @@ package duck const ( GroupName = "duck.knative.dev" + + // AddressableDuckVersionLabel is the label we use to declare + // which Addressable duck version type we conform to. + AddressableDuckVersionLabel = "duck.knative.dev/addressable" + + // SourceDuckVersionLabel is the label we use to declare + // which Source duck version type we conform to. + SourceDuckVersionLabel = "duck.knative.dev/source" ) From 9c939639ac4a4e8421ab85a6dab705f8b9ab5490 Mon Sep 17 00:00:00 2001 From: Matthias Wessendorf Date: Mon, 22 Jun 2020 15:35:06 +0200 Subject: [PATCH 2/3] Update apis/duck/register.go Co-authored-by: Antoine Cotten --- apis/duck/register.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apis/duck/register.go b/apis/duck/register.go index 833b6d248f..972db878f9 100644 --- a/apis/duck/register.go +++ b/apis/duck/register.go @@ -20,7 +20,7 @@ const ( GroupName = "duck.knative.dev" // AddressableDuckVersionLabel is the label we use to declare - // which Addressable duck version type we conform to. + // that a type conforms to the Addressable duck type. AddressableDuckVersionLabel = "duck.knative.dev/addressable" // SourceDuckVersionLabel is the label we use to declare From 04dbf5acef5e5054f90834182a5f5409a6f8ff23 Mon Sep 17 00:00:00 2001 From: Matthias Wessendorf Date: Mon, 22 Jun 2020 15:35:13 +0200 Subject: [PATCH 3/3] Update apis/duck/register.go Co-authored-by: Antoine Cotten --- apis/duck/register.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apis/duck/register.go b/apis/duck/register.go index 972db878f9..d84cd49d18 100644 --- a/apis/duck/register.go +++ b/apis/duck/register.go @@ -24,6 +24,6 @@ const ( AddressableDuckVersionLabel = "duck.knative.dev/addressable" // SourceDuckVersionLabel is the label we use to declare - // which Source duck version type we conform to. + // that a type conforms to the Source duck type. SourceDuckVersionLabel = "duck.knative.dev/source" )