From 84f112f6c15c48bce4c901b80e9e802b38f98adc Mon Sep 17 00:00:00 2001 From: Matt Moore Date: Tue, 12 Jun 2018 19:07:11 +0000 Subject: [PATCH] Remove dead code. --- pkg/controller/revision/revision.go | 21 --------------------- 1 file changed, 21 deletions(-) diff --git a/pkg/controller/revision/revision.go b/pkg/controller/revision/revision.go index 2e408bd6387e..0b103e23daf4 100644 --- a/pkg/controller/revision/revision.go +++ b/pkg/controller/revision/revision.go @@ -832,27 +832,6 @@ func (c *Controller) reconcileAutoscalerDeployment(ctx context.Context, rev *v1a return err } -func (c *Controller) removeFinalizers(ctx context.Context, rev *v1alpha1.Revision, ns string) error { - logger := logging.FromContext(ctx) - logger.Infof("Removing finalizers for %q\n", rev.Name) - accessor, err := meta.Accessor(rev) - if err != nil { - logger.Panic("Failed to get metadata", zap.Error(err)) - } - finalizers := accessor.GetFinalizers() - for i, v := range finalizers { - if v == "controller" { - finalizers = append(finalizers[:i], finalizers[i+1:]...) - } - } - accessor.SetFinalizers(finalizers) - prClient := c.ElaClientSet.ServingV1alpha1().Revisions(rev.Namespace) - prClient.Update(rev) - logger.Infof("The finalizer 'controller' is removed.") - - return nil -} - func (c *Controller) updateStatus(rev *v1alpha1.Revision) (*v1alpha1.Revision, error) { prClient := c.ElaClientSet.ServingV1alpha1().Revisions(rev.Namespace) newRev, err := prClient.Get(rev.Name, metav1.GetOptions{})