From c72dd95dafeb862cb9c9818228541f293627bd3a Mon Sep 17 00:00:00 2001 From: Nghia Tran Date: Wed, 11 Mar 2020 16:20:19 -0700 Subject: [PATCH 1/2] Add ZhiminXiang to approvers. From ROLES.md 1/ Reviewer of the codebase for at least 3 months. https://github.com/knative/serving/pull/1687 is 1 year old. 2/ Primary reviewer for at least 10 substantial PRs to the codebase. 7 XLs: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXXL 3 Ls: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FXL+ 9 Ms: https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+label%3Asize%2FM 3/ 33 Reviewed PRs https://github.com/knative/serving/pulls?q=is%3Apr+assignee%3AZhiminXiang+is%3Aclosed+reviewed-by%3AZhiminXiang+ 4/ 81 Merged PRs https://github.com/knative/serving/pulls?q=is%3Apr+is%3Aclosed+author%3AZhiminXiang 4/ Nominated by nghia@ with no objections from other leads --- OWNERS_ALIASES | 1 + 1 file changed, 1 insertion(+) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index f24829277a54..fd5bfe1a51fa 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -58,6 +58,7 @@ aliases: - mdemirhan - tcnghia - vagababov + - ZhiminXiang networking-reviewers: - JRBANCEL - ZhiminXiang From 7d72360e42c392f1be57213c4df75d86cda009fe Mon Sep 17 00:00:00 2001 From: Nghia Tran Date: Wed, 11 Mar 2020 17:59:42 -0700 Subject: [PATCH 2/2] Sort the lines. --- OWNERS_ALIASES | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OWNERS_ALIASES b/OWNERS_ALIASES index fd5bfe1a51fa..deab79966d61 100644 --- a/OWNERS_ALIASES +++ b/OWNERS_ALIASES @@ -61,10 +61,10 @@ aliases: - ZhiminXiang networking-reviewers: - JRBANCEL - - ZhiminXiang - markusthoemmes - mdemirhan - nak3 - tcnghia - vagababov - yanweiguo + - ZhiminXiang