From 9659cf21fe4a16efc6ca9dc1be05089ec6b6ea3d Mon Sep 17 00:00:00 2001 From: phillipc Date: Mon, 20 Apr 2026 20:09:07 +0200 Subject: [PATCH] Refactor string manipulation methods from substr to substring for consistency --- packages/binding.core/src/attr.ts | 2 +- packages/filter.punches/src/index.ts | 4 ++-- packages/utils.parser/src/preparse.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/binding.core/src/attr.ts b/packages/binding.core/src/attr.ts index 6437cceac..4c4d0bc28 100644 --- a/packages/binding.core/src/attr.ts +++ b/packages/binding.core/src/attr.ts @@ -12,7 +12,7 @@ export const attr = { // Find the namespace of this attribute, if any. const prefixLen = attrName.indexOf(':') - const namespace = prefixLen > 0 && element.lookupNamespaceURI(attrName.substr(0, prefixLen)) + const namespace = prefixLen > 0 && element.lookupNamespaceURI(attrName.substring(0, prefixLen)) // To cover cases like "attr: { checked:someProp }", we want to remove the attribute entirely // when someProp is a "no value"-like value (strictly null, false, or undefined) diff --git a/packages/filter.punches/src/index.ts b/packages/filter.punches/src/index.ts index 3d06f1fb4..32bb40851 100644 --- a/packages/filter.punches/src/index.ts +++ b/packages/filter.punches/src/index.ts @@ -51,10 +51,10 @@ const filters: Filters = { return replacement + value.slice(-length) case 'middle': { const leftLen = Math.ceil(length / 2) - return value.substr(0, leftLen) + replacement + value.slice(leftLen - length) + return value.substring(0, leftLen) + replacement + value.slice(leftLen - length) } default: - return value.substr(0, length) + replacement + return value.substring(0, length) + replacement } } else { return value diff --git a/packages/utils.parser/src/preparse.ts b/packages/utils.parser/src/preparse.ts index 042141c9b..545e7c36e 100644 --- a/packages/utils.parser/src/preparse.ts +++ b/packages/utils.parser/src/preparse.ts @@ -91,7 +91,7 @@ export default function parseObjectLiteral(objectLiteralString) { const match = toks[i - 1].match(divisionLookBehind) if (match && !keywordRegexLookBehind[match[0]]) { // The slash is actually a division punctuator; re-parse the remainder of the string (not including the slash) - str = str.substr(str.indexOf(tok) + 1) + str = str.substring(str.indexOf(tok) + 1) toks = str.match(bindingToken) i = -1 // Continue with just the slash