From 591f816923f969aa6de23a6d34c39194e2b2bd40 Mon Sep 17 00:00:00 2001
From: Kittywhiskers Van Gogh <63189531+kwvg@users.noreply.github.com>
Date: Tue, 17 Feb 2026 20:25:14 +0530
Subject: [PATCH 1/2] qt: add support for reporting `OP_RETURN` payloads as
 Data Transactions

Proposals are made in the form of data transactions but look like oddly
shaped transactions in the UI, this should help better explain where the
proposal fee went.
---
 src/qt/transactiondesc.cpp       | 25 +++++++++++++++++++++++++
 src/qt/transactionrecord.cpp     | 18 +++++++++++++++++-
 src/qt/transactionrecord.h       |  8 ++++++++
 src/qt/transactiontablemodel.cpp |  5 +++++
 src/qt/transactionview.cpp       |  1 +
 5 files changed, 56 insertions(+), 1 deletion(-)

diff --git a/src/qt/transactiondesc.cpp b/src/qt/transactiondesc.cpp
index 821781c9f077..067b5edb682a 100644
--- a/src/qt/transactiondesc.cpp
+++ b/src/qt/transactiondesc.cpp
@@ -19,8 +19,10 @@
 #include <interfaces/node.h>
 #include <interfaces/wallet.h>
 #include <util/system.h>
+#include <util/strencodings.h>
 #include <validation.h>
 #include <wallet/ismine.h>
+#include <script/script.h>
 
 #include <stdint.h>
 #include <string>
@@ -294,6 +296,29 @@ QString TransactionDesc::toHTML(interfaces::Node& node, interfaces::Wallet& wall
     strHTML += "<b>" + tr("Output index") + ":</b> " + QString::number(rec->getOutputIndex()) + "<br>";
     strHTML += "<b>" + tr("Transaction total size") + ":</b> " + QString::number(wtx.tx->GetTotalSize()) + " bytes<br>";
 
+    // List all OP_RETURN payloads
+    if (rec->type == TransactionRecord::DataTransaction) {
+        for (const auto& txout : wtx.tx->vout) {
+            if (!TransactionRecord::IsDataScript(txout.scriptPubKey)) {
+                continue;
+            }
+            const auto& script{txout.scriptPubKey};
+            // Extract all data pushes after OP_RETURN
+            const auto payload = [&script]() {
+                auto pc = script.begin() + 1; // Skip opcode
+                opcodetype opcode;
+                std::vector<uint8_t> ret{}, vch{};
+                while (pc < script.end() && script.GetOp(pc, opcode, vch)) {
+                    ret.insert(ret.end(), vch.begin(), vch.end());
+                }
+                return ret;
+            }();
+            if (!payload.empty()) {
+                strHTML += "<b>" + tr("Payload") + ":</b> " + QString::fromStdString(HexStr(payload)) + "<br>";
+            }
+        }
+    }
+
     // Message from normal dash:URI (dash:XyZ...?message=example)
     for (const std::pair<std::string, std::string>& r : orderForm) {
         if (r.first == "Message")
diff --git a/src/qt/transactionrecord.cpp b/src/qt/transactionrecord.cpp
index 478b565b3187..52699082edc2 100644
--- a/src/qt/transactionrecord.cpp
+++ b/src/qt/transactionrecord.cpp
@@ -10,6 +10,7 @@
 #include <interfaces/node.h>
 
 #include <wallet/ismine.h>
+#include <script/script.h>
 
 #include <cstdint>
 
@@ -102,6 +103,15 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(interfaces::Nod
 
                 parts.append(sub);
             }
+            else if (!wtx.is_coinbase && IsDataScript(txout.scriptPubKey))
+            {
+                TransactionRecord sub(hash, nTime);
+                sub.idx = i;
+                sub.credit = txout.nValue;
+                sub.type = TransactionRecord::DataTransaction;
+                sub.strAddress = "";
+                parts.append(sub);
+            }
         }
     }
     else
@@ -236,7 +246,13 @@ QList<TransactionRecord> TransactionRecord::decomposeTransaction(interfaces::Nod
                     continue;
                 }
 
-                if (!std::get_if<CNoDestination>(&wtx.txout_address[nOut]))
+                if (IsDataScript(txout.scriptPubKey))
+                {
+                    sub.type = TransactionRecord::DataTransaction;
+                    sub.strAddress = "";
+                    sub.txDest = DecodeDestination(sub.strAddress);
+                }
+                else if (!std::get_if<CNoDestination>(&wtx.txout_address[nOut]))
                 {
                     // Sent to Dash Address
                     sub.type = TransactionRecord::SendToAddress;
diff --git a/src/qt/transactionrecord.h b/src/qt/transactionrecord.h
index e889eca364fa..bf157d1b470b 100644
--- a/src/qt/transactionrecord.h
+++ b/src/qt/transactionrecord.h
@@ -19,6 +19,8 @@ struct WalletTx;
 struct WalletTxStatus;
 }
 
+class CScript;
+
 /** UI model for transaction status. The transaction status is the part of a transaction that will change over time.
  */
 struct TransactionStatus {
@@ -87,11 +89,17 @@ class TransactionRecord
         CoinJoinSend,
         PlatformTransfer,
         DustReceive,
+        DataTransaction,
     };
 
     /** Number of confirmation recommended for accepting a transaction */
     static const int RecommendedNumConfirmations = 6;
 
+    /** Check if script is an OP_RETURN data script */
+    static bool IsDataScript(const CScript& script) {
+        return script.IsUnspendable() && !script.empty() && script[0] == OP_RETURN;
+    }
+
     TransactionRecord():
             hash(), time(0), type(Other), debit(0), credit(0), idx(0)
     {
diff --git a/src/qt/transactiontablemodel.cpp b/src/qt/transactiontablemodel.cpp
index 73a689fa9317..dae027036468 100644
--- a/src/qt/transactiontablemodel.cpp
+++ b/src/qt/transactiontablemodel.cpp
@@ -433,6 +433,8 @@ QString TransactionTableModel::formatTxType(const TransactionRecord *wtx) const
         return tr("Mined");
     case TransactionRecord::PlatformTransfer:
         return tr("Platform Transfer");
+    case TransactionRecord::DataTransaction:
+        return tr("Data Transaction");
     case TransactionRecord::DustReceive:
         return tr("Dust Receive");
 
@@ -489,6 +491,7 @@ QString TransactionTableModel::formatTxToAddress(const TransactionRecord *wtx, b
     case TransactionRecord::CoinJoinCollateralPayment:
     case TransactionRecord::CoinJoinMakeCollaterals:
     case TransactionRecord::CoinJoinCreateDenominations:
+    case TransactionRecord::DataTransaction:
     case TransactionRecord::Other:
         break; // use fail-over here
     } // no default case, so the compiler can warn about missing cases
@@ -517,6 +520,7 @@ QVariant TransactionTableModel::addressColor(const TransactionRecord *wtx) const
     case TransactionRecord::CoinJoinMixing:
     case TransactionRecord::CoinJoinMakeCollaterals:
     case TransactionRecord::CoinJoinCollateralPayment:
+    case TransactionRecord::DataTransaction:
         return GUIUtil::getThemedQColor(GUIUtil::ThemedColor::BAREADDRESS);
     case TransactionRecord::SendToOther:
     case TransactionRecord::RecvFromOther:
@@ -551,6 +555,7 @@ QVariant TransactionTableModel::amountColor(const TransactionRecord *rec) const
     case TransactionRecord::CoinJoinSend:
     case TransactionRecord::SendToAddress:
     case TransactionRecord::SendToOther:
+    case TransactionRecord::DataTransaction:
     case TransactionRecord::Other:
         return GUIUtil::getThemedQColor(GUIUtil::ThemedColor::RED);
     case TransactionRecord::SendToSelf:
diff --git a/src/qt/transactionview.cpp b/src/qt/transactionview.cpp
index 1ea2e541c07a..19b62418b4f9 100644
--- a/src/qt/transactionview.cpp
+++ b/src/qt/transactionview.cpp
@@ -96,6 +96,7 @@ TransactionView::TransactionView(QWidget* parent) :
     typeWidget->addItem(tr("To yourself"), TransactionFilterProxy::TYPE(TransactionRecord::SendToSelf));
     typeWidget->addItem(tr("Mined"), TransactionFilterProxy::TYPE(TransactionRecord::Generated));
     typeWidget->addItem(tr("Platform Transfer"), TransactionFilterProxy::TYPE(TransactionRecord::PlatformTransfer));
+    typeWidget->addItem(tr("Data Transaction"), TransactionFilterProxy::TYPE(TransactionRecord::DataTransaction));
     typeWidget->addItem(tr("Dust Receive"), TransactionFilterProxy::TYPE(TransactionRecord::DustReceive));
     typeWidget->addItem(tr("Other"), TransactionFilterProxy::TYPE(TransactionRecord::Other));
     typeWidget->setCurrentIndex(settings.value("transactionType").toInt());

From 3ed072eac96cc4084b9679e9788247e91017c9fd Mon Sep 17 00:00:00 2001
From: PastaClaw <thepastaclaw@users.noreply.github.com>
Date: Tue, 17 Feb 2026 13:52:02 -0600
Subject: [PATCH 2/2] fix(qt): correct updateWidth button check and banned node
 filter

- updateWidth: use isVisible() instead of isEnabled() for width
  calculation. Disabled-but-visible buttons should still contribute to
  the minimum window width since they occupy layout space.

- masternodemodel: return 1 instead of 0 for banned nodes with unknown
  ban time. The 'Hide Banned' filter checks status_value > 0, so
  returning 0 would let these nodes escape the filter.
---
 src/qt/bitcoingui.cpp      | 2 +-
 src/qt/masternodemodel.cpp | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp
index 256aec68f65d..809b15a40af1 100644
--- a/src/qt/bitcoingui.cpp
+++ b/src/qt/bitcoingui.cpp
@@ -1555,7 +1555,7 @@ void BitcoinGUI::updateWidth()
     int nWidthWidestButton{0};
     int nButtonsVisible{0};
     for (QAbstractButton* button : tabGroup->buttons()) {
-        if (!button->isEnabled() || !button->isVisible()) {
+        if (!button->isVisible()) {
             continue;
         }
         QFontMetrics fm(button->font());
diff --git a/src/qt/masternodemodel.cpp b/src/qt/masternodemodel.cpp
index 39477c1f1795..b2f31aebe5e1 100644
--- a/src/qt/masternodemodel.cpp
+++ b/src/qt/masternodemodel.cpp
@@ -291,7 +291,7 @@ QVariant MasternodeModel::data(const QModelIndex& index, int role) const
                     if (auto ban_height = entry->poseBanHeight(); ban_height && *ban_height > 0) {
                         return m_current_height - *ban_height;
                     }
-                    return 0; // Unknown ban time, treat as freshly banned
+                    return 1; // Unknown ban time, still positive so filter works
                 } else {
                     // Active nodes use negative values
                     int32_t active_height = entry->registeredHeight();