From 42103381b3e130f0e05910e2d53f624e1288afc4 Mon Sep 17 00:00:00 2001 From: OHZEKI Naoki <0h23k1.n40k1@gmail.com> Date: Tue, 22 Nov 2022 21:52:20 +0900 Subject: [PATCH 1/2] defer Close on body_limit_test --- middleware/body_limit_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/middleware/body_limit_test.go b/middleware/body_limit_test.go index 8ffed55a4..d24d07d5d 100644 --- a/middleware/body_limit_test.go +++ b/middleware/body_limit_test.go @@ -70,6 +70,7 @@ func TestBodyLimitReader(t *testing.T) { reader: io.NopCloser(bytes.NewReader(hw)), context: e.NewContext(req, rec), } + defer reader.Close() // read all should return ErrStatusRequestEntityTooLarge _, err := io.ReadAll(reader) From 186325fd7c1c7b155dbfaf31fbe2bc67552d1cf5 Mon Sep 17 00:00:00 2001 From: OHZEKI Naoki <0h23k1.n40k1@gmail.com> Date: Wed, 23 Nov 2022 22:50:54 +0900 Subject: [PATCH 2/2] Proper test :) --- middleware/body_limit_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/middleware/body_limit_test.go b/middleware/body_limit_test.go index d24d07d5d..17c093e42 100644 --- a/middleware/body_limit_test.go +++ b/middleware/body_limit_test.go @@ -70,7 +70,7 @@ func TestBodyLimitReader(t *testing.T) { reader: io.NopCloser(bytes.NewReader(hw)), context: e.NewContext(req, rec), } - defer reader.Close() + defer assert.NoError(t, reader.Close()) // read all should return ErrStatusRequestEntityTooLarge _, err := io.ReadAll(reader)