Skip to content

Commit 1e9755c

Browse files
authored
[1.20.x] [NeoForge]: Remove NeoForge support (#66)
After thoroughly debugging reflections issues in NeoForge, the maintainer Orion confirmed that the uri scheme is incompatible with org.reflections. There are no way to have platform independent reflections utils if we have NeoForge in our project. Closes #37, closes #38
1 parent 311d021 commit 1e9755c

File tree

13 files changed

+2
-288
lines changed

13 files changed

+2
-288
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,8 @@ jobs:
5757
name: lambda-forge-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}-${{ env.COMMIT_HASH }}
5858
path: forge/build/libs/
5959

60-
- name: Upload Lambda NeoForge
61-
uses: actions/upload-artifact@v4.3.6
62-
with:
63-
name: lambda-neoforge-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}-${{ env.COMMIT_HASH }}
64-
path: neoforge/build/libs/
65-
6660
- name: Upload Lambda API
6761
uses: actions/upload-artifact@v4.3.6
6862
with:
6963
name: lambda-api-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}-${{ env.COMMIT_HASH }}
70-
path: common/build/libs/
64+
path: common/build/libs/

.github/workflows/labeler/labeler-config.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,6 @@ labels:
1010
- label: 'forge'
1111
title: '(?i)\[?(forge|all)[:\]]'
1212

13-
- label: 'neoforge'
14-
title: '(?i)\[?(neoforge|all)[:\]]'
15-
1613
- label: 'fabric'
1714
title: '(?i)\[?(fabric|all)[:\]]'
1815

.github/workflows/release.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,6 @@ jobs:
5757
name: lambda-forge-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}-${{ env.COMMIT_HASH }}
5858
path: forge/build/libs/
5959

60-
- name: Upload Lambda NeoForge
61-
uses: actions/upload-artifact@v4.3.6
62-
with:
63-
name: lambda-neoforge-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}-${{ env.COMMIT_HASH }}
64-
path: neoforge/build/libs/
65-
6660
- name: Upload Lambda API
6761
uses: actions/upload-artifact@v4.3.6
6862
with:
@@ -89,4 +83,3 @@ jobs:
8983
files: |
9084
fabric/build/libs/lambda-fabric-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}.jar
9185
forge/build/libs/lambda-forge-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}.jar
92-
neoforge/build/libs/lambda-neoforge-${{ steps.all.outputs.modVersion }}+${{ steps.all.outputs.minecraftVersion }}.jar

common/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ val kotlinVersion: String by project
44
val kotlinxCoroutinesVersion: String by project
55
val discordIPCVersion: String by project
66

7-
architectury { common("fabric", "forge", "neoforge") }
7+
architectury { common("fabric", "forge") }
88

99
loom {
1010
silentMojangMappingsLicense()

gradle.properties

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ kotlinForgeVersion=4.11.0
3030
kotlinForgeVersionMin=4.0.0
3131
kotlinForgeVersionMax=4.11.0
3232

33-
# NeoForge https://neoforged.net
34-
neoVersion=20.4.237
35-
neoVersionMin=20.2.3-beta
36-
neoVersionMax=20.999.0
37-
3833
# Kotlin https://kotlinlang.org/
3934
kotlin.code.style=official
4035

-1.72 MB
Binary file not shown.

neoforge/build.gradle.kts

Lines changed: 0 additions & 100 deletions
This file was deleted.

neoforge/gradle.properties

Lines changed: 0 additions & 1 deletion
This file was deleted.

neoforge/src/main/kotlin/com/lambda/neoforge/LambdaNeoForge.kt

Lines changed: 0 additions & 52 deletions
This file was deleted.

neoforge/src/main/kotlin/com/lambda/neoforge/LoaderInfoImpl.kt

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)