From 512666825d22a6a8945315ca175c2e11f091f90a Mon Sep 17 00:00:00 2001 From: YueZhang Date: Wed, 5 Nov 2025 17:20:33 +0800 Subject: [PATCH 1/2] fix: unnecessary object store initialization --- rust/lance/src/dataset/write/commit.rs | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/rust/lance/src/dataset/write/commit.rs b/rust/lance/src/dataset/write/commit.rs index 7e49cf5ee98..95f4b88c66b 100644 --- a/rust/lance/src/dataset/write/commit.rs +++ b/rust/lance/src/dataset/write/commit.rs @@ -194,13 +194,6 @@ impl<'a> CommitBuilder<'a> { dataset.commit_handler.clone(), ), WriteDestination::Uri(uri) => { - let (object_store, base_path) = ObjectStore::from_uri_and_params( - session.store_registry(), - uri, - &self.store_params.clone().unwrap_or_default(), - ) - .await?; - let mut object_store = object_store; let commit_handler = if self.commit_handler.is_some() && self.object_store.is_some() { self.commit_handler.as_ref().unwrap().clone() @@ -208,9 +201,16 @@ impl<'a> CommitBuilder<'a> { resolve_commit_handler(uri, self.commit_handler.clone(), &self.store_params) .await? }; + let (object_store, base_path) = if let Some(passed_store) = self.object_store { - object_store = passed_store; - } + (passed_store, ObjectStore::extract_path_from_uri(session.store_registry(), uri)?) + } else { + ObjectStore::from_uri_and_params( + session.store_registry(), + uri, + &self.store_params.clone().unwrap_or_default(), + ).await? + }; (object_store, base_path, commit_handler) } }; From 512480bc47835e2a212d1b68133bd8946d4cb0ac Mon Sep 17 00:00:00 2001 From: YueZhang Date: Wed, 5 Nov 2025 17:23:27 +0800 Subject: [PATCH 2/2] fix: unnecessary object store initialization --- rust/lance/src/dataset/write/commit.rs | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/rust/lance/src/dataset/write/commit.rs b/rust/lance/src/dataset/write/commit.rs index 95f4b88c66b..ba7bf04a5df 100644 --- a/rust/lance/src/dataset/write/commit.rs +++ b/rust/lance/src/dataset/write/commit.rs @@ -201,15 +201,18 @@ impl<'a> CommitBuilder<'a> { resolve_commit_handler(uri, self.commit_handler.clone(), &self.store_params) .await? }; - let (object_store, base_path) = - if let Some(passed_store) = self.object_store { - (passed_store, ObjectStore::extract_path_from_uri(session.store_registry(), uri)?) + let (object_store, base_path) = if let Some(passed_store) = self.object_store { + ( + passed_store, + ObjectStore::extract_path_from_uri(session.store_registry(), uri)?, + ) } else { ObjectStore::from_uri_and_params( session.store_registry(), uri, &self.store_params.clone().unwrap_or_default(), - ).await? + ) + .await? }; (object_store, base_path, commit_handler) }