From 807112160b08e4066492780d7b1b4808219ab439 Mon Sep 17 00:00:00 2001 From: forwardxu Date: Fri, 19 Dec 2025 13:28:08 +0800 Subject: [PATCH 1/2] test: add coverage for large string variant in PrefixPlusCounterGenerator The existing test only covered the is_large=false case. This commit adds test coverage for the is_large=true branch that generates LargeStringArray, bringing the test coverage to 100% for this generator. Fixes the codecov report showing missing coverage on line 1080 in rust/lance-datagen/src/generator.rs. --- rust/lance-datagen/src/generator.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rust/lance-datagen/src/generator.rs b/rust/lance-datagen/src/generator.rs index 26b79c0b08d..877d41859d7 100644 --- a/rust/lance-datagen/src/generator.rs +++ b/rust/lance-datagen/src/generator.rs @@ -3032,6 +3032,12 @@ mod tests { *genn.generate(RowCount::from(3), &mut rng).unwrap(), arrow_array::StringArray::from_iter_values(["user_0", "user_1", "user_2"]) ); + + let mut genn = array::utf8_prefix_plus_counter("user_", true); + assert_eq!( + *genn.generate(RowCount::from(3), &mut rng).unwrap(), + arrow_array::LargeStringArray::from_iter_values(["user_0", "user_1", "user_2"]) + ); } #[test] From 05b92766cebb97b86b1c92911a72c322b556380f Mon Sep 17 00:00:00 2001 From: Will Jones Date: Fri, 19 Dec 2025 12:28:45 -0800 Subject: [PATCH 2/2] format --- rust/lance-datagen/src/generator.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/lance-datagen/src/generator.rs b/rust/lance-datagen/src/generator.rs index 877d41859d7..e3f53cf842d 100644 --- a/rust/lance-datagen/src/generator.rs +++ b/rust/lance-datagen/src/generator.rs @@ -3032,7 +3032,7 @@ mod tests { *genn.generate(RowCount::from(3), &mut rng).unwrap(), arrow_array::StringArray::from_iter_values(["user_0", "user_1", "user_2"]) ); - + let mut genn = array::utf8_prefix_plus_counter("user_", true); assert_eq!( *genn.generate(RowCount::from(3), &mut rng).unwrap(),