From d389dcb7ee6e1c465e4babed315b14d6d053daac Mon Sep 17 00:00:00 2001 From: Xuanwo Date: Thu, 26 Mar 2026 18:44:56 +0800 Subject: [PATCH 1/3] fix: restore namespace build after DatasetIndexExt move --- rust/lance-namespace-impls/src/dir.rs | 27 +++++++++++++-------------- 1 file changed, 13 insertions(+), 14 deletions(-) diff --git a/rust/lance-namespace-impls/src/dir.rs b/rust/lance-namespace-impls/src/dir.rs index 7718fc95a01..1e918f018f6 100644 --- a/rust/lance-namespace-impls/src/dir.rs +++ b/rust/lance-namespace-impls/src/dir.rs @@ -16,14 +16,14 @@ use futures::TryStreamExt; use lance::dataset::builder::DatasetBuilder; use lance::dataset::transaction::{Operation, Transaction}; use lance::dataset::{Dataset, WriteMode, WriteParams}; -use lance::index::{IndexParams, vector::VectorIndexParams}; +use lance::index::{DatasetIndexExt, IndexParams, vector::VectorIndexParams}; use lance::session::Session; use lance_index::scalar::{BuiltinIndexType, InvertedIndexParams, ScalarIndexParams}; use lance_index::vector::{ bq::RQBuildParams, hnsw::builder::HnswBuildParams, ivf::IvfBuildParams, pq::PQBuildParams, sq::builder::SQBuildParams, }; -use lance_index::{DatasetIndexExt, IndexType, is_system_index}; +use lance_index::{IndexType, is_system_index}; use lance_io::object_store::{ObjectStore, ObjectStoreParams, ObjectStoreRegistry}; use lance_linalg::distance::MetricType; use lance_table::io::commit::ManifestNamingScheme; @@ -2554,18 +2554,17 @@ impl LanceNamespace for DirectoryNamespace { )); } - let stats = - ::index_statistics(&dataset, index_name) - .await - .map_err(|e| { - Error::namespace_source( - format!( - "Failed to describe index statistics for '{}' on table '{}': {}", - index_name, table_uri, e - ) - .into(), + let stats = ::index_statistics(&dataset, index_name) + .await + .map_err(|e| { + Error::namespace_source( + format!( + "Failed to describe index statistics for '{}' on table '{}': {}", + index_name, table_uri, e ) - })?; + .into(), + ) + })?; let stats: serde_json::Value = serde_json::from_str(&stats).map_err(|e| { Error::namespace_source( format!( @@ -2701,7 +2700,7 @@ mod tests { use arrow_ipc::reader::StreamReader; use lance::dataset::Dataset; use lance_core::utils::tempfile::{TempStdDir, TempStrDir}; - use lance_index::DatasetIndexExt; + use lance::index::DatasetIndexExt; use lance_namespace::models::{ CreateTableRequest, JsonArrowDataType, JsonArrowField, JsonArrowSchema, ListTablesRequest, }; From 33cfe48f07f87ecacf159f751c7e5442932231b8 Mon Sep 17 00:00:00 2001 From: Xuanwo Date: Thu, 26 Mar 2026 18:49:16 +0800 Subject: [PATCH 2/3] style: fix namespace import order --- rust/lance-namespace-impls/src/dir.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/lance-namespace-impls/src/dir.rs b/rust/lance-namespace-impls/src/dir.rs index 1e918f018f6..ba01c88eab2 100644 --- a/rust/lance-namespace-impls/src/dir.rs +++ b/rust/lance-namespace-impls/src/dir.rs @@ -2699,8 +2699,8 @@ mod tests { use super::*; use arrow_ipc::reader::StreamReader; use lance::dataset::Dataset; - use lance_core::utils::tempfile::{TempStdDir, TempStrDir}; use lance::index::DatasetIndexExt; + use lance_core::utils::tempfile::{TempStdDir, TempStrDir}; use lance_namespace::models::{ CreateTableRequest, JsonArrowDataType, JsonArrowField, JsonArrowSchema, ListTablesRequest, }; From 38a05a7b7b4e5b45e983260631ba4ea474db873b Mon Sep 17 00:00:00 2001 From: Xuanwo Date: Thu, 26 Mar 2026 19:01:48 +0800 Subject: [PATCH 3/3] fix: update bench import for moved dataset index api --- rust/lance/benches/distributed_vector_build.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/lance/benches/distributed_vector_build.rs b/rust/lance/benches/distributed_vector_build.rs index 831ee8c8299..5a9b2d70602 100644 --- a/rust/lance/benches/distributed_vector_build.rs +++ b/rust/lance/benches/distributed_vector_build.rs @@ -15,11 +15,11 @@ use serde::Serialize; use uuid::Uuid; use lance::dataset::{Dataset, WriteMode, WriteParams}; -use lance::index::vector::VectorIndexParams; +use lance::index::{DatasetIndexExt, vector::VectorIndexParams}; use lance_arrow::FixedSizeListArrayExt; use lance_index::vector::kmeans::{KMeansParams, train_kmeans}; use lance_index::{ - DatasetIndexExt, IndexType, + IndexType, vector::{ivf::IvfBuildParams, pq::PQBuildParams}, }; use lance_linalg::distance::DistanceType;