From 60a4c685521e1d7ccc02d81943e548f6a896df86 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira Date: Fri, 30 May 2025 11:54:20 -0300 Subject: [PATCH 1/3] Set names and descriptions as empty to get from flow name when empty instead of assigning the immediate name --- .../toolsModal/components/toolsTable/index.tsx | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx b/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx index 449b3f0fb4f9..064a2fe84eac 100644 --- a/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx +++ b/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx @@ -81,17 +81,16 @@ export default function ToolsTable({ handleOnNewValue({ value: data.map((row) => { const processedValue = ( - row.name !== "" + row.name !== "" && row.name !== row.display_name ? parseString(row.name, ["snake_case", "no_blank", "lowercase"]) - : parseString(row.display_name, [ - "snake_case", - "no_blank", - "lowercase", - ]) + : "" ).slice(0, 46); const processedDescription = - row.description !== "" ? row.description : row.display_description; + row.description !== "" && + row.description !== row.display_description + ? row.description + : ""; return selectedRows?.some( (selected) => From a0517d88add1810ec24a69542ac39253b883450a Mon Sep 17 00:00:00 2001 From: Lucas Oliveira Date: Fri, 30 May 2025 12:00:21 -0300 Subject: [PATCH 2/3] Changed to compare already parsed values --- .../components/toolsTable/index.tsx | 22 +++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx b/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx index 064a2fe84eac..fb4d7b7b04d8 100644 --- a/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx +++ b/src/frontend/src/modals/toolsModal/components/toolsTable/index.tsx @@ -80,17 +80,31 @@ export default function ToolsTable({ if (!open && selectedRows) { handleOnNewValue({ value: data.map((row) => { + const name = parseString(row.name, [ + "snake_case", + "no_blank", + "lowercase", + ]); + const display_name = parseString(row.display_name, [ + "snake_case", + "no_blank", + "lowercase", + ]); const processedValue = ( - row.name !== "" && row.name !== row.display_name - ? parseString(row.name, ["snake_case", "no_blank", "lowercase"]) - : "" + name !== "" && name !== display_name + ? name + : isAction + ? "" + : display_name ).slice(0, 46); const processedDescription = row.description !== "" && row.description !== row.display_description ? row.description - : ""; + : isAction + ? "" + : row.display_description; return selectedRows?.some( (selected) => From c45f2476399d0bc67db41539a352613ab36087b7 Mon Sep 17 00:00:00 2001 From: Lucas Oliveira Date: Fri, 30 May 2025 12:01:42 -0300 Subject: [PATCH 3/3] changed parseString to return empty when the string is empty or have only spaces --- src/frontend/src/utils/stringManipulation.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/frontend/src/utils/stringManipulation.ts b/src/frontend/src/utils/stringManipulation.ts index 0dde0aed16a3..49be06ddcea1 100644 --- a/src/frontend/src/utils/stringManipulation.ts +++ b/src/frontend/src/utils/stringManipulation.ts @@ -78,6 +78,14 @@ export function parseString( ): string { let result = str; + if (result === "") { + return ""; + } + + if (parsers.includes("no_blank") && result.trim() === "") { + return ""; + } + let parsersArray: FieldParserType[] = []; if (typeof parsers === "string") {