From d662f066a766bfb24b84446acde353ab8c601642 Mon Sep 17 00:00:00 2001
From: Ivan Dmitriev <42055372+IvanDmitriev1@users.noreply.github.com>
Date: Fri, 7 Apr 2023 12:18:03 +0600
Subject: [PATCH 1/5] Small improvements to the ContentDialog

---
 .../Controls/TermsOfUseContentDialog.xaml.cs  |  4 +-
 .../ContentDialogControl/ContentDialog.cs     | 46 +++++++++++--------
 2 files changed, 29 insertions(+), 21 deletions(-)

diff --git a/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs b/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs
index 8f7afc9b8..c44eedd06 100644
--- a/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs
+++ b/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs
@@ -15,11 +15,11 @@ public TermsOfUseContentDialog(ContentPresenter contentPresenter) : base(content
     protected override bool OnButtonClick(ContentDialogButton button)
     {
         if (CheckBox.IsChecked != false)
-            return true;
+            return false;
 
         TextBlock.Visibility = Visibility.Visible;
         CheckBox.Focus();
 
-        return false;
+        return true;
     }
 }
diff --git a/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs b/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
index 793ecdf41..ae84d4ec1 100644
--- a/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
+++ b/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
@@ -363,6 +363,12 @@ public ContentDialog(ContentPresenter contentPresenter)
 
         SetValue(TemplateButtonCommandProperty,
             new RelayCommand<ContentDialogButton>(OnTemplateButtonClick));
+
+        Loaded += static (sender, _) =>
+        {
+            var self = (ContentDialog)sender;
+            self.OnLoaded();
+        };
     }
 
     protected readonly ContentPresenter ContentPresenter;
@@ -377,7 +383,7 @@ public ContentDialog(ContentPresenter contentPresenter)
     public async Task<ContentDialogResult> ShowAsync(CancellationToken cancellationToken = default)
     {
         Tcs = new TaskCompletionSource<ContentDialogResult>();
-        var tokenRegistration = cancellationToken.Register(o => Tcs.TrySetCanceled((CancellationToken)o!), cancellationToken);
+        CancellationTokenRegistration tokenRegistration = cancellationToken.Register(o => Tcs.TrySetCanceled((CancellationToken)o!), cancellationToken);
 
         try
         {
@@ -391,31 +397,34 @@ public async Task<ContentDialogResult> ShowAsync(CancellationToken cancellationT
 #else
             tokenRegistration.Dispose();
 #endif
+            ContentPresenter.Content = null;
+            OnClosing();
         }
     }
 
     /// <summary>
-    /// Hides the dialog
+    /// Hides the dialog with result
     /// </summary>
-    public virtual void Hide()
+    public virtual void Hide(ContentDialogResult result = ContentDialogResult.None)
     {
-        ContentPresenter.Content = null;
+        Tcs?.TrySetResult(result);
     }
 
-    protected override void OnInitialized(EventArgs e)
+    protected virtual void OnLoaded()
     {
-        base.OnInitialized(e);
+        if (VisualChildrenCount <= 0 || GetVisualChild(0) is not UIElement frameworkElement)
+            return;
 
-        Loaded += static (sender, _) =>
-        {
-            var self = (ContentDialog)sender;
+        ResizeToContentSize(frameworkElement);
+        Focus();
+    }
 
-            if (self.VisualChildrenCount <= 0 || self.GetVisualChild(0) is not UIElement frameworkElement)
-                return;
+    /// <summary>
+    /// Occurs after ContentPresenter.Content = null
+    /// </summary>
+    protected virtual void OnClosing()
+    {
 
-            self.ResizeToContentSize(frameworkElement);
-            self.Focus();
-        };
     }
 
     /// <summary>
@@ -460,13 +469,13 @@ protected virtual void ResizeToContentSize(UIElement content)
     /// </summary>
     /// <param name="button"></param>
     /// <returns>
-    /// 
+    /// Returns an indication of whether it has been handled or not
     /// </returns>
-    protected virtual bool OnButtonClick(ContentDialogButton button) { return true; }
+    protected virtual bool OnButtonClick(ContentDialogButton button) { return false; }
 
     private void OnTemplateButtonClick(ContentDialogButton button)
     {
-        if (!OnButtonClick(button))
+        if (OnButtonClick(button))
             return;
 
         ContentDialogResult result = button switch
@@ -476,7 +485,6 @@ private void OnTemplateButtonClick(ContentDialogButton button)
             _ => ContentDialogResult.None
         };
 
-        Hide();
-        Tcs?.TrySetResult(result);
+        Hide(result);
     }
 }

From ce7c071124f409931bb6ef4ec8770b8de9063e09 Mon Sep 17 00:00:00 2001
From: Ivan Dmitriev <42055372+IvanDmitriev1@users.noreply.github.com>
Date: Fri, 7 Apr 2023 12:21:19 +0600
Subject: [PATCH 2/5] Added support for ContentTemplateSelector in the
 ContentDialog

---
 src/Wpf.Ui/Styles/Controls/ContentDialog.xaml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Wpf.Ui/Styles/Controls/ContentDialog.xaml b/src/Wpf.Ui/Styles/Controls/ContentDialog.xaml
index 0cceaf774..db0d70a6b 100644
--- a/src/Wpf.Ui/Styles/Controls/ContentDialog.xaml
+++ b/src/Wpf.Ui/Styles/Controls/ContentDialog.xaml
@@ -92,7 +92,8 @@
                                             HorizontalAlignment="{TemplateBinding HorizontalContentAlignment}"
                                             VerticalAlignment="{TemplateBinding VerticalContentAlignment}"
                                             Content="{TemplateBinding Content}"
-                                            ContentTemplate="{TemplateBinding ContentTemplate}">
+                                            ContentTemplate="{TemplateBinding ContentTemplate}"
+                                            ContentTemplateSelector="{TemplateBinding ContentTemplateSelector}">
 
                                             <ContentPresenter.Resources>
                                                 <Style BasedOn="{StaticResource {x:Type TextBlock}}" TargetType="{x:Type TextBlock}">

From 7f7b63aaeaf8a6a11f41b6d1d5afe66f773515ed Mon Sep 17 00:00:00 2001
From: Ivan Dmitriev <42055372+IvanDmitriev1@users.noreply.github.com>
Date: Fri, 7 Apr 2023 12:26:55 +0600
Subject: [PATCH 3/5] Updated MessageBox just like ContentDialog

---
 .../ContentDialogControl/ContentDialog.cs     |  3 ++
 .../Controls/MessageBoxControl/MessageBox.cs  | 50 ++++++++++---------
 2 files changed, 29 insertions(+), 24 deletions(-)

diff --git a/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs b/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
index ae84d4ec1..80b91bf55 100644
--- a/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
+++ b/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
@@ -410,6 +410,9 @@ public virtual void Hide(ContentDialogResult result = ContentDialogResult.None)
         Tcs?.TrySetResult(result);
     }
 
+    /// <summary>
+    /// Occurs after Loading event
+    /// </summary>
     protected virtual void OnLoaded()
     {
         if (VisualChildrenCount <= 0 || GetVisualChild(0) is not UIElement frameworkElement)
diff --git a/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs b/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs
index ce0d0b585..f546191e8 100644
--- a/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs
+++ b/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs
@@ -246,6 +246,14 @@ public MessageBox()
     {
         Topmost = true;
         SetValue(TemplateButtonCommandProperty, new RelayCommand<MessageBoxButton>(OnTemplateButtonClick));
+
+        PreviewMouseDoubleClick += static (_, args) => args.Handled = true;
+
+        Loaded += static (sender, _) =>
+        {
+            var self = (MessageBox)sender;
+            self.OnLoaded();
+        };
     }
 
     protected TaskCompletionSource<MessageBoxResult>? Tcs;
@@ -271,7 +279,7 @@ public MessageBox()
     public async Task<MessageBoxResult> ShowDialogAsync(CancellationToken cancellationToken = default)
     {
         Tcs = new TaskCompletionSource<MessageBoxResult>();
-        var tokenRegistration = cancellationToken.Register(o => Tcs.TrySetCanceled((CancellationToken)o!), cancellationToken);
+        CancellationTokenRegistration tokenRegistration = cancellationToken.Register(o => Tcs.TrySetCanceled((CancellationToken)o!), cancellationToken);
 
         try
         {
@@ -291,22 +299,16 @@ public async Task<MessageBoxResult> ShowDialogAsync(CancellationToken cancellati
         }
     }
 
-    protected override void OnInitialized(EventArgs e)
+    /// <summary>
+    /// Occurs after Loading event
+    /// </summary>
+    protected virtual void OnLoaded()
     {
-        base.OnInitialized(e);
-
-        PreviewMouseDoubleClick += static (_, args) => args.Handled = true;
-
-        Loaded += static (sender, _) =>
-        {
-            var self = (MessageBox)sender;
-
-            if (self.VisualChildrenCount <= 0 || self.GetVisualChild(0) is not UIElement content)
-                return;
+        if (VisualChildrenCount <= 0 || GetVisualChild(0) is not UIElement content)
+            return;
 
-            self.ResizeToContentSize(content);
-            self.CenterWindowOnScreen();
-        };
+        ResizeToContentSize(content);
+        CenterWindowOnScreen();
     }
 
     protected override void OnClosing(CancelEventArgs e)
@@ -370,19 +372,13 @@ protected virtual void CenterWindowOnScreen()
     /// </summary>
     /// <param name="button"></param>
     /// <returns>
-    /// 
+    /// Returns an indication of whether it has been handled or not
     /// </returns>
-    protected virtual bool OnButtonClick(MessageBoxButton button) { return true; }
-
-    private void RemoveTitleBarAndApplyMica()
-    {
-        UnsafeNativeMethods.RemoveWindowTitlebarContents(this);
-        WindowBackdrop.ApplyBackdrop(this, WindowBackdropType.Mica);
-    }
+    protected virtual bool OnButtonClick(MessageBoxButton button) { return false; }
 
     private void OnTemplateButtonClick(MessageBoxButton button)
     {
-        if (!OnButtonClick(button))
+        if (OnButtonClick(button))
             return;
 
         MessageBoxResult result = button switch
@@ -395,4 +391,10 @@ private void OnTemplateButtonClick(MessageBoxButton button)
         Tcs?.TrySetResult(result);
         Close();
     }
+
+    private void RemoveTitleBarAndApplyMica()
+    {
+        UnsafeNativeMethods.RemoveWindowTitlebarContents(this);
+        WindowBackdrop.ApplyBackdrop(this, WindowBackdropType.Mica);
+    }
 }

From 0af438f33c67a99dd5dbe4449027579404daf0d9 Mon Sep 17 00:00:00 2001
From: Ivan Dmitriev <42055372+IvanDmitriev1@users.noreply.github.com>
Date: Mon, 10 Apr 2023 14:03:25 +0600
Subject: [PATCH 4/5] Removed OnTemplateButtonClick method

---
 .../Controls/TermsOfUseContentDialog.xaml.cs   | 10 +++++-----
 .../ContentDialogControl/ContentDialog.cs      | 18 +++++-------------
 .../Controls/IconElements/IconSourceElement.cs |  1 +
 3 files changed, 11 insertions(+), 18 deletions(-)

diff --git a/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs b/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs
index c44eedd06..8e595e94d 100644
--- a/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs
+++ b/src/Wpf.Ui.Gallery/Controls/TermsOfUseContentDialog.xaml.cs
@@ -1,6 +1,5 @@
 using System.Windows;
 using System.Windows.Controls;
-using Wpf.Ui.Controls;
 using Wpf.Ui.Controls.ContentDialogControl;
 
 namespace Wpf.Ui.Gallery.Controls;
@@ -12,14 +11,15 @@ public TermsOfUseContentDialog(ContentPresenter contentPresenter) : base(content
         InitializeComponent();
     }
 
-    protected override bool OnButtonClick(ContentDialogButton button)
+    protected override void OnButtonClick(ContentDialogButton button)
     {
         if (CheckBox.IsChecked != false)
-            return false;
+        {
+            base.OnButtonClick(button);
+            return;
+        };
 
         TextBlock.Visibility = Visibility.Visible;
         CheckBox.Focus();
-
-        return true;
     }
 }
diff --git a/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs b/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
index 80b91bf55..8f2974ea9 100644
--- a/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
+++ b/src/Wpf.Ui/Controls/ContentDialogControl/ContentDialog.cs
@@ -362,7 +362,7 @@ public ContentDialog(ContentPresenter contentPresenter)
         ContentPresenter = contentPresenter;
 
         SetValue(TemplateButtonCommandProperty,
-            new RelayCommand<ContentDialogButton>(OnTemplateButtonClick));
+            new RelayCommand<ContentDialogButton>(OnButtonClick));
 
         Loaded += static (sender, _) =>
         {
@@ -398,7 +398,7 @@ public async Task<ContentDialogResult> ShowAsync(CancellationToken cancellationT
             tokenRegistration.Dispose();
 #endif
             ContentPresenter.Content = null;
-            OnClosing();
+            OnClosed();
         }
     }
 
@@ -425,7 +425,7 @@ protected virtual void OnLoaded()
     /// <summary>
     /// Occurs after ContentPresenter.Content = null
     /// </summary>
-    protected virtual void OnClosing()
+    protected virtual void OnClosed()
     {
 
     }
@@ -471,16 +471,8 @@ protected virtual void ResizeToContentSize(UIElement content)
     /// Occurs after the <see cref="ContentDialogButton"/> is clicked 
     /// </summary>
     /// <param name="button"></param>
-    /// <returns>
-    /// Returns an indication of whether it has been handled or not
-    /// </returns>
-    protected virtual bool OnButtonClick(ContentDialogButton button) { return false; }
-
-    private void OnTemplateButtonClick(ContentDialogButton button)
+    protected virtual void OnButtonClick(ContentDialogButton button)
     {
-        if (OnButtonClick(button))
-            return;
-
         ContentDialogResult result = button switch
         {
             ContentDialogButton.Primary => ContentDialogResult.Primary,
@@ -488,6 +480,6 @@ private void OnTemplateButtonClick(ContentDialogButton button)
             _ => ContentDialogResult.None
         };
 
-        Hide(result);
+        Hide(result);   
     }
 }
diff --git a/src/Wpf.Ui/Controls/IconElements/IconSourceElement.cs b/src/Wpf.Ui/Controls/IconElements/IconSourceElement.cs
index 2dd671367..f051e24b5 100644
--- a/src/Wpf.Ui/Controls/IconElements/IconSourceElement.cs
+++ b/src/Wpf.Ui/Controls/IconElements/IconSourceElement.cs
@@ -38,6 +38,7 @@ public IconSource? IconSource
 
     protected override UIElement InitializeChildren()
     {
+        //TODO come up with an elegant solution
         throw new InvalidOperationException($"Use {nameof(IconSourceElementConverter)} class.");
     }
 }

From 423c2bd2652c980920d28132a0441758a3cd385d Mon Sep 17 00:00:00 2001
From: Ivan Dmitriev <42055372+IvanDmitriev1@users.noreply.github.com>
Date: Mon, 10 Apr 2023 14:23:01 +0600
Subject: [PATCH 5/5] Update MessageBox.cs

---
 .../Controls/MessageBoxControl/MessageBox.cs  | 36 +++++++++----------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs b/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs
index f546191e8..f2b03d274 100644
--- a/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs
+++ b/src/Wpf.Ui/Controls/MessageBoxControl/MessageBox.cs
@@ -245,7 +245,7 @@ public bool IsPrimaryButtonEnabled
     public MessageBox()
     {
         Topmost = true;
-        SetValue(TemplateButtonCommandProperty, new RelayCommand<MessageBoxButton>(OnTemplateButtonClick));
+        SetValue(TemplateButtonCommandProperty, new RelayCommand<MessageBoxButton>(OnButtonClick));
 
         PreviewMouseDoubleClick += static (_, args) => args.Handled = true;
 
@@ -267,8 +267,13 @@ public MessageBox()
     [Obsolete($"Use {nameof(ShowDialogAsync)} instead")]
     public new bool? ShowDialog()
     {
-        RemoveTitleBarAndApplyMica();
-        return base.ShowDialog();
+        throw new InvalidOperationException($"Use {nameof(ShowDialogAsync)} instead");
+    }
+
+    [Obsolete($"Use {nameof(Close)} with MessageBoxResult instead")]
+    public new void Close()
+    {
+        throw new InvalidOperationException($"Use {nameof(Close)} with MessageBoxResult instead");
     }
 
     /// <summary>
@@ -276,18 +281,21 @@ public MessageBox()
     /// </summary>
     /// <returns><see cref="MessageBoxResult"/></returns>
     /// <exception cref="TaskCanceledException"></exception>
-    public async Task<MessageBoxResult> ShowDialogAsync(CancellationToken cancellationToken = default)
+    public async Task<MessageBoxResult> ShowDialogAsync(bool showAsDialog = true, CancellationToken cancellationToken = default)
     {
         Tcs = new TaskCompletionSource<MessageBoxResult>();
         CancellationTokenRegistration tokenRegistration = cancellationToken.Register(o => Tcs.TrySetCanceled((CancellationToken)o!), cancellationToken);
 
         try
         {
-#pragma warning disable CS0618
-            ShowDialog();
-#pragma warning restore CS0618
+            RemoveTitleBarAndApplyMica();
 
-            return await Tcs!.Task;
+            if (showAsDialog)
+                base.ShowDialog();
+            else
+                base.Show();
+
+            return await Tcs.Task;
         }
         finally
         {
@@ -371,16 +379,8 @@ protected virtual void CenterWindowOnScreen()
     /// Occurs after the <see cref="MessageBoxButton"/> is clicked 
     /// </summary>
     /// <param name="button"></param>
-    /// <returns>
-    /// Returns an indication of whether it has been handled or not
-    /// </returns>
-    protected virtual bool OnButtonClick(MessageBoxButton button) { return false; }
-
-    private void OnTemplateButtonClick(MessageBoxButton button)
+    protected virtual void OnButtonClick(MessageBoxButton button)
     {
-        if (OnButtonClick(button))
-            return;
-
         MessageBoxResult result = button switch
         {
             MessageBoxButton.Primary => MessageBoxResult.Primary,
@@ -389,7 +389,7 @@ private void OnTemplateButtonClick(MessageBoxButton button)
         };
 
         Tcs?.TrySetResult(result);
-        Close();
+        base.Close();
     }
 
     private void RemoveTitleBarAndApplyMica()