From d9fdcfdd04fa2d102b398fd52524461e829be033 Mon Sep 17 00:00:00 2001 From: Leynos Date: Sat, 5 Jul 2025 12:55:48 +0100 Subject: [PATCH 1/4] Add Codecov upload step --- .github/workflows/ci.yml | 4 ++++ docs/multi-layered-testing-strategy.md | 3 +++ 2 files changed, 7 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 22f246ff..48501f43 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,4 +57,8 @@ jobs: - name: Upload coverage data to CodeScene if: env.CS_ACCESS_TOKEN run: cs-coverage upload --format "lcov" --metric "line-coverage" "lcov.info" + - name: Upload coverage data to Codecov + uses: codecov/codecov-action@v3 + with: + files: lcov.info diff --git a/docs/multi-layered-testing-strategy.md b/docs/multi-layered-testing-strategy.md index a02e7d08..3080ba1f 100644 --- a/docs/multi-layered-testing-strategy.md +++ b/docs/multi-layered-testing-strategy.md @@ -15,6 +15,9 @@ reviewers. This approach ensures that we establish a baseline of correctness with simple tests before moving on to the more complex and subtle failure modes that can emerge in an asynchronous, high-concurrency system. +Code coverage is measured with `cargo tarpaulin`. The CI workflow uploads the +generated `lcov.info` report to Codecov for visibility across pull requests. + ## 2. Layer 1: Foundational Correctness (Unit & Integration) **Objective:** To verify that each component behaves correctly in isolation and From 70eb762ea2a69536de8a943ee85a5c4c9235956a Mon Sep 17 00:00:00 2001 From: Leynos Date: Sat, 5 Jul 2025 13:31:39 +0100 Subject: [PATCH 2/4] Add Codecov upload --- .github/workflows/ci.yml | 3 ++- docs/multi-layered-testing-strategy.md | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 48501f43..206e298f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -58,7 +58,8 @@ jobs: if: env.CS_ACCESS_TOKEN run: cs-coverage upload --format "lcov" --metric "line-coverage" "lcov.info" - name: Upload coverage data to Codecov - uses: codecov/codecov-action@v3 + # v5.4.3 + uses: codecov/codecov-action@18283e04ce6e62d37312384ff67231eb8fd56d24 with: files: lcov.info diff --git a/docs/multi-layered-testing-strategy.md b/docs/multi-layered-testing-strategy.md index 3080ba1f..4b590e25 100644 --- a/docs/multi-layered-testing-strategy.md +++ b/docs/multi-layered-testing-strategy.md @@ -16,7 +16,9 @@ with simple tests before moving on to the more complex and subtle failure modes that can emerge in an asynchronous, high-concurrency system. Code coverage is measured with `cargo tarpaulin`. The CI workflow uploads the -generated `lcov.info` report to Codecov for visibility across pull requests. +generated `lcov.info` report to Codecov using a pinned version of the Codecov +GitHub Action (`18283e04ce6e62d37312384ff67231eb8fd56d24`, corresponding to +v5.4.3) for visibility across pull requests. ## 2. Layer 1: Foundational Correctness (Unit & Integration) @@ -474,9 +476,9 @@ workload. 1. **Throughput:** The number of messages per second in a simple request-response workload. -2. **Latency:** The round-trip time for a single message. +1. **Latency:** The round-trip time for a single message. -3. **Push Latency:** The time from `push_handle.push()` to the client receiving +1. **Push Latency:** The time from `push_handle.push()` to the client receiving the frame. **Measurable Objective:** For small frames on [localhost](http://localhost): From 2880ec134a6fc66293579851897e30c9f53e24a8 Mon Sep 17 00:00:00 2001 From: Leynos Date: Sat, 5 Jul 2025 13:57:33 +0100 Subject: [PATCH 3/4] Update coverage documentation --- docs/multi-layered-testing-strategy.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/multi-layered-testing-strategy.md b/docs/multi-layered-testing-strategy.md index 4b590e25..6e34fa2b 100644 --- a/docs/multi-layered-testing-strategy.md +++ b/docs/multi-layered-testing-strategy.md @@ -15,10 +15,10 @@ reviewers. This approach ensures that we establish a baseline of correctness with simple tests before moving on to the more complex and subtle failure modes that can emerge in an asynchronous, high-concurrency system. -Code coverage is measured with `cargo tarpaulin`. The CI workflow uploads the +Code coverage is measured with `cargo tarpaulin`. The CI workflow uploads the generated `lcov.info` report to Codecov using a pinned version of the Codecov GitHub Action (`18283e04ce6e62d37312384ff67231eb8fd56d24`, corresponding to -v5.4.3) for visibility across pull requests. +v5.4.3) to make coverage visible across pull requests. ## 2. Layer 1: Foundational Correctness (Unit & Integration) From 6f201fced97e25b889b54622e0de8483b28ee72d Mon Sep 17 00:00:00 2001 From: Leynos Date: Sat, 5 Jul 2025 13:58:59 +0100 Subject: [PATCH 4/4] Fix list numbering --- docs/multi-layered-testing-strategy.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/multi-layered-testing-strategy.md b/docs/multi-layered-testing-strategy.md index 6e34fa2b..d4f0c0a4 100644 --- a/docs/multi-layered-testing-strategy.md +++ b/docs/multi-layered-testing-strategy.md @@ -476,9 +476,9 @@ workload. 1. **Throughput:** The number of messages per second in a simple request-response workload. -1. **Latency:** The round-trip time for a single message. +2. **Latency:** The round-trip time for a single message. -1. **Push Latency:** The time from `push_handle.push()` to the client receiving +3. **Push latency:** The time from `push_handle.push()` to the client receiving the frame. **Measurable Objective:** For small frames on [localhost](http://localhost):