From d668a4d9104874b607bab7a4d568308797168c5f Mon Sep 17 00:00:00 2001 From: Phillip Mienk Date: Mon, 23 Mar 2026 13:10:25 -0700 Subject: [PATCH 1/3] Remove duplication of parameterization (with secp256k1 move to cmake, no consumer). --- templates/gsl.ci.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/templates/gsl.ci.yml b/templates/gsl.ci.yml index b6848f02..e28ed58e 100644 --- a/templates/gsl.ci.yml +++ b/templates/gsl.ci.yml @@ -725,15 +725,9 @@ endfunction # get_sln_tests . endif . # assert (ndebug) if [[ ${{ matrix.assert }} == 'ndebug' ]]; then -. if defined(my.config.cmake) - echo "ASSERT_NDEBUG=--enable-ndebug -Denable-ndebug=yes" >> $GITHUB_ENV - else - echo "ASSERT_NDEBUG=--disable-ndebug -Denable-ndebug=no" >> $GITHUB_ENV -. else echo "ASSERT_NDEBUG=--enable-ndebug" >> $GITHUB_ENV else echo "ASSERT_NDEBUG=--disable-ndebug" >> $GITHUB_ENV -. endif fi . # link if [[ ${{ matrix.link }} == 'dynamic' ]]; then From 50476abeed65aba760fa9c8fe81ee3d55aa3fc71 Mon Sep 17 00:00:00 2001 From: Phillip Mienk Date: Tue, 24 Mar 2026 22:01:14 -0700 Subject: [PATCH 2/3] Update to remove deprecation notice. --- templates/gsl.ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/templates/gsl.ci.yml b/templates/gsl.ci.yml index e28ed58e..04aa1d3a 100644 --- a/templates/gsl.ci.yml +++ b/templates/gsl.ci.yml @@ -930,7 +930,7 @@ endfunction # get_sln_tests steps: - name: Add msbuild to PATH - uses: microsoft/setup-msbuild@v2 + uses: microsoft/setup-msbuild@v3 with: msbuild-architecture: x64 From 03e3471bdfdf85d935dbcefe88a7109f887fc910 Mon Sep 17 00:00:00 2001 From: Phillip Mienk Date: Tue, 24 Mar 2026 23:58:23 -0700 Subject: [PATCH 3/3] Update to setup-msbuild@v3. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 789c4382..33d95367 100755 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -138,7 +138,7 @@ jobs: - name: Prepare toolchain [windows] if: ${{ startsWith(matrix.os, 'windows') }} - uses: microsoft/setup-msbuild@v1.1 + uses: microsoft/setup-msbuild@v3 - name: Build gsl [macos] if: ${{ startsWith(matrix.os, 'macos') }}