From f43fa16e7b5f17bc4f052188e1998e5c0bdc0ff6 Mon Sep 17 00:00:00 2001 From: Alec Jacobson Date: Sat, 11 Feb 2023 12:38:29 -0500 Subject: [PATCH 1/2] remove copy after libigl fix --- src/copyleft/cgal/convex_hull.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/copyleft/cgal/convex_hull.cpp b/src/copyleft/cgal/convex_hull.cpp index 8e225e95..8bb3bbfe 100644 --- a/src/copyleft/cgal/convex_hull.cpp +++ b/src/copyleft/cgal/convex_hull.cpp @@ -22,10 +22,7 @@ npe_arg(v, dense_float, dense_double) npe_begin_code() EigenDenseInt g; - // when https://github.com/libigl/libigl/pull/1989 is merged this copy should - // be removed - Eigen::MatrixXd v_copy = v.template cast(); - igl::copyleft::cgal::convex_hull(v_copy, g); + igl::copyleft::cgal::convex_hull(v, g); return npe::move(g); npe_end_code() From 7f2c85eb3f6876dcd6fd7961b2a4e54a8e56db94 Mon Sep 17 00:00:00 2001 From: Alec Jacobson Date: Sun, 12 Feb 2023 00:18:25 -0500 Subject: [PATCH 2/2] bump libigl --- cmake/PyiglDependencies.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/PyiglDependencies.cmake b/cmake/PyiglDependencies.cmake index d01f663f..3107b07e 100644 --- a/cmake/PyiglDependencies.cmake +++ b/cmake/PyiglDependencies.cmake @@ -19,7 +19,7 @@ include(FetchContent) FetchContent_Declare( libigl GIT_REPOSITORY https://github.com/libigl/libigl.git - GIT_TAG 78015d4da1c6799dfe15659ed35adfb3a5f23ffa + GIT_TAG 7e5512ce71d7394ba965964f66e9a9d91597e767 ) FetchContent_GetProperties(libigl) FetchContent_MakeAvailable(libigl)