From 8403aa1639d7c680be3bc3ec508296fd1886cc16 Mon Sep 17 00:00:00 2001 From: Eugene Yokota Date: Tue, 8 Jan 2019 00:35:22 -0500 Subject: [PATCH 1/2] specify contact-point-discovery.port-name Fixes #177 This specifies the management endpoint name explicity to `-Dakka.management.cluster.bootstrap.contact-point-discovery.port-name`. By default the management endpoint name will fallback to `"akka-mgmt-http"` for backward compatibility. In the future, sbt-reactive-app can declare the management endpoint name using "management-endpoint" as a label on the Docker image. See https://github.com/lightbend/sbt-reactive-app/pull/164. These changes combined together provides softlanding of the switch to `"management"` in https://github.com/akka/akka-management/pull/274. --- .../reactivecli/annotations/Annotations.scala | 12 ++++++++ .../rp/reactivecli/annotations/package.scala | 2 +- .../runtime/kubernetes/PodTemplate.scala | 28 ++++++++++++++++--- .../marathon/RpEnvironmentVariables.scala | 12 ++++++-- .../runtime/marathon/package.scala | 9 ++++-- .../annotations/AnnotationsTest.scala | 18 ++++++++++++ .../kubernetes/DeploymentJsonTest.scala | 12 ++++---- .../runtime/kubernetes/IngressJsonTest.scala | 2 ++ .../runtime/kubernetes/JobJsonTest.scala | 2 ++ .../kubernetes/NamespaceJsonTest.scala | 2 ++ .../runtime/kubernetes/ServiceJsonTest.scala | 2 ++ .../marathon/RpEnvironmentVariablesTest.scala | 10 ++++++- 12 files changed, 96 insertions(+), 15 deletions(-) diff --git a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala index 4322e34e..890369c0 100644 --- a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala +++ b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala @@ -36,6 +36,8 @@ case class Annotations( memory: Option[Long], cpu: Option[Double], endpoints: Map[String, Endpoint], + remotingEndpointName: Option[String], + managementEndpointName: Option[String], secrets: Seq[Secret], annotations: Seq[Annotation] = Seq.empty, privileged: Boolean, @@ -116,6 +118,8 @@ object Annotations extends LazyLogging { memory = args.memory.orElse(memory(labels)), cpu = args.cpu.orElse(cpu(labels)), endpoints = endpoints(selectArrayWithIndex(labels, ns("endpoints")), applicationVersion), + remotingEndpointName = remotingEndpointName(labels), + managementEndpointName = managementEndpointName(labels), secrets = secrets(selectArray(labels, ns("secrets"))), annotations = annotations(selectArray(labels, ns("annotations"))), privileged = privileged(labels), @@ -211,6 +215,14 @@ object Annotations extends LazyLogging { value <- annotation.get("value") } yield Annotation(key, value) + private[annotations] def remotingEndpointName(labels: Map[String, String]): Option[String] = + labels + .get(ns("remoting-endpoint")) + + private[annotations] def managementEndpointName(labels: Map[String, String]): Option[String] = + labels + .get(ns("management-endpoint")) + private[annotations] def endpoints(endpoints: Seq[(Int, Map[String, String])], version: Option[String]): Map[String, Endpoint] = endpoints.flatMap(v => endpoint(v._2, v._1, version)).toMap diff --git a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/package.scala b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/package.scala index 47f65e66..28494179 100644 --- a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/package.scala +++ b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/package.scala @@ -17,5 +17,5 @@ package com.lightbend.rp.reactivecli package object annotations { - val AkkaManagementPortName = "akka-mgmt-http" + val legacyAkkaManagementPortName = "akka-mgmt-http" } diff --git a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/PodTemplate.scala b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/PodTemplate.scala index 90e79b40..ba4b24e4 100644 --- a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/PodTemplate.scala +++ b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/PodTemplate.scala @@ -58,7 +58,14 @@ object PodTemplate { appTypeEnvs(annotations.appType, annotations.modules), configEnvs(annotations.configResource), endpointEnvs(annotations.endpoints), - akkaClusterEnvs(annotations.modules, annotations.namespace, serviceResourceName, noOfReplicas, annotations.akkaClusterBootstrapSystemName, akkaClusterJoinExisting), + akkaClusterEnvs( + annotations.modules, + annotations.namespace, + serviceResourceName, + annotations.managementEndpointName.getOrElse(legacyAkkaManagementPortName), + noOfReplicas, + annotations.akkaClusterBootstrapSystemName, + akkaClusterJoinExisting), externalServicesEnvs(annotations.modules, externalServices)) private[kubernetes] def appNameEnvs(appName: Option[String]): Map[String, EnvironmentVariable] = @@ -71,7 +78,14 @@ object PodTemplate { if (modules.isEmpty) Seq.empty else Seq("RP_MODULES" -> LiteralEnvironmentVariable(modules.toVector.sorted.mkString(",")))) }.toMap - private[kubernetes] def akkaClusterEnvs(modules: Set[String], namespace: Option[String], serviceResourceName: String, noOfReplicas: Int, akkaClusterBootstrapSystemName: Option[String], akkaClusterJoinExisting: Boolean): Map[String, EnvironmentVariable] = + private[kubernetes] def akkaClusterEnvs( + modules: Set[String], + namespace: Option[String], + serviceResourceName: String, + managementEndpointName: String, + noOfReplicas: Int, + akkaClusterBootstrapSystemName: Option[String], + akkaClusterJoinExisting: Boolean): Map[String, EnvironmentVariable] = if (!modules.contains(Module.AkkaClusterBootstrapping)) Map.empty else @@ -79,6 +93,7 @@ object PodTemplate { "RP_JAVA_OPTS" -> LiteralEnvironmentVariable( Seq( s"-Dakka.management.cluster.bootstrap.contact-point-discovery.discovery-method=kubernetes-api", + s"-Dakka.management.cluster.bootstrap.contact-point-discovery.port-name=$managementEndpointName", s"-Dakka.management.cluster.bootstrap.contact-point-discovery.effective-name=$serviceResourceName", s"-Dakka.management.cluster.bootstrap.contact-point-discovery.required-contact-point-nr=$noOfReplicas", akkaClusterBootstrapSystemName.fold("-Dakka.discovery.kubernetes-api.pod-label-selector=appName=%s")(systemName => s"-Dakka.discovery.kubernetes-api.pod-label-selector=actorSystemName=$systemName"), @@ -316,13 +331,18 @@ object PodTemplate { val enableChecks = annotations.modules.contains(Module.Status) && annotations.modules.contains(Module.AkkaManagement) + lazy val managementPortName = + annotations + .managementEndpointName + .getOrElse(legacyAkkaManagementPortName) + val livenessProbe = if (enableChecks) Json("livenessProbe" -> Json( "httpGet" -> Json( "path" -> jString(HealthCheckUrl), - "port" -> jString(AkkaManagementPortName)), + "port" -> jString(managementPortName)), "periodSeconds" -> jNumber(StatusPeriodSeconds), "initialDelaySeconds" -> jNumber(LivenessInitialDelaySeconds))) else @@ -334,7 +354,7 @@ object PodTemplate { Json( "httpGet" -> Json( "path" -> jString(ReadyCheckUrl), - "port" -> jString(AkkaManagementPortName)), + "port" -> jString(managementPortName)), "periodSeconds" -> jNumber(StatusPeriodSeconds))) else jEmptyObject diff --git a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariables.scala b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariables.scala index f1428e7f..ecd0bd9c 100644 --- a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariables.scala +++ b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariables.scala @@ -38,7 +38,7 @@ object RpEnvironmentVariables { appTypeEnvs(annotations.appType, annotations.modules), configEnvs(annotations.configResource), endpointEnvs(annotations.endpoints), - akkaClusterEnvs(annotations.modules, annotations.namespace, serviceResourceName, noOfReplicas, annotations.akkaClusterBootstrapSystemName, akkaClusterJoinExisting), + akkaClusterEnvs(annotations.modules, annotations.namespace, serviceResourceName, annotations.managementEndpointName.getOrElse(legacyAkkaManagementPortName), noOfReplicas, annotations.akkaClusterBootstrapSystemName, akkaClusterJoinExisting), externalServicesEnvs(annotations.modules, externalServices)) private def appNameEnvs(appName: Option[String]): Map[String, String] = @@ -51,13 +51,21 @@ object RpEnvironmentVariables { if (modules.isEmpty) Seq.empty else Seq("RP_MODULES" -> modules.toVector.sorted.mkString(","))) }.toMap - private def akkaClusterEnvs(modules: Set[String], namespace: Option[String], serviceResourceName: String, noOfReplicas: Int, akkaClusterBootstrapSystemName: Option[String], akkaClusterJoinExisting: Boolean): Map[String, String] = + private def akkaClusterEnvs( + modules: Set[String], + namespace: Option[String], + serviceResourceName: String, + managementEndpointName: String, + noOfReplicas: Int, + akkaClusterBootstrapSystemName: Option[String], + akkaClusterJoinExisting: Boolean): Map[String, String] = if (!modules.contains(Module.AkkaClusterBootstrapping)) Map.empty else Map( "RP_JAVA_OPTS" -> Seq( s"-Dakka.management.cluster.bootstrap.contact-point-discovery.discovery-method=marathon-api", + s"-Dakka.management.cluster.bootstrap.contact-point-discovery.port-name=$managementEndpointName", s"-Dakka.management.cluster.bootstrap.contact-point-discovery.effective-name=$serviceResourceName", s"-Dakka.management.cluster.bootstrap.contact-point-discovery.required-contact-point-nr=$noOfReplicas", akkaClusterBootstrapSystemName.fold("-Dakka.discovery.marathon-api.app-label-query=APP_NAME==%s")(systemName => s"-Dakka.discovery.marathon-api.app-label-query=ACTOR_SYSTEM_NAME==$systemName"), diff --git a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/package.scala b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/package.scala index 50640770..2a65ffe5 100644 --- a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/package.scala +++ b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/runtime/marathon/package.scala @@ -134,12 +134,17 @@ package object marathon { val enableChecks = annotations.modules.contains(Module.Status) && annotations.modules.contains(Module.AkkaManagement) + val managementPortName = + annotations + .managementEndpointName + .getOrElse(legacyAkkaManagementPortName) + val checkPortName = - portName(AkkaManagementPortName) + portName(managementPortName) val checkPortIndex = sortedEndpoints - .find(_.name == AkkaManagementPortName) + .find(_.name == managementPortName) .map(_.index) .getOrElse(0) diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala index 7bdb2891..4facfd07 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala @@ -120,6 +120,8 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, @@ -176,6 +178,8 @@ object AnnotationsTest extends TestSuite { "com.lightbend.rp.endpoints.2.name" -> "ep3", "com.lightbend.rp.endpoints.2.protocol" -> "udp", "com.lightbend.rp.endpoints.2.port" -> "1234", + "com.lightbend.rp.remoting-endpoint" -> "remoting", + "com.lightbend.rp.management-endpoint" -> "management", "com.lightbend.rp.annotations.0.key" -> "annotationKey0", "com.lightbend.rp.annotations.0.value" -> "annotationValue0", "com.lightbend.rp.annotations.1.key" -> "annotationKey1", @@ -198,6 +202,8 @@ object AnnotationsTest extends TestSuite { "ep1" -> HttpEndpoint(0, "ep1", 0, Seq(HttpIngress(Seq(80, 443), Seq("hello.com"), Seq("^/.*")))), "ep2" -> TcpEndpoint(1, "ep2", 1234), "ep3" -> UdpEndpoint(2, "ep3", 1234)), + remotingEndpointName = Some("remoting"), + managementEndpointName = Some("management"), secrets = Seq.empty, annotations = Vector( Annotation("annotationKey0", "annotationValue0"), @@ -240,6 +246,8 @@ object AnnotationsTest extends TestSuite { memory = Some(1024), cpu = Some(0.5), endpoints = Map.empty, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map( @@ -266,6 +274,8 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, @@ -288,6 +298,8 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, @@ -310,6 +322,8 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, @@ -338,6 +352,8 @@ object AnnotationsTest extends TestSuite { cpu = None, endpoints = Map( "ep2" -> TcpEndpoint(1, "ep2", 1234)), + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, @@ -364,6 +380,8 @@ object AnnotationsTest extends TestSuite { cpu = None, endpoints = Map( "ep2" -> TcpEndpoint(1, "ep2", 1234)), + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala index 703411d5..c8fe24fe 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala @@ -46,6 +46,8 @@ object DeploymentJsonTest extends TestSuite { memory = Some(8192L), cpu = Some(0.5D), endpoints = endpoints, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq(Secret("acme.co", "my-secret")), annotations = Seq( Annotation("annotationKey0", "annotationValue0"), @@ -438,7 +440,7 @@ object DeploymentJsonTest extends TestSuite { | "readinessProbe": { | "httpGet": { | "path": "/platform-tooling/ready", - | "port": "akka-mgmt-http" + | "port": "management" | }, | "periodSeconds": 10 | }, @@ -446,7 +448,7 @@ object DeploymentJsonTest extends TestSuite { | "livenessProbe": { | "httpGet": { | "path": "/platform-tooling/healthy", - | "port": "akka-mgmt-http" + | "port": "management" | }, | "periodSeconds": 10, | "initialDelaySeconds": 60 @@ -654,7 +656,7 @@ object DeploymentJsonTest extends TestSuite { | }, | { | "name": "RP_JAVA_OPTS", - | "value": "-Dconfig.resource=my-config.conf -Dakka.management.cluster.bootstrap.contact-point-discovery.discovery-method=kubernetes-api -Dakka.management.cluster.bootstrap.contact-point-discovery.effective-name=friendimpl -Dakka.management.cluster.bootstrap.contact-point-discovery.required-contact-point-nr=1 -Dakka.discovery.kubernetes-api.pod-label-selector=appName=%s" + | "value": "-Dconfig.resource=my-config.conf -Dakka.management.cluster.bootstrap.contact-point-discovery.discovery-method=kubernetes-api -Dakka.management.cluster.bootstrap.contact-point-discovery.port-name=management -Dakka.management.cluster.bootstrap.contact-point-discovery.effective-name=friendimpl -Dakka.management.cluster.bootstrap.contact-point-discovery.required-contact-point-nr=1 -Dakka.discovery.kubernetes-api.pod-label-selector=appName=%s" | }, | { | "name": "RP_KUBERNETES_POD_IP", @@ -709,8 +711,8 @@ object DeploymentJsonTest extends TestSuite { |} """.stripMargin.parse.right.get val result = Deployment.generate(annotations.copy( - modules = Set("akka-management", "status", "akka-cluster-bootstrapping") - ), "apps/v1beta2", None, imageName, + modules = Set("akka-management", "status", "akka-cluster-bootstrapping"), + managementEndpointName = Some("management")), "apps/v1beta2", None, imageName, PodTemplate.ImagePullPolicy.Never, PodTemplate.RestartPolicy.Default, noOfReplicas = 1, Map.empty, CanaryDeploymentType, JsonTransform.noop, false).toOption.get if (result.json != expectedJson) { println(s"deployment K8 JSON:\n" + PrettyParams.spaces2.copy(colonLeft = "").pretty(result.json)) diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala index 54933560..33bd77d0 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala @@ -45,6 +45,8 @@ object IngressJsonTest extends TestSuite { HttpIngress(Seq(80, 443), Seq.empty, Seq(urlOne)), HttpIngress(Seq(80, 443), Seq("hello.com"), Seq.empty), HttpIngress(Seq(80, 443), Seq("hello.com", "world.io"), Seq(urlOne, urlTwo))))), + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = true, environmentVariables = Map( diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala index ee62adf4..993cdb28 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala @@ -36,6 +36,8 @@ object JobJsonTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala index ae5caf59..391af5e8 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala @@ -40,6 +40,8 @@ object NamespaceJsonTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = false, environmentVariables = Map.empty, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala index 2401d0f7..3d448a95 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala @@ -39,6 +39,8 @@ object ServiceJsonTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = true, environmentVariables = Map( diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala index ba67a347..9d4ac2b5 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala @@ -42,6 +42,8 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = true, environmentVariables = Map( @@ -89,6 +91,8 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = true, environmentVariables = Map( @@ -109,7 +113,7 @@ object RpEnvironmentVariablesTest extends TestSuite { Map( "RP_ENDPOINT_0_BIND_PORT" -> "$PORT_EP", "RP_ENDPOINTS" -> "EP1", "RP_APP_VERSION" -> "3.2.1-SNAPSHOT", - "RP_JAVA_OPTS" -> "-Dakka.management.cluster.bootstrap.contact-point-discovery.discovery-method=marathon-api -Dakka.management.cluster.bootstrap.contact-point-discovery.effective-name=friendimpl -Dakka.management.cluster.bootstrap.contact-point-discovery.required-contact-point-nr=3 -Dakka.discovery.marathon-api.app-label-query=APP_NAME==%s", + "RP_JAVA_OPTS" -> "-Dakka.management.cluster.bootstrap.contact-point-discovery.discovery-method=marathon-api -Dakka.management.cluster.bootstrap.contact-point-discovery.port-name=management -Dakka.management.cluster.bootstrap.contact-point-discovery.effective-name=friendimpl -Dakka.management.cluster.bootstrap.contact-point-discovery.required-contact-point-nr=3 -Dakka.discovery.marathon-api.app-label-query=APP_NAME==%s", "RP_PLATFORM" -> "mesos", "RP_ENDPOINT_EP1_PORT" -> "$PORT_EP", "RP_MODULES" -> "akka-cluster-bootstrapping", @@ -138,6 +142,8 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), + remotingEndpointName = Some("remoting"), + managementEndpointName = Some("management"), secrets = Seq.empty, privileged = true, environmentVariables = Map( @@ -187,6 +193,8 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), + remotingEndpointName = None, + managementEndpointName = None, secrets = Seq.empty, privileged = true, environmentVariables = Map( From 2a66e5b834b03f1324876c0302e7f9abb201952d Mon Sep 17 00:00:00 2001 From: Eugene Yokota Date: Tue, 8 Jan 2019 12:51:38 -0500 Subject: [PATCH 2/2] Remove unused remotingEndpointName --- .../rp/reactivecli/annotations/Annotations.scala | 6 ------ .../rp/reactivecli/annotations/AnnotationsTest.scala | 8 -------- .../runtime/kubernetes/DeploymentJsonTest.scala | 1 - .../reactivecli/runtime/kubernetes/IngressJsonTest.scala | 1 - .../rp/reactivecli/runtime/kubernetes/JobJsonTest.scala | 1 - .../runtime/kubernetes/NamespaceJsonTest.scala | 1 - .../reactivecli/runtime/kubernetes/ServiceJsonTest.scala | 1 - .../runtime/marathon/RpEnvironmentVariablesTest.scala | 4 ---- 8 files changed, 23 deletions(-) diff --git a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala index 890369c0..d4143398 100644 --- a/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala +++ b/cli/shared/src/main/scala/com/lightbend/rp/reactivecli/annotations/Annotations.scala @@ -36,7 +36,6 @@ case class Annotations( memory: Option[Long], cpu: Option[Double], endpoints: Map[String, Endpoint], - remotingEndpointName: Option[String], managementEndpointName: Option[String], secrets: Seq[Secret], annotations: Seq[Annotation] = Seq.empty, @@ -118,7 +117,6 @@ object Annotations extends LazyLogging { memory = args.memory.orElse(memory(labels)), cpu = args.cpu.orElse(cpu(labels)), endpoints = endpoints(selectArrayWithIndex(labels, ns("endpoints")), applicationVersion), - remotingEndpointName = remotingEndpointName(labels), managementEndpointName = managementEndpointName(labels), secrets = secrets(selectArray(labels, ns("secrets"))), annotations = annotations(selectArray(labels, ns("annotations"))), @@ -215,10 +213,6 @@ object Annotations extends LazyLogging { value <- annotation.get("value") } yield Annotation(key, value) - private[annotations] def remotingEndpointName(labels: Map[String, String]): Option[String] = - labels - .get(ns("remoting-endpoint")) - private[annotations] def managementEndpointName(labels: Map[String, String]): Option[String] = labels .get(ns("management-endpoint")) diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala index 4facfd07..f6a8e291 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/annotations/AnnotationsTest.scala @@ -120,7 +120,6 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, @@ -202,7 +201,6 @@ object AnnotationsTest extends TestSuite { "ep1" -> HttpEndpoint(0, "ep1", 0, Seq(HttpIngress(Seq(80, 443), Seq("hello.com"), Seq("^/.*")))), "ep2" -> TcpEndpoint(1, "ep2", 1234), "ep3" -> UdpEndpoint(2, "ep3", 1234)), - remotingEndpointName = Some("remoting"), managementEndpointName = Some("management"), secrets = Seq.empty, annotations = Vector( @@ -246,7 +244,6 @@ object AnnotationsTest extends TestSuite { memory = Some(1024), cpu = Some(0.5), endpoints = Map.empty, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, @@ -274,7 +271,6 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, @@ -298,7 +294,6 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, @@ -322,7 +317,6 @@ object AnnotationsTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, @@ -352,7 +346,6 @@ object AnnotationsTest extends TestSuite { cpu = None, endpoints = Map( "ep2" -> TcpEndpoint(1, "ep2", 1234)), - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, @@ -380,7 +373,6 @@ object AnnotationsTest extends TestSuite { cpu = None, endpoints = Map( "ep2" -> TcpEndpoint(1, "ep2", 1234)), - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala index c8fe24fe..d8101729 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/DeploymentJsonTest.scala @@ -46,7 +46,6 @@ object DeploymentJsonTest extends TestSuite { memory = Some(8192L), cpu = Some(0.5D), endpoints = endpoints, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq(Secret("acme.co", "my-secret")), annotations = Seq( diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala index 33bd77d0..73040f49 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/IngressJsonTest.scala @@ -45,7 +45,6 @@ object IngressJsonTest extends TestSuite { HttpIngress(Seq(80, 443), Seq.empty, Seq(urlOne)), HttpIngress(Seq(80, 443), Seq("hello.com"), Seq.empty), HttpIngress(Seq(80, 443), Seq("hello.com", "world.io"), Seq(urlOne, urlTwo))))), - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = true, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala index 993cdb28..74b2572c 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/JobJsonTest.scala @@ -36,7 +36,6 @@ object JobJsonTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala index 391af5e8..fa7872a8 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/NamespaceJsonTest.scala @@ -40,7 +40,6 @@ object NamespaceJsonTest extends TestSuite { memory = None, cpu = None, endpoints = Map.empty, - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = false, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala index 3d448a95..24ea16d1 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/kubernetes/ServiceJsonTest.scala @@ -39,7 +39,6 @@ object ServiceJsonTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = true, diff --git a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala index 9d4ac2b5..44cdab01 100644 --- a/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala +++ b/cli/shared/src/test/scala/com/lightbend/rp/reactivecli/runtime/marathon/RpEnvironmentVariablesTest.scala @@ -42,7 +42,6 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = true, @@ -91,7 +90,6 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = true, @@ -142,7 +140,6 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), - remotingEndpointName = Some("remoting"), managementEndpointName = Some("management"), secrets = Seq.empty, privileged = true, @@ -193,7 +190,6 @@ object RpEnvironmentVariablesTest extends TestSuite { cpu = Some(0.5D), endpoints = Map( "ep1" -> TcpEndpoint(0, "ep1", 1234)), - remotingEndpointName = None, managementEndpointName = None, secrets = Seq.empty, privileged = true,