Add a simple test of upgrading from LDK 0.1

One major hole in our test coverage historically has been tests
covering upgrades or downgrades across LDK versions. Luckily, these
aren't particularly hard to write as cargo lets us depend on
previous versions of the `lightning` crate directly, which we can
use in tests.

Here we add a simple initial test of upgrading from LDK 0.1 while
there's a pending payment to be claimed.

Author: TheBlueMatt

ci/ci-tests.sh

@@ -32,7 +32,7 @@ cargo check --verbose --color always
 # When the workspace members change, make sure to update the list here as well
 # as in `Cargo.toml`.
 WORKSPACE_MEMBERS=(
-	lightning
+	lightning@0.2.0+git
 	lightning-types
 	lightning-block-sync
 	lightning-invoice
@@ -74,14 +74,14 @@ cargo test -p lightning-custom-message --verbose --color always
 [ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
 
 echo -e "\n\nTest backtrace-debug builds"
-cargo test -p lightning --verbose --color always --features backtrace
+cargo test -p lightning@0.2.0+git --verbose --color always --features backtrace
 
 echo -e "\n\nTesting no_std builds"
 for DIR in lightning-invoice lightning-rapid-gossip-sync lightning-liquidity; do
 	cargo test -p $DIR --verbose --color always --no-default-features
 done
 
-cargo test -p lightning --verbose --color always --no-default-features
+cargo test -p lightning@0.2.0+git --verbose --color always --no-default-features
 
 echo -e "\n\nTesting c_bindings builds"
 # Note that because `$RUSTFLAGS` is not passed through to doctest builds we cannot selectively
@@ -96,11 +96,11 @@ done
 # Note that because `$RUSTFLAGS` is not passed through to doctest builds we cannot selectively
 # disable doctests in `c_bindings` so we skip doctests entirely here.
 RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning-background-processor --verbose --color always --features futures --no-default-features --lib --bins --tests
-RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning --verbose --color always --no-default-features --lib --bins --tests
+RUSTFLAGS="$RUSTFLAGS --cfg=c_bindings" cargo test -p lightning@0.2.0+git --verbose --color always --no-default-features --lib --bins --tests
 
 echo -e "\n\nTesting other crate-specific builds"
 # Note that outbound_commitment_test only runs in this mode because of hardcoded signature values
-RUSTFLAGS="$RUSTFLAGS --cfg=ldk_test_vectors" cargo test -p lightning --verbose --color always --no-default-features --features=std
+RUSTFLAGS="$RUSTFLAGS --cfg=ldk_test_vectors" cargo test -p lightning@0.2.0+git --verbose --color always --no-default-features --features=std
 # This one only works for lightning-invoice
 # check that compile with no_std and serde works in lightning-invoice
 cargo test -p lightning-invoice --verbose --color always --no-default-features --features serde
@@ -127,8 +127,8 @@ if [ -f "$(which arm-none-eabi-gcc)" ]; then
 fi
 
 echo -e "\n\nTest cfg-flag builds"
-RUSTFLAGS="--cfg=taproot" cargo test --verbose --color always -p lightning
+RUSTFLAGS="--cfg=taproot" cargo test --verbose --color always -p lightning@0.2.0+git
 [ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
-RUSTFLAGS="--cfg=splicing" cargo test --verbose --color always -p lightning
+RUSTFLAGS="--cfg=splicing" cargo test --verbose --color always -p lightning@0.2.0+git
 [ "$CI_MINIMIZE_DISK_USAGE" != "" ] && cargo clean
-RUSTFLAGS="--cfg=async_payments" cargo test --verbose --color always -p lightning
+RUSTFLAGS="--cfg=async_payments" cargo test --verbose --color always -p lightning@0.2.0+git

lightning/Cargo.toml

@@ -52,6 +52,9 @@ libm = { version = "0.2", default-features = false }
 regex = "1.5.6"
 lightning-types = { version = "0.3.0", path = "../lightning-types", features = ["_test_utils"] }
 
+[target.'cfg(not(taproot))'.dev-dependencies]
+lightning_0_1 = { package = "lightning", version = "0.1.1", features = ["_test_utils"] }
+
 [dev-dependencies.bitcoin]
 version = "0.32.2"
 default-features = false

lightning/src/ln/mod.rs

@@ -97,5 +97,8 @@ mod offers_tests;
 #[cfg(test)]
 #[allow(unused_mut)]
 mod dual_funding_tests;
+#[cfg(all(not(taproot), test))]
+#[allow(unused_mut)]
+mod upgrade_downgrade_tests;
 
 pub use self::peer_channel_encryptor::LN_MAX_MSG_LEN;

lightning/src/ln/upgrade_downgrade_tests.rs

@@ -0,0 +1,61 @@
+// This file is Copyright its original authors, visible in version control
+// history.
+//
+// This file is licensed under the Apache License, Version 2.0 <LICENSE-APACHE
+// or http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
+// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
+// You may not use this file except in accordance with one or both of these
+// licenses.
+
+//! Tests which test upgrading from previous versions of LDK or downgrading to previous versions of
+//! LDK.
+
+use lightning_0_1::ln::functional_test_utils as lightning_0_1_utils;
+use lightning_0_1::get_monitor as get_monitor_0_1;
+use lightning_0_1::util::ser::Writeable;
+
+use crate::ln::functional_test_utils::*;
+use crate::types::payment::PaymentPreimage;
+
+#[test]
+fn simple_upgrade() {
+	// Tests a simple case of upgrading from LDK 0.1 with a pending payment
+	let (node_a, node_b, mon_a, mon_b, preimage);
+	{
+		let chanmon_cfgs = lightning_0_1_utils::create_chanmon_cfgs(2);
+		let node_cfgs = lightning_0_1_utils::create_node_cfgs(2, &chanmon_cfgs);
+		let node_chanmgrs = lightning_0_1_utils::create_node_chanmgrs(2, &node_cfgs, &[None, None]);
+		let nodes = lightning_0_1_utils::create_network(2, &node_cfgs, &node_chanmgrs);
+
+		let chan_id = lightning_0_1_utils::create_announced_chan_between_nodes(&nodes, 0, 1).2;
+
+		let payment_preimage = lightning_0_1_utils::route_payment(&nodes[0], &[&nodes[1]], 1_000_000);
+		preimage = PaymentPreimage(payment_preimage.0.0);
+
+		node_a = nodes[0].node.encode();
+		node_b = nodes[1].node.encode();
+		mon_a = get_monitor_0_1!(nodes[0], chan_id).encode();
+		mon_b = get_monitor_0_1!(nodes[1], chan_id).encode();
+	}
+
+	// Create a dummy node to reload over with the 0.1 state
+
+	let mut chanmon_cfgs = create_chanmon_cfgs(2);
+
+	// Our TestChannelSigner will fail as we're jumping ahead, so disable its state-based checks
+	chanmon_cfgs[0].keys_manager.disable_all_state_policy_checks = true;
+	chanmon_cfgs[1].keys_manager.disable_all_state_policy_checks = true;
+
+	let node_cfgs = create_node_cfgs(2, &chanmon_cfgs);
+	let (persister_a, persister_b, chain_monitor_a, chain_monitor_b);
+	let node_chanmgrs = create_node_chanmgrs(2, &node_cfgs, &[None, None]);
+	let (node_deser_a, node_deser_b);
+	let mut nodes = create_network(2, &node_cfgs, &node_chanmgrs);
+
+	reload_node!(nodes[0], test_default_channel_config(), &node_a, &[&mon_a], persister_a, chain_monitor_a, node_deser_a);
+	reload_node!(nodes[1], test_default_channel_config(), &node_b, &[&mon_b], persister_b, chain_monitor_b, node_deser_b);
+
+	reconnect_nodes(ReconnectArgs::new(&nodes[0], &nodes[1]));
+
+	claim_payment(&nodes[0], &[&nodes[1]], preimage);
+}