From 8d9eb96543b70c2ca1a4b5350e6f67e33c7668d3 Mon Sep 17 00:00:00 2001 From: Elias Rohrer Date: Thu, 24 Jul 2025 10:21:53 +0200 Subject: [PATCH 1/2] Drop `incremental-mutants` CI job Previously, the `incremental-mutants` CI job was failing on ~every PR that made actual logic changes, and nobody seemed to really make any effort to address the failures. The failing CI jobs therefore just resulted in additional which in turn could have us getting used to failing CI, introducing some risk of acutal failures slipping through. Of course, it also took up some (considerable?) time in the CI queue that might be better spent on other jobs if no contributors are actually benefitting from the CI job. Here we therefore drop `incremental-mutants` from our CI for the time being. --- .github/workflows/build.yml | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 0511d7bddbe..d9c29a2da06 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -301,20 +301,3 @@ jobs: rustup component add rustfmt - name: Run rustfmt checks run: cargo fmt --check - - incremental-mutants: - runs-on: ubuntu-latest - if: github.ref_name != 'main' # `main` has no diff with itself - steps: - - uses: actions/checkout@v4 - with: - fetch-depth: 0 - - name: Relative diff - run: | - git branch -av - git diff origin/main.. | tee git.diff - - uses: Swatinem/rust-cache@v2 - - name: Mutants - run: | - cargo install cargo-mutants - cargo mutants --no-shuffle -j 2 -vV --in-diff git.diff From 36116be5ffc51f6fe444b2e3c51df562d6bee36b Mon Sep 17 00:00:00 2001 From: Elias Rohrer Date: Thu, 24 Jul 2025 10:48:40 +0200 Subject: [PATCH 2/2] Have `check_commit` run against base branch --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index d9c29a2da06..b652b52935a 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -215,9 +215,9 @@ jobs: git fetch upstream export GIT_COMMITTER_EMAIL="rl-ci@example.com" export GIT_COMMITTER_NAME="RL CI" - git rebase upstream/main + git rebase upstream/${{ github.base_ref }} - name: For each commit, run cargo check (including in fuzz) - run: ci/check-each-commit.sh upstream/main + run: ci/check-each-commit.sh upstream/${{ github.base_ref }} check_release: runs-on: ubuntu-latest