Skip to content

routing: add cltv limit#2640

Merged
halseth merged 6 commits into
lightningnetwork:masterfrom
joostjager:cltv-limit
Mar 27, 2019
Merged

routing: add cltv limit#2640
halseth merged 6 commits into
lightningnetwork:masterfrom
joostjager:cltv-limit

Conversation

@joostjager
Copy link
Copy Markdown
Contributor

@joostjager joostjager commented Feb 13, 2019

This PR adds a maximum cltv limit for payments, similar to the currently existing fee limit.

@joostjager joostjager mentioned this pull request Feb 13, 2019
Closed
@joostjager joostjager requested a review from halseth February 13, 2019 11:34
@Roasbeef Roasbeef added this to the 0.6 milestone Feb 13, 2019
@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour routing rpc Related to the RPC interface cli Related to the command line interface labels Feb 13, 2019
@joostjager joostjager requested a review from wpaulino February 13, 2019 20:02
wpaulino
wpaulino reviewed Feb 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat unrelated -- I noticed that we check for the fee limit when constructing the route from the path. Is there a reason that check is still needed since we already do it within path finding?

Comment thread routing/pathfind.go Outdated
Comment thread routing/pathfind_test.go Outdated
Comment thread cmd/lncli/commands.go Outdated
Comment thread lnrpc/rpc.proto Outdated
Comment thread routing/pathfind_test.go Outdated
@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Feb 14, 2019

Somewhat unrelated -- I noticed that we check for the fee limit when constructing the route from the path. Is there a reason that check is still needed since we already do it within path finding?

I don't think there is. It is a sanity check, but I think it can be removed. I didn't bother adding another one for cltvLimit.

@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Feb 14, 2019

@wpaulino PTAL

@wpaulino
Copy link
Copy Markdown
Contributor

wpaulino commented Feb 14, 2019

I don't think there is. It is a sanity check, but I think it can be removed. I didn't bother adding another one for cltvLimit.

Gotcha, would be nice to remove it in a follow-up PR then.

@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Feb 14, 2019

I don't think there is. It is a sanity check, but I think it can be removed. I didn't bother adding another one for cltvLimit.

Gotcha, would be nice to remove it in a follow-up PR then.

Yes, I can do that.

@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Feb 14, 2019

@wpaulino ptal

wpaulino
wpaulino approved these changes Feb 14, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

halseth
halseth reviewed Feb 19, 2019
View reviewed changes
Comment thread routing/pathfind.go Outdated
Comment thread routing/router.go Outdated
@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Feb 21, 2019

@halseth comments replied to, ptal

@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Mar 5, 2019

Rebased

@joostjager joostjager force-pushed the cltv-limit branch 2 times, most recently from 4738b27 to d3ef006 Compare March 6, 2019 14:27
@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Mar 6, 2019

I don't think there is. It is a sanity check, but I think it can be removed. I didn't bother adding another one for cltvLimit.

Gotcha, would be nice to remove it in a follow-up PR then.

It is happening in #2497

@wpaulino
Copy link
Copy Markdown
Contributor

wpaulino commented Mar 15, 2019

Needs a rebase.

halseth
halseth reviewed Mar 19, 2019
View reviewed changes
Comment thread rpcserver.go Outdated
Copy link
Copy Markdown
Contributor

@halseth halseth Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check wouldn't be needed if we used 0 to indicate no limit.

Copy link
Copy Markdown
Contributor Author

@joostjager joostjager Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the same discussion as above. The conversion is done as early as possible to prevent having to deal with the magic value further down the call stack.

Comment thread cmd/lncli/commands.go Outdated
Comment thread routing/pathfind.go Outdated
@joostjager
routing: only warn for zero cltv delta edges
c5961d4 
This condition may be caused by a bug somewhere else in the system.
Expose it here as a warn log line.
@joostjager
Copy link
Copy Markdown
Contributor Author

joostjager commented Mar 19, 2019

ptal

halseth
halseth approved these changes Mar 27, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🕺

@halseth halseth merged commit 4d8100c into lightningnetwork:master Mar 27, 2019
@wpaulino wpaulino mentioned this pull request Apr 18, 2019
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@halseth halseth halseth approved these changes

@wpaulino wpaulino wpaulino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cli Related to the command line interface enhancement Improvements to existing features / behaviour routing rpc Related to the RPC interface

Projects

None yet

Milestone

0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@joostjager @wpaulino @halseth @Roasbeef