routing: undirected node pair based mission control [wip] [don't review]#3353
Closed
joostjager wants to merge 11 commits into
Closed
routing: undirected node pair based mission control [wip] [don't review]#3353joostjager wants to merge 11 commits into
joostjager wants to merge 11 commits into
Conversation
This commit prepares for timestamps being supplied from the database for processing of historical payment results.
This commit groups together all payment result data. It is a preparation for historical payment results being retrieved from the database.
6906945 to
2dcec12
Compare
Previously mission control tracked failures on a per node, per channel basis. This commit changes this to tracking on the level of directed node pairs. The goal of moving to this coarser-grained level is to reduce the number of required payment attempts without compromising payment reliability.
Contributor
Author
|
Closing this pr for now. I still think we will eventually be forced to move towards undirected pair-based penalization to be fully gaming resistent, but this will probably not be on the short term. Will keep this pr around for when that moment comes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds onto #1734
Previously mission control tracked failures on a directed node pair basis. This PR changes this to tracking on the level of undirected node pairs. The goal of moving to this coarser-grained level is to reduce the number of required payment attempts without compromising payment reliability.
Deeper analysis of channel-level failures and the way they should be attributed to nodes suggests that there always remains an uncertainty about which of the two endpoints is responsible for the failure. It is therefore appropriate to penalize the pair of nodes as a whole. This penalizes the bad node, while the good node only sees its connection to the bad node penalized. This prevents bad node pairs from being tried in both directions.
An exception is insufficient channel balance (
FailTemporaryChannelFailure). Undirected penalization may seem too aggressive in this case, but:This PR also prepares for #3256 where a correct, gaming-resistent, set of failure attribution rules is implemented.