From 37ee9783caffac3ada97b1b5c95c11809e4f4838 Mon Sep 17 00:00:00 2001 From: Youjung Kim Date: Fri, 14 Mar 2025 10:52:18 -0700 Subject: [PATCH 1/2] add condition in notify-slack job --- .github/workflows/e2e-suite.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/e2e-suite.yml b/.github/workflows/e2e-suite.yml index 165055a1b..afd65b295 100644 --- a/.github/workflows/e2e-suite.yml +++ b/.github/workflows/e2e-suite.yml @@ -234,7 +234,7 @@ jobs: process-upload-report: runs-on: ubuntu-latest needs: [integration_tests] - if: always() && github.repository == 'linode/linode-cli' # Run even if integration tests fail and only on main repository + if: always() # && github.repository == 'linode/linode-cli' # Run even if integration tests fail and only on main repository outputs: summary: ${{ steps.set-test-summary.outputs.summary }} @@ -291,8 +291,8 @@ jobs: notify-slack: runs-on: ubuntu-latest - needs: [integration_tests] - if: ${{ (success() || failure()) && github.repository == 'linode/linode-cli' }} # Run even if integration tests fail and only on main repository + needs: [integration_tests, process-upload-report] + if: ${{ (success() || failure()) }} #&& github.repository == 'linode/linode-cli' }} # Run even if integration tests fail and only on main repository steps: - name: Notify Slack From 7da3f1510874c1044086954eab21c6e24377e0e7 Mon Sep 17 00:00:00 2001 From: Youjung Kim Date: Fri, 14 Mar 2025 11:43:34 -0700 Subject: [PATCH 2/2] add condition in notify-slack job --- .github/workflows/e2e-suite.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/e2e-suite.yml b/.github/workflows/e2e-suite.yml index afd65b295..b1e19ab49 100644 --- a/.github/workflows/e2e-suite.yml +++ b/.github/workflows/e2e-suite.yml @@ -234,7 +234,7 @@ jobs: process-upload-report: runs-on: ubuntu-latest needs: [integration_tests] - if: always() # && github.repository == 'linode/linode-cli' # Run even if integration tests fail and only on main repository + if: always() && github.repository == 'linode/linode-cli' # Run even if integration tests fail and only on main repository outputs: summary: ${{ steps.set-test-summary.outputs.summary }} @@ -292,7 +292,7 @@ jobs: notify-slack: runs-on: ubuntu-latest needs: [integration_tests, process-upload-report] - if: ${{ (success() || failure()) }} #&& github.repository == 'linode/linode-cli' }} # Run even if integration tests fail and only on main repository + if: ${{ (success() || failure()) && github.repository == 'linode/linode-cli' }} # Run even if integration tests fail and only on main repository steps: - name: Notify Slack