From 08187ae624514e99d503dcde55b1788985f2bdc7 Mon Sep 17 00:00:00 2001 From: Pavel Cahyna Date: Thu, 10 May 2018 18:28:13 +0200 Subject: [PATCH 1/2] Unset the executable bit on Ansible module. Per the policy defined in https://docs.ansible.com/ansible/latest/dev_guide/testing/sanity/shebang.html. (Some RPM checks https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/f7e8f73eadbd09f6eee0e836bf3cb80f14f0c053/f/brp-mangle-shebangs do not like an executable script to have a #!/usr/bin/python shebang.) --- library/network_connections.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 library/network_connections.py diff --git a/library/network_connections.py b/library/network_connections.py old mode 100755 new mode 100644 From ff4471407ee56e1b5f82c232ed1ca5e0caf6a6d2 Mon Sep 17 00:00:00 2001 From: Pavel Cahyna Date: Thu, 10 May 2018 18:32:03 +0200 Subject: [PATCH 2/2] Unset the executable bit on the unit test. This script is not being executed directly, but by using python, python2 or python3 interpreter and passing the script name as argument. This is because the script is to be tested under multiple versions of Python. (It is also only referenced in a copy task and the remote copy gets executed, which makes the executable bit on the original unneeded as well.) (Some RPM checks https://src.fedoraproject.org/rpms/redhat-rpm-config/blob/f7e8f73eadbd09f6eee0e836bf3cb80f14f0c053/f/brp-mangle-shebangs do not like an executable script to have a #!/usr/bin/python shebang. This script has it to indicate that it is compatible with both versions of Python, although a shebang line is not very meaningful here for the same reason as the executable bit.) --- library/test_network_connections.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100755 => 100644 library/test_network_connections.py diff --git a/library/test_network_connections.py b/library/test_network_connections.py old mode 100755 new mode 100644