From 37fd01fc0619d3d9b8e2d952b305d47ca3680936 Mon Sep 17 00:00:00 2001
From: David Zhao <dz@livekit.io>
Date: Wed, 13 Aug 2025 22:15:05 -0700
Subject: [PATCH] fix: package version parsing when loading from git

also fixed other tests, added unit tests as part of CI
---
 .github/workflows/build.yaml          |  3 +++
 pkg/agentfs/docker_test.go            |  6 ++++--
 pkg/agentfs/sdk_version_check.go      |  6 ++++++
 pkg/agentfs/sdk_version_check_test.go | 18 ++++++++++++++++++
 pkg/agentfs/tar.go                    |  1 +
 pkg/loadtester/loadtest.go            |  2 +-
 6 files changed, 33 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
index a929b85a..bb193ff7 100644
--- a/.github/workflows/build.yaml
+++ b/.github/workflows/build.yaml
@@ -46,3 +46,6 @@ jobs:
         with:
           version: "latest"
           install-go: false
+
+      - name: Run Go tests
+        run: go test -v ./...
diff --git a/pkg/agentfs/docker_test.go b/pkg/agentfs/docker_test.go
index 77c36f90..f13d94a9 100644
--- a/pkg/agentfs/docker_test.go
+++ b/pkg/agentfs/docker_test.go
@@ -8,8 +8,10 @@ func TestLoadDockerFiles(t *testing.T) {
 	expectedFiles := []string{
 		"examples/node.Dockerfile",
 		"examples/node.dockerignore",
-		"examples/python.Dockerfile",
-		"examples/python.dockerignore",
+		"examples/python.pip.Dockerfile",
+		"examples/python.pip.dockerignore",
+		"examples/python.uv.Dockerfile",
+		"examples/python.uv.dockerignore",
 	}
 
 	for _, file := range expectedFiles {
diff --git a/pkg/agentfs/sdk_version_check.go b/pkg/agentfs/sdk_version_check.go
index c0899f6c..b42a33cc 100644
--- a/pkg/agentfs/sdk_version_check.go
+++ b/pkg/agentfs/sdk_version_check.go
@@ -134,6 +134,12 @@ func checkPackageInFile(filePath string, projectType ProjectType, pythonMinVersi
 
 // parsePythonPackageVersion parses a Python package line and extracts the version
 func parsePythonPackageVersion(line string) (string, bool) {
+	// Git URLs don't have traditional versions, so we treat them as "latest"
+	gitPattern := regexp.MustCompile(`(?i)^livekit-agents(?:\[[^\]]+\])?\s*@\s*git\+`)
+	if gitPattern.MatchString(line) {
+		return "latest", true
+	}
+
 	// match with optional extras and version specifiers
 	pattern := regexp.MustCompile(`(?i)^livekit-agents(?:\[[^\]]+\])?\s*([=~><!]+)?\s*([^#]+)?`)
 	matches := pattern.FindStringSubmatch(line)
diff --git a/pkg/agentfs/sdk_version_check_test.go b/pkg/agentfs/sdk_version_check_test.go
index 889e2121..1acb64a1 100644
--- a/pkg/agentfs/sdk_version_check_test.go
+++ b/pkg/agentfs/sdk_version_check_test.go
@@ -425,6 +425,24 @@ func TestParsePythonPackageVersion(t *testing.T) {
 			expectedOutput: "",
 			expectedFound:  false,
 		},
+		{
+			name:           "Git URL format",
+			input:          "livekit-agents[openai,turn-detector,silero,cartesia,deepgram] @ git+https://github.com/livekit/agents.git@load-debug#subdirectory=livekit-agents",
+			expectedOutput: "latest",
+			expectedFound:  true,
+		},
+		{
+			name:           "Git URL format with extras",
+			input:          "livekit-agents[voice] @ git+https://github.com/livekit/agents.git@main",
+			expectedOutput: "latest",
+			expectedFound:  true,
+		},
+		{
+			name:           "Git URL format simple",
+			input:          "livekit-agents @ git+https://github.com/livekit/agents.git",
+			expectedOutput: "latest",
+			expectedFound:  true,
+		},
 	}
 
 	for _, tt := range tests {
diff --git a/pkg/agentfs/tar.go b/pkg/agentfs/tar.go
index 56907b3c..711401cc 100644
--- a/pkg/agentfs/tar.go
+++ b/pkg/agentfs/tar.go
@@ -37,6 +37,7 @@ var (
 		".gitignore",
 		".git",
 		"node_modules",
+		".env",
 		".env.*",
 	}
 
diff --git a/pkg/loadtester/loadtest.go b/pkg/loadtester/loadtest.go
index a17ae98a..257d8349 100644
--- a/pkg/loadtester/loadtest.go
+++ b/pkg/loadtester/loadtest.go
@@ -179,7 +179,7 @@ func (t *LoadTest) Run(ctx context.Context) error {
 			formatBitrate(s.bytes, s.elapsed),
 			formatBitrate(s.bytes/int64(len(summaries)), s.elapsed),
 		)
-		summaryTable.Row("Total", fmt.Sprintf("%d/%d", s.tracks, s.expected), sBitrate, sDropped, string(s.errCount))
+		summaryTable.Row("Total", fmt.Sprintf("%d/%d", s.tracks, s.expected), sBitrate, sDropped, strconv.FormatInt(s.errCount, 10))
 	}
 	fmt.Println("\nSubscriber summaries:")
 	fmt.Println(summaryTable)