From 00decfec6c0fdcd499015845f476dcdcd77c4b00 Mon Sep 17 00:00:00 2001
From: Mark Conroy <mark@mark.ie>
Date: Mon, 13 Oct 2025 12:58:37 +0100
Subject: [PATCH 1/2] adds strict type and returns for all php files in module

---
 .../Field/FieldFormatter/ButtonsInsideWell.php     |  4 +++-
 .../Field/FieldFormatter/TaxonomyVerticalList.php  |  8 +++++---
 .../Plugin/Field/FieldFormatter/TwitterFeed.php    |  4 +++-
 .../src/Functional/ServicesLandingPageTest.php     |  2 ++
 .../src/EntityChildRelationshipUi.php              |  4 +++-
 .../src/EntityReferenceValue.php                   |  2 ++
 .../EntityReferenceSelection/ServicesSelection.php | 12 +++++++-----
 .../EntityReferenceServicesAutocompleteTest.php    |  2 ++
 .../LandingPageChildrenTest.php                    |  2 ++
 .../tests/src/Kernel/ChildReferencesTest.php       |  2 ++
 .../tests/src/Kernel/ParentFieldPathautoTest.php   |  2 ++
 .../src/Plugin/Block/ServicesRelatedLinksBlock.php |  2 ++
 .../Plugin/Block/ServicesRelatedTopicsBlock.php    |  4 +++-
 .../tests/src/Functional/ServicesPageTest.php      |  2 ++
 .../src/Controller/ServiceStatusPageController.php |  6 ++++--
 .../src/EventSubscriber/PageHeaderSubscriber.php   |  2 ++
 .../localgov_services_status/src/PathProcessor.php |  6 ++++--
 .../src/Plugin/Block/ServiceStatusMessage.php      |  8 +++++---
 .../src/Plugin/views/style/ServiceStatus.php       |  2 ++
 .../localgov_services_status/src/ServiceStatus.php | 14 +++++++++-----
 .../ServiceStatusMessageVisibilityTest.php         |  2 ++
 .../tests/src/Functional/ServiceStatusTest.php     |  2 ++
 .../tests/src/Kernel/PathTest.php                  |  2 ++
 .../Field/FieldFormatter/LinkNodeReference.php     |  6 ++++--
 .../tests/src/Functional/ServiceSublandingTest.php |  2 ++
 .../tests/src/Functional/TopicListBuilderTest.php  |  2 ++
 src/Plugin/Block/ServicesBlockBase.php             |  6 ++++--
 src/Plugin/Block/ServicesCtaBlock.php              |  4 +++-
 src/Plugin/Field/FieldWidget/LinkWithType.php      |  4 +++-
 tests/src/Functional/PagesIntegrationTest.php      |  2 ++
 tests/src/Functional/ServicesBlockTest.php         |  2 ++
 tests/src/Functional/WorkflowsIntegrationTest.php  |  2 ++
 32 files changed, 96 insertions(+), 30 deletions(-)

diff --git a/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/ButtonsInsideWell.php b/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/ButtonsInsideWell.php
index d1388e9..9e28b59 100644
--- a/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/ButtonsInsideWell.php
+++ b/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/ButtonsInsideWell.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_landing\Plugin\Field\FieldFormatter;
 
 use Drupal\Core\Field\FieldItemListInterface;
@@ -24,7 +26,7 @@ class ButtonsInsideWell extends FormatterBase {
   /**
    * {@inheritdoc}
    */
-  public function viewElements(FieldItemListInterface $items, $langcode) {
+  public function viewElements(FieldItemListInterface $items, $langcode): array {
     $elements = [];
 
     foreach ($items as $delta => $item) {
diff --git a/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TaxonomyVerticalList.php b/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TaxonomyVerticalList.php
index b91035a..1c2be00 100644
--- a/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TaxonomyVerticalList.php
+++ b/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TaxonomyVerticalList.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_landing\Plugin\Field\FieldFormatter;
 
 use Drupal\Core\Field\FieldItemListInterface;
@@ -34,7 +36,7 @@ public static function defaultSettings() {
   /**
    * {@inheritdoc}
    */
-  public function settingsForm(array $form, FormStateInterface $form_state) {
+  public function settingsForm(array $form, FormStateInterface $form_state): array {
     $elements['title'] = [
       '#type' => 'textfield',
       '#title' => $this->t('Title'),
@@ -47,7 +49,7 @@ public function settingsForm(array $form, FormStateInterface $form_state) {
   /**
    * {@inheritdoc}
    */
-  public function settingsSummary() {
+  public function settingsSummary(): array {
     $summary = [];
 
     if ($this->getSetting('title')) {
@@ -63,7 +65,7 @@ public function settingsSummary() {
   /**
    * {@inheritdoc}
    */
-  public function viewElements(FieldItemListInterface $items, $langcode) {
+  public function viewElements(FieldItemListInterface $items, $langcode): array {
     return [
       '#theme' => 'taxonomy_vertical_list',
       '#title' => $this->getSetting('title'),
diff --git a/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TwitterFeed.php b/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TwitterFeed.php
index 92a7737..19826cb 100644
--- a/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TwitterFeed.php
+++ b/modules/localgov_services_landing/src/Plugin/Field/FieldFormatter/TwitterFeed.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_landing\Plugin\Field\FieldFormatter;
 
 use Drupal\Core\Field\FieldItemListInterface;
@@ -24,7 +26,7 @@ class TwitterFeed extends FormatterBase {
   /**
    * {@inheritdoc}
    */
-  public function viewElements(FieldItemListInterface $items, $langcode) {
+  public function viewElements(FieldItemListInterface $items, $langcode): array {
     $elements = [];
 
     foreach ($items as $delta => $item) {
diff --git a/modules/localgov_services_landing/tests/src/Functional/ServicesLandingPageTest.php b/modules/localgov_services_landing/tests/src/Functional/ServicesLandingPageTest.php
index 0ed1df5..7299a8c 100644
--- a/modules/localgov_services_landing/tests/src/Functional/ServicesLandingPageTest.php
+++ b/modules/localgov_services_landing/tests/src/Functional/ServicesLandingPageTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_landing\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/modules/localgov_services_navigation/src/EntityChildRelationshipUi.php b/modules/localgov_services_navigation/src/EntityChildRelationshipUi.php
index 41697b3..37a86b4 100644
--- a/modules/localgov_services_navigation/src/EntityChildRelationshipUi.php
+++ b/modules/localgov_services_navigation/src/EntityChildRelationshipUi.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_navigation;
 
 use Drupal\Component\Utility\Html;
@@ -91,7 +93,7 @@ public static function create(ContainerInterface $container) {
    *
    * @see hook_entity_extra_field_info()
    */
-  public function entityExtraFieldInfo() {
+  public function entityExtraFieldInfo(): array {
     $fields = [];
     foreach (['localgov_services_landing', 'localgov_services_sublanding'] as $bundle) {
       $fields['node'][$bundle]['form']['localgov_services_navigation_children'] = [
diff --git a/modules/localgov_services_navigation/src/EntityReferenceValue.php b/modules/localgov_services_navigation/src/EntityReferenceValue.php
index c5212a7..a10f5f3 100644
--- a/modules/localgov_services_navigation/src/EntityReferenceValue.php
+++ b/modules/localgov_services_navigation/src/EntityReferenceValue.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_navigation;
 
 use Drupal\Component\Utility\Tags;
diff --git a/modules/localgov_services_navigation/src/Plugin/EntityReferenceSelection/ServicesSelection.php b/modules/localgov_services_navigation/src/Plugin/EntityReferenceSelection/ServicesSelection.php
index 2a7f073..0e24a45 100644
--- a/modules/localgov_services_navigation/src/Plugin/EntityReferenceSelection/ServicesSelection.php
+++ b/modules/localgov_services_navigation/src/Plugin/EntityReferenceSelection/ServicesSelection.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_navigation\Plugin\EntityReferenceSelection;
 
 use Drupal\Component\Utility\Html;
@@ -115,7 +117,7 @@ public static function create(ContainerInterface $container, array $configuratio
   /**
    * {@inheritdoc}
    */
-  public function defaultConfiguration() {
+  public function defaultConfiguration(): array {
     return [
       'target_type' => 'node',
       'target_bundles' => [],
@@ -125,7 +127,7 @@ public function defaultConfiguration() {
   /**
    * {@inheritdoc}
    */
-  public function buildConfigurationForm(array $form, FormStateInterface $form_state) {
+  public function buildConfigurationForm(array $form, FormStateInterface $form_state): array {
     $form = parent::buildConfigurationForm($form, $form_state);
 
     $configuration = $this->getConfiguration();
@@ -165,7 +167,7 @@ public function buildConfigurationForm(array $form, FormStateInterface $form_sta
   /**
    * {@inheritdoc}
    */
-  public function getReferenceableEntities($match = NULL, $match_operator = 'CONTAINS', $limit = 0) {
+  public function getReferenceableEntities($match = NULL, $match_operator = 'CONTAINS', $limit = 0): array {
     $entities = [];
     $query = $this->buildEntityQuery($match, $match_operator)
       ->accessCheck(TRUE);
@@ -249,7 +251,7 @@ protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS')
   /**
    * {@inheritdoc}
    */
-  public function countReferenceableEntities($match = NULL, $match_operator = 'CONTAINS') {
+  public function countReferenceableEntities($match = NULL, $match_operator = 'CONTAINS'): int {
     $query = $this->buildEntityQuery($match, $match_operator);
     return $query
       ->count()
@@ -260,7 +262,7 @@ public function countReferenceableEntities($match = NULL, $match_operator = 'CON
   /**
    * {@inheritdoc}
    */
-  public function validateReferenceableEntities(array $ids) {
+  public function validateReferenceableEntities(array $ids): array {
     $result = [];
     if ($ids) {
       $entity_type = $this->entityTypeManager->getDefinition('node');
diff --git a/modules/localgov_services_navigation/tests/src/FunctionalJavascript/EntityReferenceServicesAutocompleteTest.php b/modules/localgov_services_navigation/tests/src/FunctionalJavascript/EntityReferenceServicesAutocompleteTest.php
index 4bcac1e..d61d49d 100644
--- a/modules/localgov_services_navigation/tests/src/FunctionalJavascript/EntityReferenceServicesAutocompleteTest.php
+++ b/modules/localgov_services_navigation/tests/src/FunctionalJavascript/EntityReferenceServicesAutocompleteTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_navigation\FunctionalJavascript;
 
 use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
diff --git a/modules/localgov_services_navigation/tests/src/FunctionalJavascript/LandingPageChildrenTest.php b/modules/localgov_services_navigation/tests/src/FunctionalJavascript/LandingPageChildrenTest.php
index 6795352..8c8cbd4 100644
--- a/modules/localgov_services_navigation/tests/src/FunctionalJavascript/LandingPageChildrenTest.php
+++ b/modules/localgov_services_navigation/tests/src/FunctionalJavascript/LandingPageChildrenTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_navigation\FunctionalJavascript;
 
 use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
diff --git a/modules/localgov_services_navigation/tests/src/Kernel/ChildReferencesTest.php b/modules/localgov_services_navigation/tests/src/Kernel/ChildReferencesTest.php
index 4fdbff3..d9368f1 100644
--- a/modules/localgov_services_navigation/tests/src/Kernel/ChildReferencesTest.php
+++ b/modules/localgov_services_navigation/tests/src/Kernel/ChildReferencesTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_navigation\Kernel;
 
 use Drupal\KernelTests\KernelTestBase;
diff --git a/modules/localgov_services_navigation/tests/src/Kernel/ParentFieldPathautoTest.php b/modules/localgov_services_navigation/tests/src/Kernel/ParentFieldPathautoTest.php
index ed122a6..24d9200 100644
--- a/modules/localgov_services_navigation/tests/src/Kernel/ParentFieldPathautoTest.php
+++ b/modules/localgov_services_navigation/tests/src/Kernel/ParentFieldPathautoTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_navigation\Kernel;
 
 use Drupal\KernelTests\KernelTestBase;
diff --git a/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedLinksBlock.php b/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedLinksBlock.php
index 75482cb..7f0e88c 100644
--- a/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedLinksBlock.php
+++ b/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedLinksBlock.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_page\Plugin\Block;
 
 use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
diff --git a/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedTopicsBlock.php b/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedTopicsBlock.php
index 38fa650..ee6067d 100644
--- a/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedTopicsBlock.php
+++ b/modules/localgov_services_page/src/Plugin/Block/ServicesRelatedTopicsBlock.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_page\Plugin\Block;
 
 use Drupal\localgov_services\Plugin\Block\ServicesBlockBase;
@@ -21,7 +23,7 @@ class ServicesRelatedTopicsBlock extends ServicesBlockBase {
   /**
    * {@inheritdoc}
    */
-  public function build() {
+  public function build(): array {
     $build = [];
     $links = [];
 
diff --git a/modules/localgov_services_page/tests/src/Functional/ServicesPageTest.php b/modules/localgov_services_page/tests/src/Functional/ServicesPageTest.php
index 32e2c50..b3cac11 100644
--- a/modules/localgov_services_page/tests/src/Functional/ServicesPageTest.php
+++ b/modules/localgov_services_page/tests/src/Functional/ServicesPageTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_page\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/modules/localgov_services_status/src/Controller/ServiceStatusPageController.php b/modules/localgov_services_status/src/Controller/ServiceStatusPageController.php
index ee4a742..463e4f4 100644
--- a/modules/localgov_services_status/src/Controller/ServiceStatusPageController.php
+++ b/modules/localgov_services_status/src/Controller/ServiceStatusPageController.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_status\Controller;
 
 use Drupal\Core\Access\AccessResult;
@@ -62,12 +64,12 @@ public function access(NodeInterface $node): AccessResult {
    * Build service status page.
    *
    * @param \Drupal\node\Entity\Node $node
-   *   Service node.
+   *   The service node.
    *
    * @return array
    *   A render array.
    */
-  public function build(Node $node) {
+  public function build(Node $node): array {
     $build = [];
 
     $build[] = [
diff --git a/modules/localgov_services_status/src/EventSubscriber/PageHeaderSubscriber.php b/modules/localgov_services_status/src/EventSubscriber/PageHeaderSubscriber.php
index a0c4d46..b49c5c7 100644
--- a/modules/localgov_services_status/src/EventSubscriber/PageHeaderSubscriber.php
+++ b/modules/localgov_services_status/src/EventSubscriber/PageHeaderSubscriber.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_status\EventSubscriber;
 
 use Drupal\Core\Path\CurrentPathStack;
diff --git a/modules/localgov_services_status/src/PathProcessor.php b/modules/localgov_services_status/src/PathProcessor.php
index 371426d..715adb2 100644
--- a/modules/localgov_services_status/src/PathProcessor.php
+++ b/modules/localgov_services_status/src/PathProcessor.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_status;
 
 use Drupal\Core\Language\LanguageInterface;
@@ -51,7 +53,7 @@ public function __construct(InboundPathProcessorInterface $path_processor, Langu
   /**
    * {@inheritdoc}
    */
-  public function processInbound($path, Request $request) {
+  public function processInbound($path, Request $request): string {
     $request_path = $this->getPath($request->getPathInfo());
 
     if (substr($request_path, -7) == '/status') {
@@ -68,7 +70,7 @@ public function processInbound($path, Request $request) {
   /**
    * {@inheritdoc}
    */
-  public function processOutbound($path, &$options = [], ?Request $request = NULL, ?BubbleableMetadata $bubbleableMetadata = NULL) {
+  public function processOutbound($path, &$options = [], ?Request $request = NULL, ?BubbleableMetadata $bubbleableMetadata = NULL): string {
     assert($this->pathProcessor instanceof OutboundPathProcessorInterface);
 
     // This is the inverse of inbound. Maybe less all-encompassing to swap this
diff --git a/modules/localgov_services_status/src/Plugin/Block/ServiceStatusMessage.php b/modules/localgov_services_status/src/Plugin/Block/ServiceStatusMessage.php
index 3b5264a..a66c8a3 100644
--- a/modules/localgov_services_status/src/Plugin/Block/ServiceStatusMessage.php
+++ b/modules/localgov_services_status/src/Plugin/Block/ServiceStatusMessage.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_status\Plugin\Block;
 
 use Drupal\Core\Access\AccessResult;
@@ -121,7 +123,7 @@ public function __construct(array $configuration, $plugin_id, $plugin_definition
   /**
    * {@inheritdoc}
    */
-  public function build() {
+  public function build(): array {
     $build = [];
 
     $build['#theme'] = 'service_status_message';
@@ -145,14 +147,14 @@ protected function blockAccess(AccountInterface $account) {
   /**
    * {@inheritdoc}
    */
-  public function getCacheContexts() {
+  public function getCacheContexts(): array {
     return Cache::mergeContexts(parent::getCacheContexts(), $this->cacheContexts);
   }
 
   /**
    * {@inheritdoc}
    */
-  public function getCacheTags() {
+  public function getCacheTags(): array {
     // Invalidate cache on changes to localgov_services_status nodes.
     return Cache::mergeTags(parent::getCacheTags(), $this->cacheTags, ['node_list:localgov_services_status']);
   }
diff --git a/modules/localgov_services_status/src/Plugin/views/style/ServiceStatus.php b/modules/localgov_services_status/src/Plugin/views/style/ServiceStatus.php
index 1ec121b..ddff73e 100644
--- a/modules/localgov_services_status/src/Plugin/views/style/ServiceStatus.php
+++ b/modules/localgov_services_status/src/Plugin/views/style/ServiceStatus.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_status\Plugin\views\style;
 
 use Drupal\views\Plugin\views\style\StylePluginBase;
diff --git a/modules/localgov_services_status/src/ServiceStatus.php b/modules/localgov_services_status/src/ServiceStatus.php
index 6b91b99..8cbec73 100644
--- a/modules/localgov_services_status/src/ServiceStatus.php
+++ b/modules/localgov_services_status/src/ServiceStatus.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_status;
 
 use Drupal\Core\Entity\EntityRepositoryInterface;
@@ -42,20 +44,20 @@ public function __construct(EntityTypeManagerInterface $entity_type_manager, Ent
   }
 
   /**
-   * Returns the latest 2 status updates for the service landing page.
+   * Returns the latest 2 status updates for the service landing page blocks.
    *
    * @param \Drupal\node\Entity\Node $node
    *   Service landing page node to get status pages for.
    *
    * @return array
-   *   Array of item variables to render in Twig template.
+   *   Array of status objects.
    *
    * @throws \Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException
    * @throws \Drupal\Component\Plugin\Exception\PluginNotFoundException
    * @throws \Drupal\Core\Entity\EntityMalformedException
    * @throws \Drupal\Core\TypedData\Exception\MissingDataException
    */
-  public function getStatusForBlock(Node $node) {
+  public function getStatusForBlock(Node $node): array {
     return $this->getStatusUpdates($node, 2, FALSE, TRUE);
   }
 
@@ -73,10 +75,12 @@ public function getStatusForBlock(Node $node) {
    * @throws \Drupal\Core\Entity\EntityMalformedException
    * @throws \Drupal\Core\TypedData\Exception\MissingDataException
    */
-  public function getStatusForPage(Node $node) {
+  public function getStatusForPage(Node $node): array {
     return $this->getStatusUpdates($node, 10, TRUE, FALSE);
   }
 
+
+
   /**
    * Returns the latest $n status updates for the service landing page.
    *
@@ -97,7 +101,7 @@ public function getStatusForPage(Node $node) {
    * @throws \Drupal\Core\Entity\EntityMalformedException
    * @throws \Drupal\Core\TypedData\Exception\MissingDataException
    */
-  public function getStatusUpdates(NodeInterface $landing_node, $n, $hide_from_list = FALSE, $hide_from_landing = FALSE) {
+  public function getStatusUpdates(NodeInterface $landing_node, $n, $hide_from_list = FALSE, $hide_from_landing = FALSE): array {
     $query = $this->statusUpdatesQuery($landing_node->id(), $hide_from_list, $hide_from_landing);
     $result = $query->sort('created', 'DESC')
       ->range(0, $n)
diff --git a/modules/localgov_services_status/tests/src/Functional/ServiceStatusMessageVisibilityTest.php b/modules/localgov_services_status/tests/src/Functional/ServiceStatusMessageVisibilityTest.php
index f67536d..b1bf017 100644
--- a/modules/localgov_services_status/tests/src/Functional/ServiceStatusMessageVisibilityTest.php
+++ b/modules/localgov_services_status/tests/src/Functional/ServiceStatusMessageVisibilityTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_status\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/modules/localgov_services_status/tests/src/Functional/ServiceStatusTest.php b/modules/localgov_services_status/tests/src/Functional/ServiceStatusTest.php
index 2cf7c71..d85c0cf 100644
--- a/modules/localgov_services_status/tests/src/Functional/ServiceStatusTest.php
+++ b/modules/localgov_services_status/tests/src/Functional/ServiceStatusTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_status\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/modules/localgov_services_status/tests/src/Kernel/PathTest.php b/modules/localgov_services_status/tests/src/Kernel/PathTest.php
index 9da9b42..a63aa32 100644
--- a/modules/localgov_services_status/tests/src/Kernel/PathTest.php
+++ b/modules/localgov_services_status/tests/src/Kernel/PathTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_status\Kernel;
 
 use Drupal\KernelTests\KernelTestBase;
diff --git a/modules/localgov_services_sublanding/src/Plugin/Field/FieldFormatter/LinkNodeReference.php b/modules/localgov_services_sublanding/src/Plugin/Field/FieldFormatter/LinkNodeReference.php
index 964b555..4258091 100644
--- a/modules/localgov_services_sublanding/src/Plugin/Field/FieldFormatter/LinkNodeReference.php
+++ b/modules/localgov_services_sublanding/src/Plugin/Field/FieldFormatter/LinkNodeReference.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services_sublanding\Plugin\Field\FieldFormatter;
 
 use Drupal\Core\Cache\Cache;
@@ -87,7 +89,7 @@ public static function defaultSettings() {
   /**
    * {@inheritdoc}
    */
-  public function viewElements(FieldItemListInterface $items, $langcode) {
+  public function viewElements(FieldItemListInterface $items, $langcode): array {
     $build = [];
 
     foreach ($items as $item) {
@@ -207,7 +209,7 @@ private function buildEntityLink(EntityInterface $entity) {
   /**
    * {@inheritdoc}
    */
-  public function settingsForm(array $form, FormStateInterface $form_state) {
+  public function settingsForm(array $form, FormStateInterface $form_state): array {
     $form['view_mode'] = [
       '#title' => $this->t('View Mode'),
       '#type' => 'select',
diff --git a/modules/localgov_services_sublanding/tests/src/Functional/ServiceSublandingTest.php b/modules/localgov_services_sublanding/tests/src/Functional/ServiceSublandingTest.php
index 4df4b2b..a2dd232 100644
--- a/modules/localgov_services_sublanding/tests/src/Functional/ServiceSublandingTest.php
+++ b/modules/localgov_services_sublanding/tests/src/Functional/ServiceSublandingTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_sublanding\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/modules/localgov_services_sublanding/tests/src/Functional/TopicListBuilderTest.php b/modules/localgov_services_sublanding/tests/src/Functional/TopicListBuilderTest.php
index 9f768f6..4706591 100644
--- a/modules/localgov_services_sublanding/tests/src/Functional/TopicListBuilderTest.php
+++ b/modules/localgov_services_sublanding/tests/src/Functional/TopicListBuilderTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services_sublanding\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/src/Plugin/Block/ServicesBlockBase.php b/src/Plugin/Block/ServicesBlockBase.php
index ede7685..7e8da70 100644
--- a/src/Plugin/Block/ServicesBlockBase.php
+++ b/src/Plugin/Block/ServicesBlockBase.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services\Plugin\Block;
 
 use Drupal\Core\Access\AccessResult;
@@ -92,14 +94,14 @@ protected function blockAccess(AccountInterface $account) {
   /**
    * {@inheritdoc}
    */
-  public function getCacheTags() {
+  public function getCacheTags(): array {
     return Cache::mergeTags(parent::getCacheTags(), ['node:' . $this->node->id()]);
   }
 
   /**
    * {@inheritdoc}
    */
-  public function getCacheContexts() {
+  public function getCacheContexts(): array {
     return Cache::mergeContexts(parent::getCacheContexts(), ['route']);
   }
 
diff --git a/src/Plugin/Block/ServicesCtaBlock.php b/src/Plugin/Block/ServicesCtaBlock.php
index af102ac..5fe5996 100644
--- a/src/Plugin/Block/ServicesCtaBlock.php
+++ b/src/Plugin/Block/ServicesCtaBlock.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services\Plugin\Block;
 
 use Drupal\Core\Access\AccessResult;
@@ -35,7 +37,7 @@ protected function blockAccess(AccountInterface $account) {
   /**
    * {@inheritdoc}
    */
-  public function build() {
+  public function build(): array {
     $buttons = [];
 
     foreach ($this->node->get('localgov_common_tasks')->getValue() as $call_to_action) {
diff --git a/src/Plugin/Field/FieldWidget/LinkWithType.php b/src/Plugin/Field/FieldWidget/LinkWithType.php
index ab8cb69..da5548a 100644
--- a/src/Plugin/Field/FieldWidget/LinkWithType.php
+++ b/src/Plugin/Field/FieldWidget/LinkWithType.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\localgov_services\Plugin\Field\FieldWidget;
 
 use Drupal\Core\Field\FieldItemListInterface;
@@ -22,7 +24,7 @@ class LinkWithType extends LinkWidget {
   /**
    * {@inheritdoc}
    */
-  public function formElement(FieldItemListInterface $items, $delta, array $element, array &$form, FormStateInterface $form_state) {
+  public function formElement(FieldItemListInterface $items, $delta, array $element, array &$form, FormStateInterface $form_state): array {
     $element = parent::formElement($items, $delta, $element, $form, $form_state);
 
     $element['options']['type'] = [
diff --git a/tests/src/Functional/PagesIntegrationTest.php b/tests/src/Functional/PagesIntegrationTest.php
index 864847d..425f67e 100644
--- a/tests/src/Functional/PagesIntegrationTest.php
+++ b/tests/src/Functional/PagesIntegrationTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/tests/src/Functional/ServicesBlockTest.php b/tests/src/Functional/ServicesBlockTest.php
index 8b11492..79a7dea 100644
--- a/tests/src/Functional/ServicesBlockTest.php
+++ b/tests/src/Functional/ServicesBlockTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services\Functional;
 
 use Drupal\Tests\BrowserTestBase;
diff --git a/tests/src/Functional/WorkflowsIntegrationTest.php b/tests/src/Functional/WorkflowsIntegrationTest.php
index 0fbf550..52f8ade 100644
--- a/tests/src/Functional/WorkflowsIntegrationTest.php
+++ b/tests/src/Functional/WorkflowsIntegrationTest.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Drupal\Tests\localgov_services\Functional;
 
 use Drupal\Tests\BrowserTestBase;

From 0791577f71c566b4287fd65a3b8b8281a6b05a6a Mon Sep 17 00:00:00 2001
From: Mark Conroy <mark@mark.ie>
Date: Mon, 13 Oct 2025 13:24:15 +0100
Subject: [PATCH 2/2] coding standards fix

---
 modules/localgov_services_status/src/ServiceStatus.php | 2 --
 1 file changed, 2 deletions(-)

diff --git a/modules/localgov_services_status/src/ServiceStatus.php b/modules/localgov_services_status/src/ServiceStatus.php
index 8cbec73..e978a84 100644
--- a/modules/localgov_services_status/src/ServiceStatus.php
+++ b/modules/localgov_services_status/src/ServiceStatus.php
@@ -79,8 +79,6 @@ public function getStatusForPage(Node $node): array {
     return $this->getStatusUpdates($node, 10, TRUE, FALSE);
   }
 
-
-
   /**
    * Returns the latest $n status updates for the service landing page.
    *