From 0132f4d1a4d52680764f58958fee060af4aeec3a Mon Sep 17 00:00:00 2001 From: Kevin Delisle Date: Thu, 15 Feb 2018 13:09:55 -0500 Subject: [PATCH] test(cli): disable GitHub cloning tests The check for equality on example packages after cloning prevents update of the contents of those packages, since they are no longer equivalent! As a result, we are disabling this test for now until we can come up with something that suitably validates the behaviour we expect, but in a way that doesn't prevent future changes from passing tests. --- packages/cli/test/clone-example.test.js | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/packages/cli/test/clone-example.test.js b/packages/cli/test/clone-example.test.js index f07e15fc5038..0e4f404c55b8 100644 --- a/packages/cli/test/clone-example.test.js +++ b/packages/cli/test/clone-example.test.js @@ -17,11 +17,23 @@ const VALID_EXAMPLE = 'getting-started'; const SANDBOX_PATH = path.resolve(__dirname, 'sandbox'); let sandbox; -describe('cloneExampleFromGitHub (SLOW)', function() { +describe.skip('cloneExampleFromGitHub (SLOW)', function() { this.timeout(20000); before(createSandbox); beforeEach(resetSandbox); + /** + * FIXME(kjdelisle): This test will prevent any meaningful changes from + * landing in example repositories, since it will always fail the equality + * test provided when new files are added, or when existing files are + * removed as a part of refactor/cleanup. + * + * While I do value the idea of verifying that the example packages are + * being cloned properly, we can't hang that idea on validating the + * particular presence of any content that isn't perpetually required. + * + * This test can be removed once strongloop/loopback-next#932 is complete. + */ it('extracts all project files', () => { return cloneExampleFromGitHub(VALID_EXAMPLE, SANDBOX_PATH) .then(outDir => {