From 103378c687877e90eb9a180c9d5333fdda700e6b Mon Sep 17 00:00:00 2001 From: Mario Estrada Date: Tue, 9 Oct 2018 08:39:21 -0600 Subject: [PATCH] fix(example-soap-calculator): fix decreased coverage on accpetance test --- .../home-page.controller.acceptance.ts | 55 +++++++++---------- 1 file changed, 26 insertions(+), 29 deletions(-) diff --git a/examples/soap-calculator/test/acceptance/home-page.controller.acceptance.ts b/examples/soap-calculator/test/acceptance/home-page.controller.acceptance.ts index f78f989e4632..8c3b2872ac2d 100644 --- a/examples/soap-calculator/test/acceptance/home-page.controller.acceptance.ts +++ b/examples/soap-calculator/test/acceptance/home-page.controller.acceptance.ts @@ -1,31 +1,28 @@ -import {get} from '@loopback/openapi-v3'; -import * as fs from 'fs'; -import * as path from 'path'; -import {inject} from '@loopback/context'; -import {RestBindings, Response} from '@loopback/rest'; +// Copyright IBM Corp. 2018. All Rights Reserved. +// Node module: @loopback/example-shopping +// This file is licensed under the MIT License. +// License text available at https://opensource.org/licenses/MIT -export class HomePageController { - private html: string; - constructor(@inject(RestBindings.Http.RESPONSE) private response: Response) { - this.html = fs.readFileSync( - path.join(__dirname, '../../../public/index.html'), - 'utf-8', - ); - } +import {Client} from '@loopback/testlab'; +import {SoapCalculatorApplication} from '../..'; +import {setupApplication} from './test-helper'; - @get('/', { - responses: { - '200': { - description: 'Home Page', - content: {'text/html': {schema: {type: 'string'}}}, - }, - }, - }) - homePage() { - this.response - .status(200) - .contentType('html') - .send(this.html); - return this.response; - } -} +describe('HomePageController', () => { + let app: SoapCalculatorApplication; + let client: Client; + + before('setupApplication', async () => { + ({app, client} = await setupApplication()); + }); + + after(async () => { + await app.stop(); + }); + + it('exposes a default home page', async () => { + await client + .get('/') + .expect(200) + .expect('Content-Type', /text\/html/); + }); +});