diff --git a/packages/repository-tests/README.md b/packages/repository-tests/README.md index 74b12bc91c53..18ac997fc080 100644 --- a/packages/repository-tests/README.md +++ b/packages/repository-tests/README.md @@ -67,7 +67,7 @@ tests: export function createRetrieveSuite( dataSourceOptions: DataSourceOptions, repositoryClass: CrudRepositoryCtor, - connectorFeatures: CrudConnectorFeatures, + features: CrudFeatures, ) { // test code } diff --git a/packages/repository-tests/src/crud-test-suite.ts b/packages/repository-tests/src/crud-test-suite.ts index 6856b6b04fb0..7928251f17d7 100644 --- a/packages/repository-tests/src/crud-test-suite.ts +++ b/packages/repository-tests/src/crud-test-suite.ts @@ -20,18 +20,18 @@ const debug = debugFactory('loopback:repository-tests'); type SuiteFn = ( dataSourceOptions: DataSourceOptions, repositoryClass: CrudRepositoryCtor, - connectorFeatures: CrudFeatures, + features: CrudFeatures, ) => void; export function crudRepositoryTestSuite( dataSourceOptions: DataSourceOptions, repositoryClass: CrudRepositoryCtor, - connectorFeatures: Partial, + partialFeatures: Partial, ) { const features: CrudFeatures = { idType: 'string', freeFormProperties: true, - ...connectorFeatures, + ...partialFeatures, }; describe('CRUD Repository operations', () => { @@ -39,7 +39,7 @@ export function crudRepositoryTestSuite( withCrudCtx(function setupContext(ctx: CrudTestContext) { ctx.dataSourceOptions = dataSourceOptions; ctx.repositoryClass = repositoryClass; - ctx.connectorFeatures = features; + ctx.features = features; }), ); before( @@ -70,7 +70,7 @@ export function crudRepositoryTestSuite( suite.name, dataSourceOptions, 'class ' + repositoryClass.name, - connectorFeatures, + partialFeatures, ); suite(dataSourceOptions, repositoryClass, features); } diff --git a/packages/repository-tests/src/crud/create-retrieve.suite.ts b/packages/repository-tests/src/crud/create-retrieve.suite.ts index 4699107f6871..3b8cf9c102bd 100644 --- a/packages/repository-tests/src/crud/create-retrieve.suite.ts +++ b/packages/repository-tests/src/crud/create-retrieve.suite.ts @@ -19,12 +19,12 @@ import { export function createRetrieveSuite( dataSourceOptions: DataSourceOptions, repositoryClass: CrudRepositoryCtor, - connectorFeatures: CrudFeatures, + features: CrudFeatures, ) { @model() class Product extends Entity { @property({ - type: connectorFeatures.idType, + type: features.idType, id: true, generated: true, description: 'The unique identifier for a product', diff --git a/packages/repository-tests/src/crud/freeform-properties.suite.ts b/packages/repository-tests/src/crud/freeform-properties.suite.ts index b4dbe583bfa7..a821bfa243a7 100644 --- a/packages/repository-tests/src/crud/freeform-properties.suite.ts +++ b/packages/repository-tests/src/crud/freeform-properties.suite.ts @@ -18,17 +18,17 @@ import { export function freeformPropertiesSuite( dataSourceOptions: DataSourceOptions, repositoryClass: CrudRepositoryCtor, - connectorFeatures: CrudFeatures, + features: CrudFeatures, ) { skipIf<[(this: Suite) => void], void>( - !connectorFeatures.freeFormProperties, + !features.freeFormProperties, describe, 'free-form properties (strict: false)', () => { @model({settings: {strict: false}}) class Freeform extends Entity { @property({ - type: connectorFeatures.idType, + type: features.idType, id: true, description: 'The unique identifier for a product', }) diff --git a/packages/repository-tests/src/types.repository-tests.ts b/packages/repository-tests/src/types.repository-tests.ts index a8721ac5b1ff..8d5377857d69 100644 --- a/packages/repository-tests/src/types.repository-tests.ts +++ b/packages/repository-tests/src/types.repository-tests.ts @@ -60,6 +60,6 @@ export type CrudRepositoryCtor = new < export interface CrudTestContext { dataSourceOptions: DataSourceOptions; repositoryClass: CrudRepositoryCtor; - connectorFeatures: CrudFeatures; + features: CrudFeatures; dataSource: juggler.DataSource; } diff --git a/packages/testlab/src/skip.ts b/packages/testlab/src/skip.ts index f0096c3af82e..4e2bc5383166 100644 --- a/packages/testlab/src/skip.ts +++ b/packages/testlab/src/skip.ts @@ -17,7 +17,7 @@ export type TestDefinition = ( * @example * ```ts * skipIf( - * !connectorFeatures.freeFormProperties, + * !features.freeFormProperties, * describe, * 'free-form properties (strict: false)', * () => {