From 5dece184bffa6961ec3145e0d3ba85471b955b0a Mon Sep 17 00:00:00 2001 From: Yee Cheng Chin Date: Mon, 12 Sep 2022 00:49:42 -0700 Subject: [PATCH] Remove DSA key for Sparkle updates Sparkle has deprecated signing updates with DSA for a long time. MacVim has also added an EdDSA key for a while now. This means we can remove the DSA key and still be pretty safe and certain that vast majority of MacVim users can still update from old versions of MacVim to the new one, using only the EdDSA key. This makes the update process easier and we don't have to use legacy tools to sign each update with the deprecated DSA key. --- src/MacVim/Info.plist | 2 -- src/MacVim/MacVim.xcodeproj/project.pbxproj | 2 -- src/MacVim/dsa_pub.pem | 20 -------------------- 3 files changed, 24 deletions(-) delete mode 100644 src/MacVim/dsa_pub.pem diff --git a/src/MacVim/Info.plist b/src/MacVim/Info.plist index 6f917ed193..067b6d1575 100644 --- a/src/MacVim/Info.plist +++ b/src/MacVim/Info.plist @@ -1309,8 +1309,6 @@ SUFeedURL https://raw.githubusercontent.com/macvim-dev/macvim/gh-pages/appcast/latest.xml - SUPublicDSAKeyFile - dsa_pub.pem SUPublicEDKey Pt4zsg/8S3/mxKW7Cmt0cZFw/+2LOuXOYS93evP+Mfc= NSAppleEventsUsageDescription diff --git a/src/MacVim/MacVim.xcodeproj/project.pbxproj b/src/MacVim/MacVim.xcodeproj/project.pbxproj index 662d75efa6..8b827646d3 100644 --- a/src/MacVim/MacVim.xcodeproj/project.pbxproj +++ b/src/MacVim/MacVim.xcodeproj/project.pbxproj @@ -66,7 +66,6 @@ 528DA66A1426D4F9003380F1 /* macvim-askpass in Copy Scripts */ = {isa = PBXBuildFile; fileRef = 528DA6691426D4EB003380F1 /* macvim-askpass */; }; 52A364731C4A5789005757EC /* Sparkle.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 52A364721C4A5789005757EC /* Sparkle.framework */; settings = {ATTRIBUTES = (Weak, ); }; }; 52A364761C4A57C1005757EC /* Sparkle.framework in Copy Frameworks */ = {isa = PBXBuildFile; fileRef = 52A364721C4A5789005757EC /* Sparkle.framework */; settings = {ATTRIBUTES = (CodeSignOnCopy, RemoveHeadersOnCopy, ); }; }; - 52B7ED9B1C4A4D6900AFFF15 /* dsa_pub.pem in Resources */ = {isa = PBXBuildFile; fileRef = 52B7ED9A1C4A4D6900AFFF15 /* dsa_pub.pem */; }; 8D11072B0486CEB800E47090 /* InfoPlist.strings in Resources */ = {isa = PBXBuildFile; fileRef = 089C165CFE840E0CC02AAC07 /* InfoPlist.strings */; }; 8D11072D0486CEB800E47090 /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 29B97316FDCFA39411CA2CEA /* main.m */; settings = {ATTRIBUTES = (); }; }; 8D11072F0486CEB800E47090 /* Cocoa.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 1058C7A1FEA54F0111CA2CBB /* Cocoa.framework */; }; @@ -959,7 +958,6 @@ isa = PBXResourcesBuildPhase; buildActionMask = 2147483647; files = ( - 52B7ED9B1C4A4D6900AFFF15 /* dsa_pub.pem in Resources */, 8D11072B0486CEB800E47090 /* InfoPlist.strings in Resources */, 1D0E051C0BA5F83800B6049E /* Colors.plist in Resources */, 1DD04DEC0C529C5E006CDC2B /* Credits.rtf in Resources */, diff --git a/src/MacVim/dsa_pub.pem b/src/MacVim/dsa_pub.pem deleted file mode 100644 index d6d3ab879a..0000000000 --- a/src/MacVim/dsa_pub.pem +++ /dev/null @@ -1,20 +0,0 @@ ------BEGIN PUBLIC KEY----- -MIIDPDCCAi4GByqGSM44BAEwggIhAoIBAQDXPZhkghjT8B+q6/4EKIdxRKzrjrH/ -f2G5EKFNJHBd8Vk5B4W2QMNT58fzkK5mpWeB9G/06j2JPeuGfjeIJU0I/rBZBEIC -k6sIjc54LyNClR0hc5in1VjTfwyPCyBLuDi20VGh/2t+57SP368Z8ntgvVcQRobu -2R+B9kqWwf2o3DjycJ+uo7ZUUuNyuyBjuOUbNyVBoHRr8Vi+0wqnVfjQkFwpDlvz -6R8hM99DIs4CBzznG/Lj3tRjJgLa4f1m65LV8zAzY+cbBeuZhFRCMgT6f7Ms0k6A -ackU60jdTs3tvXvVvFmeKuzshvHb7UJTUytRmz6U1iavge4AE7FWWf47AhUA1jk5 -vtv9jY3qsm+4OrzuHVz6XI0CggEBAMDLK4odbktcj8NRVXurFArvQEX9u/xNvD5R -VxvDP3QJYRE9pM2HY+oQVkRlrbOTfwRzO+chUnl07DzfPPw4eKA7H0XZmhBEqy6b -Gl8aETjEb+6IjWiigYGkK0mzUmtWzJVR5NNnWKdkNOz7sVOf03roRoDkofwNzjIN -t4jmULqx2Bzx/skS0TlOdOFGYJX2JgJwtRgUS41msUnk4bURzO/SSrHtwhO2nkwR -Imq2CYuLy1Y0UQLd/2FduBvTiOmKWmPmaeLfqY0eqU7gM3wfyM0xQLWf4bSW/+3q -rY4uxtPFdbNPyyXTj8QqJsG9iZPaeXl7vDB2/6zcFuWSf75aAyMDggEGAAKCAQEA -yPGgXeP1KOuVSau1P0JUyp+OAT7zXiQ2jlcvrz/WkXUWT9oUX8h24HOTMbbyWzwn -tqsXeGvvG7Jxj06SU83NHleIHeiquCgNdhz8DR9KVHoYhsHpiCJwAkfrEg6mo0/+ -mcJD+2SJc2XkgtD4fQDsaiab04EEAU0rmVuqIC/de2lnxORXpwxbJtbdvjsoHp8f -3UNA/W8uLjrnr96OswVb1O9Qb2Xhy9D1NoI7tSwJNGw9JHDutbjKH/NMyyAow08D -JUMlk7vPujUwnWd4D7xqn5LtkbY1mszwmoWWl9XiLPma+/BmLg68q0cxto1e1jLw -XUNTjLvYzqdTQyllL+lf7g== ------END PUBLIC KEY-----