From 606aee914a34125e24a9b2d734ad99aaa7805ba2 Mon Sep 17 00:00:00 2001 From: James Couball Date: Mon, 12 Oct 2020 17:29:07 -0700 Subject: [PATCH] Allow members of @main-branch/ruby_git-codeowners to do code review approvals. --- CODEOWNERS | 3 ++- CONTRIBUTING.md | 4 ++-- MAINTAINERS.md | 8 -------- 3 files changed, 4 insertions(+), 11 deletions(-) delete mode 100644 MAINTAINERS.md diff --git a/CODEOWNERS b/CODEOWNERS index 717572c..857e61e 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,3 +1,4 @@ # Defines who must review pull requests. +# See https://help.github.com/articles/about-codeowners/ for details. -* @jcouball \ No newline at end of file +* @jcouball @main-branch/ruby_git-codeowners \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 039bafc..6c4e33f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,8 +46,8 @@ Follow the instructions in the pull request template. Code review takes place in a GitHub pull request using the [the Github pull request review feature](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews). -Once your pull request is ready for review, request a review from at least one -[maintainer](MAINTAINERS.md) and any number of other contributors. +Once your pull request is ready for review, request a review from at least one of the +[code owners](https://github.com/orgs/main-branch/teams/ruby_git-codeowners/members). During the review process, you may need to make additional commits which would need to be squashed. It may also be necessary to rebase to main again if other diff --git a/MAINTAINERS.md b/MAINTAINERS.md deleted file mode 100644 index 99332cb..0000000 --- a/MAINTAINERS.md +++ /dev/null @@ -1,8 +0,0 @@ -# Maintainers - -When making changes in this repository, one of the maintainers below must review -and approve your pull request. - -### Maintainers - -* [James Couball](https://github.com/jcouball)