From 84451f250a70f56294937f95b814bd9d9f251892 Mon Sep 17 00:00:00 2001 From: NarayanBavisetti Date: Tue, 29 Aug 2023 13:11:38 +0530 Subject: [PATCH 1/3] fix: issue votes --- apiserver/plane/api/views/issue.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/apiserver/plane/api/views/issue.py b/apiserver/plane/api/views/issue.py index 0b08bb14fd8..49939090698 100644 --- a/apiserver/plane/api/views/issue.py +++ b/apiserver/plane/api/views/issue.py @@ -1799,8 +1799,9 @@ def create(self, request, slug, project_id, issue_id): actor_id=request.user.id, project_id=project_id, issue_id=issue_id, - vote=request.data.get("vote", 1), ) + issue_vote.vote = request.data.get("vote", 1) + issue_vote.save() serializer = IssueVoteSerializer(issue_vote) return Response(serializer.data, status=status.HTTP_201_CREATED) except Exception as e: From 590c33cf410dbfefc790dbfec231088060a12ad7 Mon Sep 17 00:00:00 2001 From: NarayanBavisetti Date: Tue, 29 Aug 2023 13:23:12 +0530 Subject: [PATCH 2/3] fix: added default as 1 in vote --- apiserver/plane/db/models/issue.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/apiserver/plane/db/models/issue.py b/apiserver/plane/db/models/issue.py index 7af9e6e1423..1633cbaf917 100644 --- a/apiserver/plane/db/models/issue.py +++ b/apiserver/plane/db/models/issue.py @@ -476,10 +476,12 @@ class IssueVote(ProjectBaseModel): choices=( (-1, "DOWNVOTE"), (1, "UPVOTE"), - ) + ), + default=1, ) + class Meta: - unique_together = ["issue", "actor"] + unique_together = ["issue", "actor", "vote"] verbose_name = "Issue Vote" verbose_name_plural = "Issue Votes" db_table = "issue_votes" From 0ed54f47ce7c46b3e497c3132fd84edf145bddbf Mon Sep 17 00:00:00 2001 From: NarayanBavisetti Date: Tue, 29 Aug 2023 13:30:35 +0530 Subject: [PATCH 3/3] fix: issue vote migration file --- ..._together_alter_issuevote_vote_and_more.py | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 apiserver/plane/db/migrations/0042_alter_issuevote_unique_together_alter_issuevote_vote_and_more.py diff --git a/apiserver/plane/db/migrations/0042_alter_issuevote_unique_together_alter_issuevote_vote_and_more.py b/apiserver/plane/db/migrations/0042_alter_issuevote_unique_together_alter_issuevote_vote_and_more.py new file mode 100644 index 00000000000..d8063acc052 --- /dev/null +++ b/apiserver/plane/db/migrations/0042_alter_issuevote_unique_together_alter_issuevote_vote_and_more.py @@ -0,0 +1,26 @@ +# Generated by Django 4.2.3 on 2023-08-29 07:58 + +from django.db import migrations, models + + +class Migration(migrations.Migration): + + dependencies = [ + ('db', '0041_cycle_sort_order_issuecomment_access_and_more'), + ] + + operations = [ + migrations.AlterUniqueTogether( + name='issuevote', + unique_together=set(), + ), + migrations.AlterField( + model_name='issuevote', + name='vote', + field=models.IntegerField(choices=[(-1, 'DOWNVOTE'), (1, 'UPVOTE')], default=1), + ), + migrations.AlterUniqueTogether( + name='issuevote', + unique_together={('issue', 'actor', 'vote')}, + ), + ]