From 9deccc6e381ec3e3762a4e2ee7a60b6bb7d9c61b Mon Sep 17 00:00:00 2001 From: pablohashescobar Date: Wed, 6 Sep 2023 19:32:18 +0530 Subject: [PATCH 1/2] chore: response status for project views update --- apiserver/plane/api/views/project.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/apiserver/plane/api/views/project.py b/apiserver/plane/api/views/project.py index a83bbca25d4..49b81af615f 100644 --- a/apiserver/plane/api/views/project.py +++ b/apiserver/plane/api/views/project.py @@ -924,8 +924,7 @@ def post(self, request, slug, project_id): project_member.save() - return Response(status=status.HTTP_200_OK) - + return Response(status=status.HTTP_204_NO_CONTENT) except Project.DoesNotExist: return Response( {"error": "The requested resource does not exists"}, From 170e578808657cbb5efccc3e22eaf518b2cecf14 Mon Sep 17 00:00:00 2001 From: pablohashescobar Date: Thu, 7 Sep 2023 13:59:16 +0530 Subject: [PATCH 2/2] dev: remove 200 OK response from empty contents --- apiserver/plane/api/views/project.py | 2 +- apiserver/plane/api/views/workspace.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apiserver/plane/api/views/project.py b/apiserver/plane/api/views/project.py index 49b81af615f..093c8ff7826 100644 --- a/apiserver/plane/api/views/project.py +++ b/apiserver/plane/api/views/project.py @@ -482,7 +482,7 @@ def create(self, request): # Delete joined project invites project_invitations.delete() - return Response(status=status.HTTP_200_OK) + return Response(status=status.HTTP_204_NO_CONTENT) except Exception as e: capture_exception(e) return Response( diff --git a/apiserver/plane/api/views/workspace.py b/apiserver/plane/api/views/workspace.py index ce425185e6e..dee37847fb5 100644 --- a/apiserver/plane/api/views/workspace.py +++ b/apiserver/plane/api/views/workspace.py @@ -532,7 +532,7 @@ def create(self, request): # Delete joined workspace invites workspace_invitations.delete() - return Response(status=status.HTTP_200_OK) + return Response(status=status.HTTP_204_NO_CONTENT) except Exception as e: capture_exception(e) return Response( @@ -846,7 +846,7 @@ def post(self, request, slug): workspace_member.view_props = request.data.get("view_props", {}) workspace_member.save() - return Response(status=status.HTTP_200_OK) + return Response(status=status.HTTP_204_NO_CONTENT) except WorkspaceMember.DoesNotExist: return Response( {"error": "User not a member of workspace"},