From 5f6e2949af4ce45fddb9b7ad8869ccff8ecb0cdb Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Tue, 12 Sep 2023 17:54:25 +0530 Subject: [PATCH 1/2] eslint fixes --- packages/eslint-config-custom/index.js | 1 + space/.eslintrc.js | 3 --- space/package.json | 1 + web/.eslintrc.js | 3 --- 4 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/eslint-config-custom/index.js b/packages/eslint-config-custom/index.js index d31a7640602..b3615fc13dd 100644 --- a/packages/eslint-config-custom/index.js +++ b/packages/eslint-config-custom/index.js @@ -16,5 +16,6 @@ module.exports = { "no-duplicate-imports": "error", "arrow-body-style": ["error", "as-needed"], "react/self-closing-comp": ["error", { component: true, html: true }], + "@next/next/no-img-element": "off", }, }; diff --git a/space/.eslintrc.js b/space/.eslintrc.js index 38e6a5f4c82..c8df607506c 100644 --- a/space/.eslintrc.js +++ b/space/.eslintrc.js @@ -1,7 +1,4 @@ module.exports = { root: true, extends: ["custom"], - rules: { - "@next/next/no-img-element": "off", - }, }; diff --git a/space/package.json b/space/package.json index 768abb8ffc7..f2bb39df695 100644 --- a/space/package.json +++ b/space/package.json @@ -69,6 +69,7 @@ "@types/react": "18.0.28", "@types/react-dom": "18.0.11", "@types/uuid": "^9.0.1", + "@typescript-eslint/eslint-plugin": "^5.48.2", "autoprefixer": "^10.4.13", "eslint": "8.34.0", "eslint-config-custom": "*", diff --git a/web/.eslintrc.js b/web/.eslintrc.js index 38e6a5f4c82..c8df607506c 100644 --- a/web/.eslintrc.js +++ b/web/.eslintrc.js @@ -1,7 +1,4 @@ module.exports = { root: true, extends: ["custom"], - rules: { - "@next/next/no-img-element": "off", - }, }; From e900a5e39acabacfc431c286dd76d902b6bca5cf Mon Sep 17 00:00:00 2001 From: sriram veeraghanta Date: Wed, 13 Sep 2023 12:05:26 +0530 Subject: [PATCH 2/2] lint rules added --- packages/eslint-config-custom/index.js | 1 + space/components/accounts/email-password-form.tsx | 3 --- space/pages/onboarding/index.tsx | 6 ------ 3 files changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/eslint-config-custom/index.js b/packages/eslint-config-custom/index.js index b3615fc13dd..82be6537692 100644 --- a/packages/eslint-config-custom/index.js +++ b/packages/eslint-config-custom/index.js @@ -17,5 +17,6 @@ module.exports = { "arrow-body-style": ["error", "as-needed"], "react/self-closing-comp": ["error", { component: true, html: true }], "@next/next/no-img-element": "off", + "@typescript-eslint/no-unused-vars": ["warn"], }, }; diff --git a/space/components/accounts/email-password-form.tsx b/space/components/accounts/email-password-form.tsx index 23742eefe15..b00740a15c0 100644 --- a/space/components/accounts/email-password-form.tsx +++ b/space/components/accounts/email-password-form.tsx @@ -1,9 +1,6 @@ import React, { useState } from "react"; - import { useRouter } from "next/router"; import Link from "next/link"; - -// react hook form import { useForm } from "react-hook-form"; // components import { EmailResetPasswordForm } from "./email-reset-password-form"; diff --git a/space/pages/onboarding/index.tsx b/space/pages/onboarding/index.tsx index 5cb168d3883..e7ed35222ab 100644 --- a/space/pages/onboarding/index.tsx +++ b/space/pages/onboarding/index.tsx @@ -2,10 +2,6 @@ import React, { useEffect } from "react"; // mobx import { observer } from "mobx-react-lite"; import { useMobxStore } from "lib/mobx/store-provider"; -// services -import authenticationService from "services/authentication.service"; -// hooks -import useToast from "hooks/use-toast"; // components import { OnBoardingForm } from "components/accounts/onboarding-form"; @@ -16,8 +12,6 @@ const OnBoardingPage = () => { const user = userStore?.currentUser; - const { setToastAlert } = useToast(); - useEffect(() => { const user = userStore?.currentUser;