From 14469710f26696dc4e06c91d6a9f1fb0b10428d1 Mon Sep 17 00:00:00 2001
From: "Muhamade Sabith .T.U" <mstuzombi@gmail.com>
Date: Tue, 7 Nov 2023 17:47:06 +0530
Subject: [PATCH 1/2] fix: all issues values are not changeable and assignee
 image not rendering

---
 .../issue-layouts/properties/assignee.tsx       | 17 ++++++++++++-----
 .../roots/global-view-layout-root.tsx           |  4 ++--
 2 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/web/components/issues/issue-layouts/properties/assignee.tsx b/web/components/issues/issue-layouts/properties/assignee.tsx
index b436e274f9b..35f291b724f 100644
--- a/web/components/issues/issue-layouts/properties/assignee.tsx
+++ b/web/components/issues/issue-layouts/properties/assignee.tsx
@@ -49,7 +49,7 @@ export const IssuePropertyAssignee: React.FC<IIssuePropertyAssignee> = observer(
   const [popperElement, setPopperElement] = useState<HTMLDivElement | null>(null);
   const [isLoading, setIsLoading] = useState<Boolean>(false);
 
-  const projectMembers = projectId ? projectStore?.members?.[projectId] : undefined;
+  const workspaceMembers = workspaceSlug ? workspaceStore?.workspaceMembers : undefined;
 
   const fetchProjectMembers = () => {
     setIsLoading(true);
@@ -59,7 +59,13 @@ export const IssuePropertyAssignee: React.FC<IIssuePropertyAssignee> = observer(
         projectStore.fetchProjectMembers(workspaceSlug, projectId).then(() => setIsLoading(false));
   };
 
-  const options = (projectMembers ?? [])?.map((member) => ({
+  const fetchWorkspaceMembers = () => {
+    setIsLoading(true);
+    if (workspaceSlug)
+      workspaceSlug && workspaceStore.fetchWorkspaceMembers(workspaceSlug).then(() => setIsLoading(false));
+  };
+
+  const options = (workspaceMembers ?? [])?.map((member) => ({
     value: member.member.id,
     query: member.member.display_name,
     content: (
@@ -78,7 +84,7 @@ export const IssuePropertyAssignee: React.FC<IIssuePropertyAssignee> = observer(
       tooltipHeading="Assignee"
       tooltipContent={
         value && value.length > 0
-          ? (projectMembers ? projectMembers : [])
+          ? (workspaceMembers ? workspaceMembers : [])
               ?.filter((m) => value.includes(m.member.display_name))
               .map((m) => m.member.display_name)
               .join(", ")
@@ -90,8 +96,9 @@ export const IssuePropertyAssignee: React.FC<IIssuePropertyAssignee> = observer(
         {value && value.length > 0 && Array.isArray(value) ? (
           <AvatarGroup showTooltip={false}>
             {value.map((assigneeId) => {
-              const member = projectMembers?.find((m) => m.member.id === assigneeId)?.member;
+              const member = workspaceMembers?.find((m) => m.member.id === assigneeId)?.member;
 
+              console.log("member : " + member);
               if (!member) return null;
 
               return <Avatar key={member.id} name={member.display_name} src={member.avatar} />;
@@ -134,7 +141,7 @@ export const IssuePropertyAssignee: React.FC<IIssuePropertyAssignee> = observer(
           className={`flex items-center justify-between gap-1 w-full text-xs ${
             disabled ? "cursor-not-allowed text-custom-text-200" : "cursor-pointer hover:bg-custom-background-80"
           } ${buttonClassName}`}
-          onClick={() => !projectMembers && fetchProjectMembers()}
+          onClick={() => !workspaceMembers && fetchWorkspaceMembers()}
         >
           {label}
           {!hideDropdownArrow && !disabled && <ChevronDown className="h-3 w-3" aria-hidden="true" />}
diff --git a/web/components/issues/issue-layouts/roots/global-view-layout-root.tsx b/web/components/issues/issue-layouts/roots/global-view-layout-root.tsx
index 018a63d2aa6..62fa04e1a90 100644
--- a/web/components/issues/issue-layouts/roots/global-view-layout-root.tsx
+++ b/web/components/issues/issue-layouts/roots/global-view-layout-root.tsx
@@ -65,14 +65,14 @@ export const GlobalViewLayoutRoot: React.FC<Props> = observer((props) => {
 
   const handleUpdateIssue = useCallback(
     (issue: IIssue, data: Partial<IIssue>) => {
-      if (!workspaceSlug || !globalViewId) return;
+      if (!workspaceSlug) return;
 
       const payload = {
         ...issue,
         ...data,
       };
 
-      globalViewIssuesStore.updateIssueStructure(globalViewId.toString(), payload);
+      globalViewIssuesStore.updateIssueStructure(type ?? globalViewId!.toString(), payload);
       issueDetailStore.updateIssue(workspaceSlug.toString(), issue.project, issue.id, data);
     },
     [globalViewId, globalViewIssuesStore, workspaceSlug, issueDetailStore]

From 27ea0d9beb321fb8456a56d29cd23a7edde1254a Mon Sep 17 00:00:00 2001
From: "Muhamade Sabith .T.U" <mstuzombi@gmail.com>
Date: Wed, 8 Nov 2023 11:10:10 +0530
Subject: [PATCH 2/2] chore: removed console log

---
 web/components/issues/issue-layouts/properties/assignee.tsx | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/web/components/issues/issue-layouts/properties/assignee.tsx b/web/components/issues/issue-layouts/properties/assignee.tsx
index 35f291b724f..4c14ccabcfb 100644
--- a/web/components/issues/issue-layouts/properties/assignee.tsx
+++ b/web/components/issues/issue-layouts/properties/assignee.tsx
@@ -97,10 +97,7 @@ export const IssuePropertyAssignee: React.FC<IIssuePropertyAssignee> = observer(
           <AvatarGroup showTooltip={false}>
             {value.map((assigneeId) => {
               const member = workspaceMembers?.find((m) => m.member.id === assigneeId)?.member;
-
-              console.log("member : " + member);
               if (!member) return null;
-
               return <Avatar key={member.id} name={member.display_name} src={member.avatar} />;
             })}
           </AvatarGroup>