From 2f3fe3c5063ba8874ab1c3196d14ad47268999b3 Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia Date: Wed, 8 Nov 2023 14:50:29 +0530 Subject: [PATCH 1/3] style: create/update issue modal properties ui improvement --- .../ui/src/dropdowns/custom-search-select.tsx | 4 +-- packages/ui/src/dropdowns/custom-select.tsx | 4 +-- web/components/issues/form.tsx | 35 +++++++++---------- web/components/issues/select/assignee.tsx | 9 +++-- web/components/issues/select/cycle.tsx | 16 ++++----- web/components/issues/select/date.tsx | 11 +++--- web/components/issues/select/estimate.tsx | 6 ++-- web/components/issues/select/label.tsx | 8 ++--- web/components/issues/select/module.tsx | 26 +++++--------- web/components/issues/select/priority.tsx | 8 ++--- web/components/issues/select/state.tsx | 8 ++--- web/components/ui/labels-list.tsx | 2 +- 12 files changed, 59 insertions(+), 78 deletions(-) diff --git a/packages/ui/src/dropdowns/custom-search-select.tsx b/packages/ui/src/dropdowns/custom-search-select.tsx index 8ba95c28cc6..3f1e503a8a0 100644 --- a/packages/ui/src/dropdowns/custom-search-select.tsx +++ b/packages/ui/src/dropdowns/custom-search-select.tsx @@ -87,8 +87,8 @@ export const CustomSearchSelect = (props: ICustomSearchSelectProps) => { } + placement="bottom-start" > {watch("parent") ? ( <> @@ -599,7 +598,7 @@ export const IssueForm: FC = observer((props) => { -
+
setCreateMore((prevData) => !prevData)} diff --git a/web/components/issues/select/assignee.tsx b/web/components/issues/select/assignee.tsx index 4d7ec27dfb9..8778c6c6208 100644 --- a/web/components/issues/select/assignee.tsx +++ b/web/components/issues/select/assignee.tsx @@ -3,8 +3,7 @@ import useSWR from "swr"; // services import { ProjectService } from "services/project"; // ui -import { Avatar, AvatarGroup, CustomSearchSelect } from "@plane/ui"; -import { User2 } from "lucide-react"; +import { Avatar, AvatarGroup, CustomSearchSelect, UserGroupIcon } from "@plane/ui"; // fetch-keys import { PROJECT_MEMBERS } from "constants/fetch-keys"; @@ -58,9 +57,9 @@ export const IssueAssigneeSelect: React.FC = ({ projectId, value = [], on
) : ( -
- - Assignee +
+ + Assignee
)}
diff --git a/web/components/issues/select/cycle.tsx b/web/components/issues/select/cycle.tsx index 3df4948a7c4..742774851a4 100644 --- a/web/components/issues/select/cycle.tsx +++ b/web/components/issues/select/cycle.tsx @@ -55,17 +55,15 @@ export const IssueCycleSelect: React.FC = observer((props query === "" ? options : options?.filter((option) => option.query.toLowerCase().includes(query.toLowerCase())); const label = selectedCycle ? ( -
- - - +
+
{selectedCycle.name}
) : ( - <> +
- Select Cycle - + Cycle +
); return ( @@ -80,9 +78,7 @@ export const IssueCycleSelect: React.FC = observer((props ) : ( <> - - {label} + + {label} )}
diff --git a/web/components/issues/select/estimate.tsx b/web/components/issues/select/estimate.tsx index f2d8750728e..f3da8a12ab9 100644 --- a/web/components/issues/select/estimate.tsx +++ b/web/components/issues/select/estimate.tsx @@ -21,9 +21,9 @@ export const IssueEstimateSelect: React.FC = ({ value, onChange }) => { - - +
+ + {estimatePoints?.find((e) => e.key === value)?.value ?? "Estimate"}
diff --git a/web/components/issues/select/label.tsx b/web/components/issues/select/label.tsx index 47b1d4e5b02..a85b073ebb3 100644 --- a/web/components/issues/select/label.tsx +++ b/web/components/issues/select/label.tsx @@ -68,10 +68,10 @@ export const IssueLabelSelect: React.FC = ({ setIsOpen, value, onChange, />
) : ( - - - Label - +
+ + Label +
)}
diff --git a/web/components/issues/select/module.tsx b/web/components/issues/select/module.tsx index c0d9c6c4c3b..cb9d6252bbc 100644 --- a/web/components/issues/select/module.tsx +++ b/web/components/issues/select/module.tsx @@ -55,34 +55,24 @@ export const IssueModuleSelect: React.FC = observer((pro query === "" ? options : options?.filter((option) => option.query.toLowerCase().includes(query.toLowerCase())); const label = selectedModule ? ( -
- - - -
{selectedModule.name}
+
+ + {selectedModule.name}
) : ( - <> +
- Select Module - + Module +
); return ( - onChange(val)} - disabled={false} - > + onChange(val)}>
setCreateMore((prevData) => !prevData)} > +
+ {}} size="sm" /> +
Create more - {}} size="md" />
- From 7d57f78f1630fce071d28643d29fbdeb24115e53 Mon Sep 17 00:00:00 2001 From: Anmol Singh Bhatia Date: Wed, 8 Nov 2023 16:27:31 +0530 Subject: [PATCH 3/3] style: modal ui consistency --- web/components/cycles/form.tsx | 2 +- web/components/issues/modal.tsx | 2 +- web/components/modules/select/lead.tsx | 8 +++-- web/components/modules/select/members.tsx | 6 ++-- .../project/create-project-modal.tsx | 6 ++-- web/components/ui/date.tsx | 31 +++++++++---------- web/components/views/form.tsx | 2 +- web/components/workspace/member-select.tsx | 7 ++--- 8 files changed, 32 insertions(+), 32 deletions(-) diff --git a/web/components/cycles/form.tsx b/web/components/cycles/form.tsx index b262edb1519..7189b2fea76 100644 --- a/web/components/cycles/form.tsx +++ b/web/components/cycles/form.tsx @@ -135,7 +135,7 @@ export const CycleForm: React.FC = (props) => {
-
+
diff --git a/web/components/issues/modal.tsx b/web/components/issues/modal.tsx index 4bd6fc9b257..12f9074540d 100644 --- a/web/components/issues/modal.tsx +++ b/web/components/issues/modal.tsx @@ -324,7 +324,7 @@ export const CreateUpdateIssueModal: React.FC = observer((prop leaveFrom="opacity-100 translate-y-0 sm:scale-100" leaveTo="opacity-0 translate-y-4 sm:translate-y-0 sm:scale-95" > - + = ({ value, onChange }) => { {selectedOption ? ( ) : ( - + + )} + {selectedOption ? ( + selectedOption?.display_name + ) : ( + Lead )} - {selectedOption ? selectedOption?.display_name : Lead}
} onChange={onChange} diff --git a/web/components/modules/select/members.tsx b/web/components/modules/select/members.tsx index 94c74f05bb8..17b80a4715e 100644 --- a/web/components/modules/select/members.tsx +++ b/web/components/modules/select/members.tsx @@ -55,9 +55,9 @@ export const ModuleMembersSelect: React.FC = ({ value, onChange }) => { {value.length} Assignees
) : ( -
- - Assignee +
+ + Assignee
)}
diff --git a/web/components/project/create-project-modal.tsx b/web/components/project/create-project-modal.tsx index 6be880dcbfb..ff89af2c798 100644 --- a/web/components/project/create-project-modal.tsx +++ b/web/components/project/create-project-modal.tsx @@ -265,7 +265,7 @@ export const CreateProjectModal: FC = observer((props) => { onChange={handleNameChange(onChange)} hasError={Boolean(errors.name)} placeholder="Project Title" - className="w-full" + className="w-full focus:border-blue-400" /> )} /> @@ -298,7 +298,7 @@ export const CreateProjectModal: FC = observer((props) => { onChange={handleIdentifierChange(onChange)} hasError={Boolean(errors.identifier)} placeholder="Identifier" - className="text-xs w-full" + className="text-xs w-full focus:border-blue-400" /> )} /> @@ -316,7 +316,7 @@ export const CreateProjectModal: FC = observer((props) => { tabIndex={3} placeholder="Description..." onChange={onChange} - className="text-sm !h-24" + className="text-sm !h-24 focus:border-blue-400" hasError={Boolean(errors?.description)} /> )} diff --git a/web/components/ui/date.tsx b/web/components/ui/date.tsx index 31cbdc9fd5d..acc8eb1eac8 100644 --- a/web/components/ui/date.tsx +++ b/web/components/ui/date.tsx @@ -21,22 +21,21 @@ export const DateSelect: React.FC = ({ value, onChange, label, minDate, m {({ close }) => ( <> - - - {value ? ( - <> - {renderShortDateWithYearFormat(value)} - - - ) : ( - <> - - {label} - - )} - + + {value ? ( + <> + + {renderShortDateWithYearFormat(value)} + + + ) : ( + <> + + {label} + + )} = observer(({ handleFormSubmit, ha onChange={onChange} hasError={Boolean(errors.name)} placeholder="Title" - className="resize-none text-xl" + className="resize-none w-full text-xl focus:border-blue-400" /> )} /> diff --git a/web/components/workspace/member-select.tsx b/web/components/workspace/member-select.tsx index 3ba1cbd899f..bae16de015f 100644 --- a/web/components/workspace/member-select.tsx +++ b/web/components/workspace/member-select.tsx @@ -48,10 +48,7 @@ export const WorkspaceMemberSelect: FC = (props) => { : options?.filter((option) => option.member.display_name.toLowerCase().includes(query.toLowerCase())); const label = ( -
+
{value ? ( <> @@ -81,7 +78,7 @@ export const WorkspaceMemberSelect: FC = (props) => {