From 758fecf187f9e83d8f38a4fb9692a5363de5dc16 Mon Sep 17 00:00:00 2001 From: rahulramesha Date: Wed, 24 Jul 2024 18:18:55 +0530 Subject: [PATCH] fix view update button if no filters are applied --- .../filters/applied-filters/roots/global-view-root.tsx | 3 ++- .../filters/applied-filters/roots/project-view-root.tsx | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/web/core/components/issues/issue-layouts/filters/applied-filters/roots/global-view-root.tsx b/web/core/components/issues/issue-layouts/filters/applied-filters/roots/global-view-root.tsx index b8dfede358b..b898122e9ab 100644 --- a/web/core/components/issues/issue-layouts/filters/applied-filters/roots/global-view-root.tsx +++ b/web/core/components/issues/issue-layouts/filters/applied-filters/roots/global-view-root.tsx @@ -117,7 +117,8 @@ export const GlobalViewsAppliedFiltersRoot = observer((props: Props) => { }); }; - const areFiltersEqual = getAreFiltersEqual(appliedFilters, issueFilters, viewDetails); + // add a placeholder object instead of appliedFilters if it is undefined + const areFiltersEqual = getAreFiltersEqual(appliedFilters ?? {}, issueFilters, viewDetails); const isAuthorizedUser = !!currentWorkspaceRole && currentWorkspaceRole >= EUserWorkspaceRoles.MEMBER; diff --git a/web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-view-root.tsx b/web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-view-root.tsx index cb35cae849b..9772d7c27b8 100644 --- a/web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-view-root.tsx +++ b/web/core/components/issues/issue-layouts/filters/applied-filters/roots/project-view-root.tsx @@ -91,7 +91,8 @@ export const ProjectViewAppliedFiltersRoot: React.FC = observer(() => { ); }; - const areFiltersEqual = getAreFiltersEqual(appliedFilters, issueFilters, viewDetails); + // add a placeholder object instead of appliedFilters if it is undefined + const areFiltersEqual = getAreFiltersEqual(appliedFilters ?? {}, issueFilters, viewDetails); const viewFilters = { filters: cloneDeep(appliedFilters ?? {}), display_filters: cloneDeep(issueFilters?.displayFilters),