From 7344ae1fea06fea1029fbcb3c2695de91ca4018e Mon Sep 17 00:00:00 2001
From: Anmol Singh Bhatia <anmolsinghbhatia@plane.so>
Date: Thu, 22 Aug 2024 17:14:51 +0530
Subject: [PATCH 1/2] fix: email notification validation

---
 .../profile/notification/email-notification-form.tsx       | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/web/core/components/profile/notification/email-notification-form.tsx b/web/core/components/profile/notification/email-notification-form.tsx
index 4166634a9d3..f7d5449826b 100644
--- a/web/core/components/profile/notification/email-notification-form.tsx
+++ b/web/core/components/profile/notification/email-notification-form.tsx
@@ -23,9 +23,8 @@ export const EmailNotificationForm: FC<IEmailNotificationFormProps> = (props) =>
     handleSubmit,
     watch,
     control,
-    setValue,
     reset,
-    formState: { isSubmitting, isDirty, dirtyFields },
+    formState: { isSubmitting, dirtyFields },
   } = useForm<IUserEmailNotificationSettings>({
     defaultValues: {
       ...data,
@@ -93,9 +92,7 @@ export const EmailNotificationForm: FC<IEmailNotificationFormProps> = (props) =>
               render={({ field: { value, onChange } }) => (
                 <Checkbox
                   checked={value}
-                  indeterminate={!value && watch("issue_completed")}
                   onChange={() => {
-                    setValue("issue_completed", !value, { shouldDirty: true });
                     onChange(!value);
                   }}
                   containerClassName="mx-2"
@@ -155,7 +152,7 @@ export const EmailNotificationForm: FC<IEmailNotificationFormProps> = (props) =>
         </div>
       </div>
       <div className="flex items-center py-12">
-        <Button variant="primary" onClick={handleSubmit(onSubmit)} loading={isSubmitting} disabled={!isDirty}>
+        <Button variant="primary" onClick={handleSubmit(onSubmit)} loading={isSubmitting}>
           {isSubmitting ? "Saving..." : "Save changes"}
         </Button>
       </div>

From c2486a1be4beab675c26099af3d5765002ee96e5 Mon Sep 17 00:00:00 2001
From: Anmol Singh Bhatia <anmolsinghbhatia@plane.so>
Date: Thu, 22 Aug 2024 17:22:13 +0530
Subject: [PATCH 2/2] chore: code refactor

---
 .../components/profile/notification/email-notification-form.tsx  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/web/core/components/profile/notification/email-notification-form.tsx b/web/core/components/profile/notification/email-notification-form.tsx
index f7d5449826b..990ade067af 100644
--- a/web/core/components/profile/notification/email-notification-form.tsx
+++ b/web/core/components/profile/notification/email-notification-form.tsx
@@ -21,7 +21,6 @@ export const EmailNotificationForm: FC<IEmailNotificationFormProps> = (props) =>
   // form data
   const {
     handleSubmit,
-    watch,
     control,
     reset,
     formState: { isSubmitting, dirtyFields },