From 694d27cf894a6305962b6bd2b1cb1126c6734924 Mon Sep 17 00:00:00 2001 From: Prateek Shourya Date: Wed, 28 Aug 2024 15:30:20 +0530 Subject: [PATCH 1/4] [WEB-2332] fix: application layout and minor UI improvements. --- web/core/components/issues/peek-overview/view.tsx | 2 +- web/styles/globals.css | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/web/core/components/issues/peek-overview/view.tsx b/web/core/components/issues/peek-overview/view.tsx index f71b21b0649..c03582979c1 100644 --- a/web/core/components/issues/peek-overview/view.tsx +++ b/web/core/components/issues/peek-overview/view.tsx @@ -104,7 +104,7 @@ export const IssueView: FC = observer((props) => { ? "fixed z-20 flex flex-col overflow-hidden rounded border border-custom-border-200 bg-custom-background-100 transition-all duration-300" : `w-full h-full`, !embedIssue && { - "bottom-0 right-0 top-0 w-full md:w-[50%]": peekMode === "side-peek", + "bottom-0 right-0 top-0 w-full md:w-[50%] border-0 border-l": peekMode === "side-peek", "size-5/6 top-[8.33%] left-[8.33%]": peekMode === "modal", "inset-0 m-4": peekMode === "full-screen", } diff --git a/web/styles/globals.css b/web/styles/globals.css index 43441604522..76f429a2861 100644 --- a/web/styles/globals.css +++ b/web/styles/globals.css @@ -359,12 +359,6 @@ body { color: rgba(var(--color-text-100)); } -.app-container { - contain: layout style size; - contain-intrinsic-size: 100%; - position: relative; /* Ensure it's the containing block */ -} - /* scrollbar style */ ::-webkit-scrollbar { display: none; From 688db871722e09d4153c1c6ddf4d468f4803bf79 Mon Sep 17 00:00:00 2001 From: Prateek Shourya Date: Wed, 4 Sep 2024 15:14:43 +0530 Subject: [PATCH 2/4] [WEB-2332] fix: revert back layout changes. --- web/app/layout.tsx | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/web/app/layout.tsx b/web/app/layout.tsx index a5a02c70792..683c450ab89 100644 --- a/web/app/layout.tsx +++ b/web/app/layout.tsx @@ -72,12 +72,10 @@ export default function RootLayout({ children }: { children: React.ReactNode }) crossOrigin="use-credentials" /> - + +
-
-
-
{children}
-
+
{children}
{process.env.NEXT_PUBLIC_PLAUSIBLE_DOMAIN && ( From 4f4cf53e812e778915618387c3997f39f807fe91 Mon Sep 17 00:00:00 2001 From: Prateek Shourya Date: Wed, 4 Sep 2024 15:44:00 +0530 Subject: [PATCH 3/4] fix: lint error. --- web/core/components/workspace-notifications/sidebar/root.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/core/components/workspace-notifications/sidebar/root.tsx b/web/core/components/workspace-notifications/sidebar/root.tsx index 753826d3fd1..9612d85605c 100644 --- a/web/core/components/workspace-notifications/sidebar/root.tsx +++ b/web/core/components/workspace-notifications/sidebar/root.tsx @@ -4,7 +4,7 @@ import { FC } from "react"; import { observer } from "mobx-react"; import { useParams } from "next/navigation"; // components -import { CustomHeader, CustomRow, EHeaderVariant, ERowVariant } from "@plane/ui"; +import { CustomHeader, CustomRow, EHeaderVariant } from "@plane/ui"; import { CountChip } from "@/components/common"; import { NotificationsLoader, From bd1824b36da556a5393a47ee0b51bff9ed1d8826 Mon Sep 17 00:00:00 2001 From: Prateek Shourya Date: Wed, 4 Sep 2024 15:57:39 +0530 Subject: [PATCH 4/4] fix: lint errors. --- web/core/components/issues/filters.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/web/core/components/issues/filters.tsx b/web/core/components/issues/filters.tsx index a270982eef1..ad866870739 100644 --- a/web/core/components/issues/filters.tsx +++ b/web/core/components/issues/filters.tsx @@ -1,7 +1,6 @@ "use client"; import { useCallback, useState } from "react"; -import { TProject } from "ee/types"; // types import { IIssueDisplayFilterOptions, IIssueDisplayProperties, IIssueFilterOptions } from "@plane/types"; // ui @@ -19,6 +18,9 @@ import { import { isIssueFilterActive } from "@/helpers/filter.helper"; // hooks import { useLabel, useProjectState, useMember, useIssues } from "@/hooks/store"; +// plane web types +import { TProject } from "@/plane-web/types"; +// local components import { ProjectAnalyticsModal } from "../analytics"; type Props = {