From f2dd91231d76d8b15b7993283ec19627818b6921 Mon Sep 17 00:00:00 2001 From: gakshita Date: Mon, 9 Sep 2024 19:11:46 +0530 Subject: [PATCH 1/3] fix: project features modal padding --- web/core/components/project/project-feature-update.tsx | 6 +++--- web/core/components/project/settings/features-list.tsx | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/web/core/components/project/project-feature-update.tsx b/web/core/components/project/project-feature-update.tsx index 8b990270893..ff10271d82c 100644 --- a/web/core/components/project/project-feature-update.tsx +++ b/web/core/components/project/project-feature-update.tsx @@ -4,7 +4,7 @@ import React, { FC } from "react"; import { observer } from "mobx-react"; import Link from "next/link"; // ui -import { Button, getButtonStyling } from "@plane/ui"; +import { Button, getButtonStyling, Row } from "@plane/ui"; // components import { Logo } from "@/components/common"; import { ProjectFeaturesList } from "@/components/project/settings"; @@ -28,9 +28,9 @@ export const ProjectFeatureUpdate: FC = observer((props) => { return ( <> -
+ -
+
Congrats! Project {" "} diff --git a/web/core/components/project/settings/features-list.tsx b/web/core/components/project/settings/features-list.tsx index e0b966ddac0..91eb188024d 100644 --- a/web/core/components/project/settings/features-list.tsx +++ b/web/core/components/project/settings/features-list.tsx @@ -61,7 +61,7 @@ export const ProjectFeaturesList: FC = observer((props) => { const feature = PROJECT_FEATURES_LIST[featureSectionKey]; return (
-
+

{feature.title}

{feature.description}

From f5143dab86058dfc61fe4a87ed2b988e9fa1bcf3 Mon Sep 17 00:00:00 2001 From: gakshita Date: Mon, 9 Sep 2024 20:37:56 +0530 Subject: [PATCH 2/3] fix: minor ui inconsistencies --- web/core/components/cycles/list/root.tsx | 2 +- web/core/components/dropdowns/module/index.tsx | 12 ++++++++++-- .../components/issues/issue-detail/module-select.tsx | 1 + 3 files changed, 12 insertions(+), 3 deletions(-) diff --git a/web/core/components/cycles/list/root.tsx b/web/core/components/cycles/list/root.tsx index 880ed62c6fb..17482c7d669 100644 --- a/web/core/components/cycles/list/root.tsx +++ b/web/core/components/cycles/list/root.tsx @@ -19,7 +19,7 @@ export const CyclesList: FC = observer((props) => { const { completedCycleIds, upcomingCycleIds, cycleIds, workspaceSlug, projectId, isArchived = false } = props; return ( - + {isArchived ? ( <> diff --git a/web/core/components/dropdowns/module/index.tsx b/web/core/components/dropdowns/module/index.tsx index c4cb660d212..f4a46a1e274 100644 --- a/web/core/components/dropdowns/module/index.tsx +++ b/web/core/components/dropdowns/module/index.tsx @@ -27,6 +27,7 @@ type Props = TDropdownProps & { showCount?: boolean; onClose?: () => void; renderByDefault?: boolean; + itemClassName?: string; } & ( | { multiple: false; @@ -51,6 +52,7 @@ type ButtonContentProps = { showCount: boolean; showTooltip?: boolean; value: string | string[] | null; + className?: string; }; const ButtonContent: React.FC = (props) => { @@ -65,6 +67,7 @@ const ButtonContent: React.FC = (props) => { showCount, showTooltip = false, value, + className, } = props; // store hooks const { getModuleById } = useModule(); @@ -87,13 +90,16 @@ const ButtonContent: React.FC = (props) => { )}
) : value.length > 0 ? ( -
+
{value.map((moduleId) => { const moduleDetails = getModuleById(moduleId); return (
{!hideIcon && } {!hideText && ( @@ -159,6 +165,7 @@ export const ModuleDropdown: React.FC = observer((props) => { const { button, buttonClassName, + itemClassName = "", buttonContainerClassName, buttonVariant, className = "", @@ -270,6 +277,7 @@ export const ModuleDropdown: React.FC = observer((props) => { showTooltip={showTooltip} value={value} onChange={onChange as any} + className={itemClassName} /> diff --git a/web/core/components/issues/issue-detail/module-select.tsx b/web/core/components/issues/issue-detail/module-select.tsx index 2856d09bd8d..c51e8848191 100644 --- a/web/core/components/issues/issue-detail/module-select.tsx +++ b/web/core/components/issues/issue-detail/module-select.tsx @@ -69,6 +69,7 @@ export const IssueModuleSelect: React.FC = observer((props) dropdownArrow dropdownArrowClassName="h-3.5 w-3.5 hidden group-hover:inline" multiple + itemClassName="px-2" />
); From f179e73020cbdce01c6ce3f7a576b6c4f14c841c Mon Sep 17 00:00:00 2001 From: gakshita Date: Tue, 10 Sep 2024 13:16:59 +0530 Subject: [PATCH 3/3] fix: lint issue --- web/core/store/issue/issue.store.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/core/store/issue/issue.store.ts b/web/core/store/issue/issue.store.ts index f94188e6416..ed4ecc4d576 100644 --- a/web/core/store/issue/issue.store.ts +++ b/web/core/store/issue/issue.store.ts @@ -1,6 +1,6 @@ -import update from "lodash/update"; import isEmpty from "lodash/isEmpty"; import set from "lodash/set"; +import update from "lodash/update"; import { action, makeObservable, observable, runInAction } from "mobx"; import { computedFn } from "mobx-utils"; // types