From ba2d388581a36dde327e09a01ec55e7c0e1e2a6d Mon Sep 17 00:00:00 2001 From: sharma01ketan Date: Mon, 9 Sep 2024 14:53:28 +0530 Subject: [PATCH 1/5] changes for list and kanban --- web/core/components/dropdowns/date.tsx | 5 ++++- web/core/components/dropdowns/member/index.tsx | 1 + web/core/components/dropdowns/member/member-options.tsx | 7 +++++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/web/core/components/dropdowns/date.tsx b/web/core/components/dropdowns/date.tsx index 1977d066205..e087906cc81 100644 --- a/web/core/components/dropdowns/date.tsx +++ b/web/core/components/dropdowns/date.tsx @@ -156,7 +156,10 @@ export const DateDropdown: React.FC = (props) => { createPortal(
= observer((props) => { {isOpen && ( { - const { projectId, referenceElement, placement, isOpen } = props; + const { projectId, referenceElement, placement, isOpen, className="" } = props; // states const [query, setQuery] = useState(""); const [popperElement, setPopperElement] = useState(null); @@ -88,7 +90,8 @@ export const MemberOptions = observer((props: Props) => { return createPortal(
Date: Mon, 9 Sep 2024 14:54:41 +0530 Subject: [PATCH 2/5] passing values for list and kanban --- .../issues/issue-layouts/properties/all-properties.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/web/core/components/issues/issue-layouts/properties/all-properties.tsx b/web/core/components/issues/issue-layouts/properties/all-properties.tsx index baa7dfc09a1..64306e3331e 100644 --- a/web/core/components/issues/issue-layouts/properties/all-properties.tsx +++ b/web/core/components/issues/issue-layouts/properties/all-properties.tsx @@ -328,6 +328,7 @@ export const IssueProperties: React.FC = observer((props) => { icon={} buttonVariant={issue.start_date ? "border-with-text" : "border-without-text"} disabled={isReadOnly} + className="z-10" showTooltip />
@@ -346,6 +347,7 @@ export const IssueProperties: React.FC = observer((props) => { buttonClassName={shouldHighlightIssueDueDate(issue.target_date, stateDetails?.group) ? "text-red-500" : ""} clearIconClassName="!text-custom-text-100" disabled={isReadOnly} + className="z-10" showTooltip />
@@ -364,6 +366,7 @@ export const IssueProperties: React.FC = observer((props) => { buttonClassName={issue.assignee_ids?.length > 0 ? "hover:bg-transparent px-0" : ""} showTooltip={issue?.assignee_ids?.length === 0} placeholder="Assignees" + className="z-10" tooltipContent="" /> From 68f3445db851254661d730b31cf1520348ca953f Mon Sep 17 00:00:00 2001 From: sharma01ketan Date: Mon, 9 Sep 2024 14:55:24 +0530 Subject: [PATCH 3/5] spreadsheet changes --- .../issues/issue-layouts/spreadsheet/columns/assignee-column.tsx | 1 + .../issues/issue-layouts/spreadsheet/columns/due-date-column.tsx | 1 + .../issue-layouts/spreadsheet/columns/start-date-column.tsx | 1 + 3 files changed, 3 insertions(+) diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx index cf71f2436d9..bc2866f5499 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx @@ -38,6 +38,7 @@ export const SpreadsheetAssigneeColumn: React.FC = observer((props: Props } buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10" buttonContainerClassName="w-full" + className="z-9" onClose={onClose} /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx index f0c43a4573b..6a554853cf6 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx @@ -53,6 +53,7 @@ export const SpreadsheetDueDateColumn: React.FC = observer((props: Props) "text-red-500": shouldHighlightIssueDueDate(issue.target_date, stateDetails?.group), } )} + className="z-9" clearIconClassName="!text-custom-text-100" onClose={onClose} /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx index 9a17d34d4d2..105feb7ddcc 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx @@ -40,6 +40,7 @@ export const SpreadsheetStartDateColumn: React.FC = observer((props: Prop buttonVariant="transparent-with-text" buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10" buttonContainerClassName="w-full" + className="z-9" onClose={onClose} /> From 0d3d05ac1955dec75a7433743cfe240ca72daf05 Mon Sep 17 00:00:00 2001 From: sharma01ketan Date: Thu, 12 Sep 2024 18:02:28 +0530 Subject: [PATCH 4/5] fix use different props for different stylings --- web/core/components/dropdowns/date.tsx | 4 +++- web/core/components/dropdowns/member/index.tsx | 4 +++- web/core/components/dropdowns/member/member-options.tsx | 5 +++-- .../issues/issue-layouts/properties/all-properties.tsx | 2 +- .../issue-layouts/spreadsheet/columns/assignee-column.tsx | 2 +- .../issue-layouts/spreadsheet/columns/due-date-column.tsx | 2 +- .../issue-layouts/spreadsheet/columns/start-date-column.tsx | 2 +- 7 files changed, 13 insertions(+), 8 deletions(-) diff --git a/web/core/components/dropdowns/date.tsx b/web/core/components/dropdowns/date.tsx index 9dba53ef443..db2dfa17eba 100644 --- a/web/core/components/dropdowns/date.tsx +++ b/web/core/components/dropdowns/date.tsx @@ -20,6 +20,7 @@ import { TDropdownProps } from "./types"; type Props = TDropdownProps & { clearIconClassName?: string; + optionsClassName?: string; icon?: React.ReactNode; isClearable?: boolean; minDate?: Date; @@ -39,6 +40,7 @@ export const DateDropdown: React.FC = (props) => { buttonVariant, className = "", clearIconClassName = "", + optionsClassName = "", closeOnSelect = true, disabled = false, hideIcon = false, @@ -163,7 +165,7 @@ export const DateDropdown: React.FC = (props) => {
void; renderByDefault?: boolean; + optionsClassName? : string; } & MemberDropdownProps; export const MemberDropdown: React.FC = observer((props) => { @@ -34,6 +35,7 @@ export const MemberDropdown: React.FC = observer((props) => { disabled = false, dropdownArrow = false, dropdownArrowClassName = "", + optionsClassName = "", hideIcon = false, multiple, onChange, @@ -160,7 +162,7 @@ export const MemberDropdown: React.FC = observer((props) => { > {isOpen && ( { - const { projectId, referenceElement, placement, isOpen, className="" } = props; + const { projectId, referenceElement, placement, isOpen, optionsClassName="" } = props; // states const [query, setQuery] = useState(""); const [popperElement, setPopperElement] = useState(null); @@ -95,7 +96,7 @@ export const MemberOptions = observer((props: Props) => {
= observer((props) => { buttonClassName={issue.assignee_ids?.length > 0 ? "hover:bg-transparent px-0" : ""} showTooltip={issue?.assignee_ids?.length === 0} placeholder="Assignees" - className="z-10" + optionsClassName="z-10" tooltipContent="" renderByDefault={isMobile} /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx index 5d565dd859b..a73b19cbd18 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx @@ -38,7 +38,7 @@ export const SpreadsheetAssigneeColumn: React.FC = observer((props: Props } buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" - className="z-9" + optionsClassName="z-9" onClose={onClose} />
diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx index 3eaa321aae4..915dc8b6208 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx @@ -53,7 +53,7 @@ export const SpreadsheetDueDateColumn: React.FC = observer((props: Props) "text-red-500": shouldHighlightIssueDueDate(issue.target_date, stateDetails?.group), } )} - className="z-9" + optionsClassName="z-[9px]" clearIconClassName="!text-custom-text-100" onClose={onClose} /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx index 46bc617fc97..1b0c4bd2322 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx @@ -40,7 +40,7 @@ export const SpreadsheetStartDateColumn: React.FC = observer((props: Prop buttonVariant="transparent-with-text" buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" - className="z-9" + optionsClassName="z-[9px]" onClose={onClose} />
From 1ebfb3c1d04ce3b55cce2dd71ef1a5adecc55d8a Mon Sep 17 00:00:00 2001 From: sharma01ketan Date: Thu, 12 Sep 2024 20:04:49 +0530 Subject: [PATCH 5/5] fix z index --- .../issues/issue-layouts/properties/all-properties.tsx | 6 ++---- .../issue-layouts/spreadsheet/columns/assignee-column.tsx | 2 +- .../issue-layouts/spreadsheet/columns/due-date-column.tsx | 2 +- .../issue-layouts/spreadsheet/columns/start-date-column.tsx | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/web/core/components/issues/issue-layouts/properties/all-properties.tsx b/web/core/components/issues/issue-layouts/properties/all-properties.tsx index 4785c86b9e6..e439635feeb 100644 --- a/web/core/components/issues/issue-layouts/properties/all-properties.tsx +++ b/web/core/components/issues/issue-layouts/properties/all-properties.tsx @@ -330,9 +330,8 @@ export const IssueProperties: React.FC = observer((props) => { placeholder="Start date" icon={} buttonVariant={issue.start_date ? "border-with-text" : "border-without-text"} - className="z-10" + optionsClassName="z-10" disabled={isReadOnly} - className="z-10" renderByDefault={isMobile} showTooltip /> @@ -351,9 +350,8 @@ export const IssueProperties: React.FC = observer((props) => { buttonVariant={issue.target_date ? "border-with-text" : "border-without-text"} buttonClassName={shouldHighlightIssueDueDate(issue.target_date, stateDetails?.group) ? "text-red-500" : ""} clearIconClassName="!text-custom-text-100" - className="z-10" + optionsClassName="z-10" disabled={isReadOnly} - className="z-10" renderByDefault={isMobile} showTooltip /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx index b154828ff8d..e6e54fcc343 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx @@ -38,7 +38,7 @@ export const SpreadsheetAssigneeColumn: React.FC = observer((props: Props } buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" - optionsClassName="z-[9px]" + optionsClassName="z-[9]" onClose={onClose} /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx index 915dc8b6208..57858ff7543 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx @@ -53,7 +53,7 @@ export const SpreadsheetDueDateColumn: React.FC = observer((props: Props) "text-red-500": shouldHighlightIssueDueDate(issue.target_date, stateDetails?.group), } )} - optionsClassName="z-[9px]" + optionsClassName="z-[9]" clearIconClassName="!text-custom-text-100" onClose={onClose} /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx index 1b0c4bd2322..a20c2472204 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx @@ -40,7 +40,7 @@ export const SpreadsheetStartDateColumn: React.FC = observer((props: Prop buttonVariant="transparent-with-text" buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" - optionsClassName="z-[9px]" + optionsClassName="z-[9]" onClose={onClose} />