From 9395c957dd15901eae8df67a272c4db302788ed8 Mon Sep 17 00:00:00 2001 From: rahulramesha Date: Fri, 13 Sep 2024 22:11:14 +0530 Subject: [PATCH 1/4] fix render on hover only when enabled --- web/core/components/dropdowns/buttons.tsx | 26 ++++++++++++++----- web/core/components/dropdowns/cycle/index.tsx | 1 + web/core/components/dropdowns/date-range.tsx | 1 + web/core/components/dropdowns/date.tsx | 1 + web/core/components/dropdowns/estimate.tsx | 1 + .../components/dropdowns/member/index.tsx | 3 ++- .../components/dropdowns/module/index.tsx | 1 + web/core/components/dropdowns/priority.tsx | 10 ++++--- web/core/components/dropdowns/project.tsx | 1 + web/core/components/dropdowns/state.tsx | 1 + .../issue-layouts/properties/labels.tsx | 2 +- .../spreadsheet/columns/assignee-column.tsx | 1 + .../spreadsheet/columns/cycle-column.tsx | 1 + .../spreadsheet/columns/due-date-column.tsx | 1 + .../spreadsheet/columns/estimate-column.tsx | 1 + .../spreadsheet/columns/label-column.tsx | 1 + .../spreadsheet/columns/module-column.tsx | 1 + .../spreadsheet/columns/priority-column.tsx | 1 + .../spreadsheet/columns/start-date-column.tsx | 1 + .../spreadsheet/columns/state-column.tsx | 1 + 20 files changed, 45 insertions(+), 12 deletions(-) diff --git a/web/core/components/dropdowns/buttons.tsx b/web/core/components/dropdowns/buttons.tsx index 125e264c161..4a49fb47a84 100644 --- a/web/core/components/dropdowns/buttons.tsx +++ b/web/core/components/dropdowns/buttons.tsx @@ -16,6 +16,7 @@ export type DropdownButtonProps = { tooltipHeading: string; showTooltip: boolean; variant: TButtonVariants; + renderToolTipByDefault?: boolean; }; type ButtonProps = { @@ -25,10 +26,20 @@ type ButtonProps = { tooltipContent: string | React.ReactNode; tooltipHeading: string; showTooltip: boolean; + renderToolTipByDefault?: boolean; }; export const DropdownButton: React.FC = (props) => { - const { children, className, isActive, tooltipContent, tooltipHeading, showTooltip, variant } = props; + const { + children, + className, + isActive, + tooltipContent, + renderToolTipByDefault = true, + tooltipHeading, + showTooltip, + variant, + } = props; const ButtonToRender: React.FC = BORDER_BUTTON_VARIANTS.includes(variant) ? BorderButton : BACKGROUND_BUTTON_VARIANTS.includes(variant) @@ -42,6 +53,7 @@ export const DropdownButton: React.FC = (props) => { tooltipContent={tooltipContent} tooltipHeading={tooltipHeading} showTooltip={showTooltip} + renderToolTipByDefault={renderToolTipByDefault} > {children} @@ -49,7 +61,7 @@ export const DropdownButton: React.FC = (props) => { }; const BorderButton: React.FC = (props) => { - const { children, className, isActive, tooltipContent, tooltipHeading, showTooltip } = props; + const { children, className, isActive, tooltipContent, renderToolTipByDefault, tooltipHeading, showTooltip } = props; const { isMobile } = usePlatformOS(); return ( @@ -58,7 +70,7 @@ const BorderButton: React.FC = (props) => { tooltipContent={tooltipContent} disabled={!showTooltip} isMobile={isMobile} - renderByDefault={false} + renderByDefault={renderToolTipByDefault} >
= (props) => { }; const BackgroundButton: React.FC = (props) => { - const { children, className, tooltipContent, tooltipHeading, showTooltip } = props; + const { children, className, tooltipContent, tooltipHeading, renderToolTipByDefault, showTooltip } = props; const { isMobile } = usePlatformOS(); return ( = (props) => { tooltipContent={tooltipContent} disabled={!showTooltip} isMobile={isMobile} - renderByDefault={false} + renderByDefault={renderToolTipByDefault} >
= (props) => { }; const TransparentButton: React.FC = (props) => { - const { children, className, isActive, tooltipContent, tooltipHeading, showTooltip } = props; + const { children, className, isActive, tooltipContent, tooltipHeading, renderToolTipByDefault, showTooltip } = props; const { isMobile } = usePlatformOS(); return ( = (props) => { tooltipContent={tooltipContent} disabled={!showTooltip} isMobile={isMobile} - renderByDefault={false} + renderByDefault={renderToolTipByDefault} >
= observer((props) => { tooltipContent={selectedName ?? placeholder} showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > {!hideIcon && } {BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && (!!selectedName || !!placeholder) && ( diff --git a/web/core/components/dropdowns/date-range.tsx b/web/core/components/dropdowns/date-range.tsx index c9e04fcfebc..453215e9947 100644 --- a/web/core/components/dropdowns/date-range.tsx +++ b/web/core/components/dropdowns/date-range.tsx @@ -161,6 +161,7 @@ export const DateRangeDropdown: React.FC = (props) => { } showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > = (props) => { tooltipContent={value ? renderFormattedDate(value, formatToken) : "None"} showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > {!hideIcon && icon} {BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && ( diff --git a/web/core/components/dropdowns/estimate.tsx b/web/core/components/dropdowns/estimate.tsx index 7428e67d709..f049adf74c5 100644 --- a/web/core/components/dropdowns/estimate.tsx +++ b/web/core/components/dropdowns/estimate.tsx @@ -180,6 +180,7 @@ export const EstimateDropdown: React.FC = observer((props) => { tooltipContent={selectedEstimate ? selectedEstimate?.value : placeholder} showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > {!hideIcon && } {(selectedEstimate || placeholder) && BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && ( diff --git a/web/core/components/dropdowns/member/index.tsx b/web/core/components/dropdowns/member/index.tsx index 3e9cd0d8a7a..f905bc27b2a 100644 --- a/web/core/components/dropdowns/member/index.tsx +++ b/web/core/components/dropdowns/member/index.tsx @@ -22,7 +22,7 @@ type Props = { icon?: LucideIcon; onClose?: () => void; renderByDefault?: boolean; - optionsClassName? : string; + optionsClassName?: string; } & MemberDropdownProps; export const MemberDropdown: React.FC = observer((props) => { @@ -134,6 +134,7 @@ export const MemberDropdown: React.FC = observer((props) => { tooltipContent={tooltipContent ?? `${value?.length ?? 0} assignee${value?.length !== 1 ? "s" : ""}`} showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > {!hideIcon && } {BUTTON_VARIANTS_WITH_TEXT.includes(buttonVariant) && ( diff --git a/web/core/components/dropdowns/module/index.tsx b/web/core/components/dropdowns/module/index.tsx index 9f0fa5e42a2..b4f20256bee 100644 --- a/web/core/components/dropdowns/module/index.tsx +++ b/web/core/components/dropdowns/module/index.tsx @@ -267,6 +267,7 @@ export const ModuleDropdown: React.FC = observer((props) => { } showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > { @@ -56,6 +57,7 @@ const BorderButton = (props: ButtonProps) => { placeholder, priority, showTooltip, + renderToolTipByDefault = true, } = props; const priorityDetails = ISSUE_PRIORITIES.find((p) => p.key === priority); @@ -76,7 +78,7 @@ const BorderButton = (props: ButtonProps) => { tooltipContent={priorityDetails?.title ?? "None"} disabled={!showTooltip} isMobile={isMobile} - renderByDefault={false} + renderByDefault={renderToolTipByDefault} >
{ placeholder, priority, showTooltip, + renderToolTipByDefault = true, } = props; const priorityDetails = ISSUE_PRIORITIES.find((p) => p.key === priority); @@ -157,7 +160,7 @@ const BackgroundButton = (props: ButtonProps) => { tooltipContent={priorityDetails?.title ?? "None"} disabled={!showTooltip} isMobile={isMobile} - renderByDefault={false} + renderByDefault={renderToolTipByDefault} >
{ placeholder, priority, showTooltip, + renderToolTipByDefault = true, } = props; const priorityDetails = ISSUE_PRIORITIES.find((p) => p.key === priority); @@ -239,7 +243,7 @@ const TransparentButton = (props: ButtonProps) => { tooltipContent={priorityDetails?.title ?? "None"} disabled={!showTooltip} isMobile={isMobile} - renderByDefault={false} + renderByDefault={renderToolTipByDefault} >
= observer((props) => { tooltipContent={selectedProject?.name ?? placeholder} showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > {!hideIcon && selectedProject && ( diff --git a/web/core/components/dropdowns/state.tsx b/web/core/components/dropdowns/state.tsx index b77b5d5cad1..c139d23c904 100644 --- a/web/core/components/dropdowns/state.tsx +++ b/web/core/components/dropdowns/state.tsx @@ -161,6 +161,7 @@ export const StateDropdown: React.FC = observer((props) => { tooltipContent={selectedState?.name ?? "State"} showTooltip={showTooltip} variant={buttonVariant} + renderToolTipByDefault={renderByDefault} > {stateLoader ? ( diff --git a/web/core/components/issues/issue-layouts/properties/labels.tsx b/web/core/components/issues/issue-layouts/properties/labels.tsx index 29cd54926d4..e6afae94972 100644 --- a/web/core/components/issues/issue-layouts/properties/labels.tsx +++ b/web/core/components/issues/issue-layouts/properties/labels.tsx @@ -165,7 +165,7 @@ export const IssuePropertyLabels: React.FC = observer((pro tooltipHeading="Labels" tooltipContent={label?.name ?? ""} isMobile={isMobile} - renderByDefault={false} + renderByDefault={renderByDefault} >
= observer((props: Props buttonContainerClassName="w-full" optionsClassName="z-[9]" onClose={onClose} + renderByDefault={false} />
); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx index d4a7886a07c..ea27a5b5611 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx @@ -57,6 +57,7 @@ export const SpreadsheetCycleColumn: React.FC = observer((props) => { buttonContainerClassName="w-full relative flex items-center p-2 group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonClassName="relative leading-4 h-4.5 bg-transparent hover:bg-transparent px-0" onClose={onClose} + renderByDefault={false} />
); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx index 57858ff7543..0ba2ee9d3f9 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx @@ -56,6 +56,7 @@ export const SpreadsheetDueDateColumn: React.FC = observer((props: Props) optionsClassName="z-[9]" clearIconClassName="!text-custom-text-100" onClose={onClose} + renderByDefault={false} />
); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx index d63b49da30f..376c07fbfab 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx @@ -28,6 +28,7 @@ export const SpreadsheetEstimateColumn: React.FC = observer((props: Props buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" onClose={onClose} + renderByDefault={false} />
); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx index 5afa6cc5539..7a45e7c1a16 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx @@ -35,6 +35,7 @@ export const SpreadsheetLabelColumn: React.FC = observer((props: Props) = disabled={disabled} placeholderText="Select labels" onClose={onClose} + renderByDefault={false} noLabelBorder fullWidth /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx index a20948bf05b..5f51d800579 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx @@ -67,6 +67,7 @@ export const SpreadsheetModuleColumn: React.FC = observer((props) => { buttonContainerClassName="w-full relative flex items-center p-2 group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonClassName="relative leading-4 h-4.5 bg-transparent hover:bg-transparent !px-0" onClose={onClose} + renderByDefault={false} multiple showCount showTooltip diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx index a23236f482b..00c6eeb2dba 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx @@ -25,6 +25,7 @@ export const SpreadsheetPriorityColumn: React.FC = observer((props: Props buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" onClose={onClose} + renderByDefault={false} />
); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx index a20c2472204..2cdd2019fb7 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx @@ -42,6 +42,7 @@ export const SpreadsheetStartDateColumn: React.FC = observer((props: Prop buttonContainerClassName="w-full" optionsClassName="z-[9]" onClose={onClose} + renderByDefault={false} />
); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx index 6a25938362b..57f0803b3e1 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx @@ -26,6 +26,7 @@ export const SpreadsheetStateColumn: React.FC = observer((props) => { buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" onClose={onClose} + renderByDefault={false} showTooltip />
From f85b39fc589e6b95fa10490a8d7497ee97b91f00 Mon Sep 17 00:00:00 2001 From: rahulramesha Date: Fri, 13 Sep 2024 22:20:32 +0530 Subject: [PATCH 2/4] add renderToolTipByDefault to button in Priority --- web/core/components/dropdowns/priority.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/web/core/components/dropdowns/priority.tsx b/web/core/components/dropdowns/priority.tsx index a971242c389..b1f05978dde 100644 --- a/web/core/components/dropdowns/priority.tsx +++ b/web/core/components/dropdowns/priority.tsx @@ -414,6 +414,7 @@ export const PriorityDropdown: React.FC = (props) => { placeholder={placeholder} showTooltip={showTooltip} hideText={BUTTON_VARIANTS_WITHOUT_TEXT.includes(buttonVariant)} + renderToolTipByDefault={renderByDefault} /> )} From ec00445b9667ca6efaf46757e122d5551c2ca69c Mon Sep 17 00:00:00 2001 From: rahulramesha Date: Wed, 18 Sep 2024 18:16:55 +0530 Subject: [PATCH 3/4] revert back rendering dropdowns on hover for spreadsheet view because of interference with keyboard navigation --- .../issues/issue-layouts/spreadsheet/columns/assignee-column.tsx | 1 - .../issues/issue-layouts/spreadsheet/columns/cycle-column.tsx | 1 - .../issues/issue-layouts/spreadsheet/columns/due-date-column.tsx | 1 - .../issues/issue-layouts/spreadsheet/columns/estimate-column.tsx | 1 - .../issues/issue-layouts/spreadsheet/columns/label-column.tsx | 1 - .../issues/issue-layouts/spreadsheet/columns/module-column.tsx | 1 - .../issues/issue-layouts/spreadsheet/columns/priority-column.tsx | 1 - .../issue-layouts/spreadsheet/columns/start-date-column.tsx | 1 - .../issues/issue-layouts/spreadsheet/columns/state-column.tsx | 1 - 9 files changed, 9 deletions(-) diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx index 510b000bf54..e6e54fcc343 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/assignee-column.tsx @@ -40,7 +40,6 @@ export const SpreadsheetAssigneeColumn: React.FC = observer((props: Props buttonContainerClassName="w-full" optionsClassName="z-[9]" onClose={onClose} - renderByDefault={false} /> ); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx index ea27a5b5611..d4a7886a07c 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/cycle-column.tsx @@ -57,7 +57,6 @@ export const SpreadsheetCycleColumn: React.FC = observer((props) => { buttonContainerClassName="w-full relative flex items-center p-2 group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonClassName="relative leading-4 h-4.5 bg-transparent hover:bg-transparent px-0" onClose={onClose} - renderByDefault={false} /> ); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx index 0ba2ee9d3f9..57858ff7543 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/due-date-column.tsx @@ -56,7 +56,6 @@ export const SpreadsheetDueDateColumn: React.FC = observer((props: Props) optionsClassName="z-[9]" clearIconClassName="!text-custom-text-100" onClose={onClose} - renderByDefault={false} /> ); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx index 376c07fbfab..d63b49da30f 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/estimate-column.tsx @@ -28,7 +28,6 @@ export const SpreadsheetEstimateColumn: React.FC = observer((props: Props buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" onClose={onClose} - renderByDefault={false} /> ); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx index 7a45e7c1a16..5afa6cc5539 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/label-column.tsx @@ -35,7 +35,6 @@ export const SpreadsheetLabelColumn: React.FC = observer((props: Props) = disabled={disabled} placeholderText="Select labels" onClose={onClose} - renderByDefault={false} noLabelBorder fullWidth /> diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx index 5f51d800579..a20948bf05b 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/module-column.tsx @@ -67,7 +67,6 @@ export const SpreadsheetModuleColumn: React.FC = observer((props) => { buttonContainerClassName="w-full relative flex items-center p-2 group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonClassName="relative leading-4 h-4.5 bg-transparent hover:bg-transparent !px-0" onClose={onClose} - renderByDefault={false} multiple showCount showTooltip diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx index 00c6eeb2dba..a23236f482b 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/priority-column.tsx @@ -25,7 +25,6 @@ export const SpreadsheetPriorityColumn: React.FC = observer((props: Props buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" onClose={onClose} - renderByDefault={false} /> ); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx index 2cdd2019fb7..a20c2472204 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/start-date-column.tsx @@ -42,7 +42,6 @@ export const SpreadsheetStartDateColumn: React.FC = observer((props: Prop buttonContainerClassName="w-full" optionsClassName="z-[9]" onClose={onClose} - renderByDefault={false} /> ); diff --git a/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx b/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx index 57f0803b3e1..6a25938362b 100644 --- a/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx +++ b/web/core/components/issues/issue-layouts/spreadsheet/columns/state-column.tsx @@ -26,7 +26,6 @@ export const SpreadsheetStateColumn: React.FC = observer((props) => { buttonClassName="text-left rounded-none group-[.selected-issue-row]:bg-custom-primary-100/5 group-[.selected-issue-row]:hover:bg-custom-primary-100/10 px-page-x" buttonContainerClassName="w-full" onClose={onClose} - renderByDefault={false} showTooltip /> From eafa8b2d42294c3bf6d52c7d67d93ed80fdd9473 Mon Sep 17 00:00:00 2001 From: rahulramesha Date: Wed, 18 Sep 2024 19:30:29 +0530 Subject: [PATCH 4/4] add comment in tooltip components --- packages/ui/src/tooltip/tooltip.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/ui/src/tooltip/tooltip.tsx b/packages/ui/src/tooltip/tooltip.tsx index 75e302577bb..c81048ae938 100644 --- a/packages/ui/src/tooltip/tooltip.tsx +++ b/packages/ui/src/tooltip/tooltip.tsx @@ -43,7 +43,7 @@ export const Tooltip: React.FC = ({ openDelay = 200, closeDelay, isMobile = false, - renderByDefault = true, + renderByDefault = true, //FIXME: tooltip should always render on hover and not by default, this is a temporary fix }) => { const toolTipRef = useRef(null);