From 3a9f94fa5c51a40388923f071fd762b8add5941d Mon Sep 17 00:00:00 2001 From: vamsi krishna Date: Mon, 2 Dec 2024 16:21:35 +0530 Subject: [PATCH 1/3] filters drop down fix safari --- .../issues/issue-layouts/filters/header/helpers/dropdown.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx b/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx index a16df50c17e..0cafa50ca86 100644 --- a/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx +++ b/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx @@ -85,7 +85,7 @@ export const FiltersDropdown: React.FC = (props) => { leaveFrom="opacity-100 translate-y-0" leaveTo="opacity-0 translate-y-1" > - +
Date: Tue, 3 Dec 2024 12:36:30 +0530 Subject: [PATCH 2/3] added comments for translation --- .../issues/issue-layouts/filters/header/helpers/dropdown.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx b/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx index 0cafa50ca86..f7c8deab1c7 100644 --- a/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx +++ b/web/core/components/issues/issue-layouts/filters/header/helpers/dropdown.tsx @@ -85,6 +85,7 @@ export const FiltersDropdown: React.FC = (props) => { leaveFrom="opacity-100 translate-y-0" leaveTo="opacity-0 translate-y-1" > + {/** translate-y-0 is a hack to create new stacking context. Required for safari */}
Date: Wed, 4 Dec 2024 14:31:55 +0530 Subject: [PATCH 3/3] fixed drop down visibility issue --- packages/ui/src/dropdowns/custom-menu.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/ui/src/dropdowns/custom-menu.tsx b/packages/ui/src/dropdowns/custom-menu.tsx index 274601822ea..e74fa594904 100644 --- a/packages/ui/src/dropdowns/custom-menu.tsx +++ b/packages/ui/src/dropdowns/custom-menu.tsx @@ -93,7 +93,14 @@ const CustomMenu = (props: ICustomMenuDropdownProps) => { useOutsideClickDetector(dropdownRef, closeDropdown, useCaptureForOutsideClick); let menuItems = ( - +