From b3582852e47f3c63f1aac5fa3f1f107d4d97d836 Mon Sep 17 00:00:00 2001 From: Vamsi krishna Date: Thu, 19 Dec 2024 15:56:03 +0530 Subject: [PATCH] * fix: avoided uncessary api call while creating issue draft * fix: fixed import order in module header --- .../components/issues/issue-modal/base.tsx | 28 ++++++++++--------- .../components/modules/module-view-header.tsx | 4 +-- 2 files changed, 17 insertions(+), 15 deletions(-) diff --git a/web/core/components/issues/issue-modal/base.tsx b/web/core/components/issues/issue-modal/base.tsx index 2a9d4abe1ce..ad0b0186fc1 100644 --- a/web/core/components/issues/issue-modal/base.tsx +++ b/web/core/components/issues/issue-modal/base.tsx @@ -187,19 +187,21 @@ export const CreateUpdateIssueModalBase: React.FC = observer(( if (!response) throw new Error(); // check if we should add issue to cycle/module - if ( - payload.cycle_id && - payload.cycle_id !== "" && - (payload.cycle_id !== cycleId || storeType !== EIssuesStoreType.CYCLE) - ) { - await addIssueToCycle(response, payload.cycle_id); - } - if ( - payload.module_ids && - payload.module_ids.length > 0 && - (!payload.module_ids.includes(moduleId?.toString()) || storeType !== EIssuesStoreType.MODULE) - ) { - await addIssueToModule(response, payload.module_ids); + if (!is_draft_issue) { + if ( + payload.cycle_id && + payload.cycle_id !== "" && + (payload.cycle_id !== cycleId || storeType !== EIssuesStoreType.CYCLE) + ) { + await addIssueToCycle(response, payload.cycle_id); + } + if ( + payload.module_ids && + payload.module_ids.length > 0 && + (!payload.module_ids.includes(moduleId?.toString()) || storeType !== EIssuesStoreType.MODULE) + ) { + await addIssueToModule(response, payload.module_ids); + } } // add other property values diff --git a/web/core/components/modules/module-view-header.tsx b/web/core/components/modules/module-view-header.tsx index 04403d2320a..6afcf2cc092 100644 --- a/web/core/components/modules/module-view-header.tsx +++ b/web/core/components/modules/module-view-header.tsx @@ -4,14 +4,14 @@ import React, { FC, useCallback, useEffect, useRef, useState } from "react"; import { observer } from "mobx-react"; import { useParams } from "next/navigation"; import { ListFilter, Search, X } from "lucide-react"; -// plane utils -import { cn } from "@plane/utils"; // plane helpers import { useOutsideClickDetector } from "@plane/hooks"; // types import { TModuleFilters } from "@plane/types"; // ui import { Tooltip } from "@plane/ui"; +// plane utils +import { cn } from "@plane/utils"; // components import { FiltersDropdown } from "@/components/issues"; import { ModuleFiltersSelection, ModuleOrderByDropdown } from "@/components/modules/dropdowns";