From 757e5381631df9d0d1847f9c5db15a06fa4db8f3 Mon Sep 17 00:00:00 2001 From: Vamsi krishna Date: Fri, 31 Jan 2025 16:59:51 +0530 Subject: [PATCH 1/2] fix: updated keys --- packages/i18n/src/locales/en/translations.json | 2 +- web/ce/constants/project/settings/tabs.ts | 2 +- web/core/components/exporter/export-modal.tsx | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/i18n/src/locales/en/translations.json b/packages/i18n/src/locales/en/translations.json index b1dccd243ab..1935a19e59a 100644 --- a/packages/i18n/src/locales/en/translations.json +++ b/packages/i18n/src/locales/en/translations.json @@ -513,7 +513,7 @@ "add_more": "Add more", "defaults": "Defaults", "add_label": "Add label", - "estimates": "estimates", + "estimates": "Estimates", "customize_time_range": "Customize time range", "loading": "Loading...", "attachments": "Attachments", diff --git a/web/ce/constants/project/settings/tabs.ts b/web/ce/constants/project/settings/tabs.ts index 0d3785a3458..50bff11151e 100644 --- a/web/ce/constants/project/settings/tabs.ts +++ b/web/ce/constants/project/settings/tabs.ts @@ -39,7 +39,7 @@ export const PROJECT_SETTINGS = { Icon: SettingIcon, }, labels: { - key: "i18n_labels", + key: "labels", i18n_label: "common.labels", href: `/settings/labels`, access: [EUserPermissions.ADMIN, EUserPermissions.MEMBER], diff --git a/web/core/components/exporter/export-modal.tsx b/web/core/components/exporter/export-modal.tsx index b54ea7d8cfe..05519d377d9 100644 --- a/web/core/components/exporter/export-modal.tsx +++ b/web/core/components/exporter/export-modal.tsx @@ -79,8 +79,8 @@ export const Exporter: React.FC = observer((props) => { setExportLoading(false); setToast({ type: TOAST_TYPE.SUCCESS, - title: t("workspace_settings.settings.exports.modal.success.title"), - message: t("workspace_settings.settings.exports.modal.success.message", { + title: t("workspace_settings.settings.exports.modal.toasts.success.title"), + message: t("workspace_settings.settings.exports.modal.toasts.success.message", { entity: provider === "csv" ? "CSV" : provider === "xlsx" ? "Excel" : provider === "json" ? "JSON" : "", }), }); @@ -90,7 +90,7 @@ export const Exporter: React.FC = observer((props) => { setToast({ type: TOAST_TYPE.ERROR, title: t("error"), - message: t("workspace_settings.settings.exports.modal.error.message"), + message: t("workspace_settings.settings.exports.modal.toasts.error.message"), }); }); } From efde075555735c647871f61f761b8dfae60fe332 Mon Sep 17 00:00:00 2001 From: Vamsi krishna Date: Fri, 31 Jan 2025 17:49:07 +0530 Subject: [PATCH 2/2] fix-sub work items toasts --- .../issues/issue-detail-widgets/sub-issues/helper.tsx | 8 ++++---- web/core/components/workspace/views/delete-view-modal.tsx | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx b/web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx index bcc5cbf8c88..def7e832f35 100644 --- a/web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx +++ b/web/core/components/issues/issue-detail-widgets/sub-issues/helper.tsx @@ -154,7 +154,7 @@ export const useSubIssueOperations = ( setToast({ type: TOAST_TYPE.SUCCESS, title: t("toast.success"), - message: t("common.sub_work_items.update.success"), + message: t("sub_work_item.update.success"), }); setSubIssueHelpers(parentIssueId, "issue_loader", issueId); } catch (error) { @@ -170,7 +170,7 @@ export const useSubIssueOperations = ( setToast({ type: TOAST_TYPE.ERROR, title: t("toast.error"), - message: t("common.sub_work_items.update.error"), + message: t("sub_work_item.update.error"), }); } }, @@ -191,7 +191,7 @@ export const useSubIssueOperations = ( setToast({ type: TOAST_TYPE.SUCCESS, title: t("toast.success"), - message: t("common.sub_work_items.remove.success"), + message: t("sub_work_item.remove.success"), }); captureIssueEvent({ eventName: "Sub-issue removed", @@ -216,7 +216,7 @@ export const useSubIssueOperations = ( setToast({ type: TOAST_TYPE.ERROR, title: t("toast.error"), - message: t("common.sub_work_items.remove.error"), + message: t("sub_work_item.remove.error"), }); } }, diff --git a/web/core/components/workspace/views/delete-view-modal.tsx b/web/core/components/workspace/views/delete-view-modal.tsx index 7252ef510c3..3d27d288705 100644 --- a/web/core/components/workspace/views/delete-view-modal.tsx +++ b/web/core/components/workspace/views/delete-view-modal.tsx @@ -42,7 +42,8 @@ export const DeleteGlobalViewModal: React.FC = observer((props) => { state: "SUCCESS", }); }) - .catch(() => { + .catch((error) => { + console.log({error}) captureEvent(GLOBAL_VIEW_DELETED, { view_id: data.id, state: "FAILED",