From a7c99ddea61246e5296a0602b3ecd9f56b67fa6e Mon Sep 17 00:00:00 2001
From: Anmol Singh Bhatia <anmolsinghbhatia@plane.so>
Date: Tue, 1 Apr 2025 13:57:28 +0530
Subject: [PATCH] fix: handle favorite entity data causing application error

---
 .../sidebar/favorites/favorites-menu.tsx      | 56 ++++++++++---------
 1 file changed, 30 insertions(+), 26 deletions(-)

diff --git a/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx b/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
index bfd08056da0..2beed74f66b 100644
--- a/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
+++ b/web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
@@ -252,33 +252,37 @@ export const SidebarFavoritesMenu = observer(() => {
                 orderBy(Object.values(groupedFavorites), "sequence", "desc")
                   .filter((fav) => !fav.parent)
                   .map((fav, index, { length }) => (
-                    <Tooltip
-                      key={fav.id}
-                      tooltipContent={fav?.entity_data ? fav.entity_data?.name : fav?.name}
-                      position="right"
-                      className="ml-2"
-                      disabled={!sidebarCollapsed}
-                      isMobile={isMobile}
-                    >
-                      {fav.is_folder ? (
-                        <FavoriteFolder
-                          favorite={fav}
-                          isLastChild={index === length - 1}
-                          handleRemoveFromFavorites={handleRemoveFromFavorites}
-                          handleRemoveFromFavoritesFolder={handleRemoveFromFavoritesFolder}
-                          handleDrop={handleDrop}
-                        />
-                      ) : (
-                        <FavoriteRoot
-                          workspaceSlug={workspaceSlug.toString()}
-                          favorite={fav}
-                          isLastChild={index === length - 1}
-                          parentId={undefined}
-                          handleRemoveFromFavorites={handleRemoveFromFavorites}
-                          handleDrop={handleDrop}
-                        />
+                    <>
+                      {fav?.id && (
+                        <Tooltip
+                          key={fav?.id}
+                          tooltipContent={fav?.entity_data ? fav?.entity_data?.name : fav?.name}
+                          position="right"
+                          className="ml-2"
+                          disabled={!sidebarCollapsed}
+                          isMobile={isMobile}
+                        >
+                          {fav?.is_folder ? (
+                            <FavoriteFolder
+                              favorite={fav}
+                              isLastChild={index === length - 1}
+                              handleRemoveFromFavorites={handleRemoveFromFavorites}
+                              handleRemoveFromFavoritesFolder={handleRemoveFromFavoritesFolder}
+                              handleDrop={handleDrop}
+                            />
+                          ) : (
+                            <FavoriteRoot
+                              workspaceSlug={workspaceSlug.toString()}
+                              favorite={fav}
+                              isLastChild={index === length - 1}
+                              parentId={undefined}
+                              handleRemoveFromFavorites={handleRemoveFromFavorites}
+                              handleDrop={handleDrop}
+                            />
+                          )}
+                        </Tooltip>
                       )}
-                    </Tooltip>
+                    </>
                   ))
               )}
             </Disclosure.Panel>